xiaoxiang781216 commented on pull request #1000:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1000#issuecomment-1037923833
Found by PR https://github.com/apache/incubator-nuttx/pull/5476
--
This is an automated message from the Apache Git Service.
To respond to the message, p
xiaoxiang781216 commented on pull request #5470:
URL: https://github.com/apache/incubator-nuttx/pull/5470#issuecomment-1037924718
Ok, Do you have plan to run NuttX on the secure side too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
xiaoxiang781216 merged pull request #5470:
URL: https://github.com/apache/incubator-nuttx/pull/5470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 64130b4 risc-v: Use _ebss instead of _default_stack_limit as idle
stack base
new 5c1c939 stm32u5:
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 70dae3bb3b5978c5bf49f5d2e9c05ee0fbe53425
Author: Michael Jung
AuthorDate: Sat Feb 12 10:21:30 2022 +0100
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 6086f42bfb0dfe946ddd3393fd1c76fb7f73468a
Author: Michael Jung
AuthorDate: Sat Feb 12 08:23:02 2022 +0100
zouboan opened a new pull request #1001:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1001
## Summary
Add support park transform angle from sensorless observer, support both
nolinear fluxlink observer and sliding mode observer
## Impact
The former foc control lib in ind
xiaoxiang781216 opened a new pull request #1002:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1002
## Summary
## Impact
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
xiaoxiang781216 commented on pull request #5476:
URL: https://github.com/apache/incubator-nuttx/pull/5476#issuecomment-1037967270
depends on https://github.com/apache/incubator-nuttx-apps/pull/1000 and
https://github.com/apache/incubator-nuttx-apps/pull/1002.
--
This is an automated mess
raiden00pl opened a new pull request #5480:
URL: https://github.com/apache/incubator-nuttx/pull/5480
## Summary
net/can/can_setsockopt.c: fix assertion, value can be NULL
## Impact
## Testing
canutils/cansend with CAN FD frames
--
This is an automated message from
michi-jung commented on pull request #5470:
URL: https://github.com/apache/incubator-nuttx/pull/5470#issuecomment-1037970517
No, I do not plan to run NuttX on the secure side. The ARM Platform
Security Architecture recommends to run the RTOS in the Non-secure state and
run some less compl
raiden00pl opened a new pull request #5481:
URL: https://github.com/apache/incubator-nuttx/pull/5481
## Summary
- stm32/fdcan: use array indexes when accessing RX/TX FIFO
- stm32/fdcan: add CAN FD frames support
## Impact
## Testing
nucleo-g431rb and b-g431b-esc1 i
xiaoxiang781216 opened a new pull request #5482:
URL: https://github.com/apache/incubator-nuttx/pull/5482
## Summary
Minor change
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
raiden00pl commented on pull request #5479:
URL: https://github.com/apache/incubator-nuttx/pull/5479#issuecomment-1038004024
It's great to see that someone starts working with FOC and NuttX :)
I had done some of this earlier but I didn't find the motivation to make it
ready to upstream.
xiaoxiang781216 commented on a change in pull request #5480:
URL: https://github.com/apache/incubator-nuttx/pull/5480#discussion_r805319740
##
File path: net/can/can_setsockopt.c
##
@@ -76,7 +76,7 @@ int can_setsockopt(FAR struct socket *psock, int option,
int ret = OK;
i
raiden00pl commented on a change in pull request #5479:
URL: https://github.com/apache/incubator-nuttx/pull/5479#discussion_r805320061
##
File path: libs/libdsp/lib_observer.c
##
@@ -495,6 +504,190 @@ void motor_sobserver_div(FAR struct motor_observer_f32_s
*o,
so->angle_pr
raiden00pl commented on pull request #1001:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1001#issuecomment-1038055936
It's better to separate all observers and place them in different modules.
Eg. one module for vel PLL observer, one for vel DIV observer etc.
More important
raiden00pl commented on a change in pull request #5480:
URL: https://github.com/apache/incubator-nuttx/pull/5480#discussion_r805324601
##
File path: net/can/can_setsockopt.c
##
@@ -76,7 +76,7 @@ int can_setsockopt(FAR struct socket *psock, int option,
int ret = OK;
int co
raiden00pl opened a new pull request #5483:
URL: https://github.com/apache/incubator-nuttx/pull/5483
## Summary
The main motivation of these changes is to improve modularity and enable
various combinations of the motor controller logic.
- libdsp/lib_observer.c: separate angle obse
raiden00pl commented on pull request #5479:
URL: https://github.com/apache/incubator-nuttx/pull/5479#issuecomment-1038120767
@zouboan you should look at
https://github.com/apache/incubator-nuttx/pull/5483 which solve various
problems that I found with the current observer interface.
--
raiden00pl commented on pull request #1001:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1001#issuecomment-1038123804
https://github.com/apache/incubator-nuttx/pull/5483
This PR separate observers logic in libdsp.
--
This is an automated message from the Apache Git Service
raiden00pl commented on pull request #1001:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1001#issuecomment-1038132031
Below you can find how I previously organized velocity observers into
modules. I can't find my code with angle observers now, but it should look
similar (use i
no1wudi opened a new pull request #5484:
URL: https://github.com/apache/incubator-nuttx/pull/5484
## Summary
* risc-v: Implement common up_cpu_idlestack
* Add -mstrictalign to arch level flags since it don't support unaligned
memory access
* Use common cpu idle stack implementation
zouboan commented on pull request #5479:
URL: https://github.com/apache/incubator-nuttx/pull/5479#issuecomment-1038184019
> It's great to see that someone starts working with FOC and NuttX :)
> I had done some of this earlier but I didn't find the motivation to make
it ready to upstream.
zouboan commented on a change in pull request #5479:
URL: https://github.com/apache/incubator-nuttx/pull/5479#discussion_r805349002
##
File path: libs/libdsp/lib_observer.c
##
@@ -495,6 +504,190 @@ void motor_sobserver_div(FAR struct motor_observer_f32_s
*o,
so->angle_prev
xiaoxiang781216 merged pull request #5480:
URL: https://github.com/apache/incubator-nuttx/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 5b678ab net/can/can_setsockopt.c: f
xiaoxiang781216 commented on a change in pull request #5484:
URL: https://github.com/apache/incubator-nuttx/pull/5484#discussion_r805349514
##
File path: arch/risc-v/src/common/riscv_cpuidlestack.c
##
@@ -0,0 +1,177 @@
+/*
zouboan commented on pull request #1001:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1001#issuecomment-1038204258
>
[apache/incubator-nuttx#5483](https://github.com/apache/incubator-nuttx/pull/5483)
> This PR separate observers logic in libdsp.
thanks, let me see!
masayuki2009 opened a new pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485
## Summary
- I noticed that the following error happened when loading the init
'elf_symvalue: SHN_COMMON: Re-compile with -fno-common'
- This commit fixes this issue
#
yamt commented on a change in pull request #5452:
URL: https://github.com/apache/incubator-nuttx/pull/5452#discussion_r805433938
##
File path: arch/sim/src/Makefile
##
@@ -285,11 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libboard$(LIBEXT
masayuki2009 merged pull request #5474:
URL: https://github.com/apache/incubator-nuttx/pull/5474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 34baf47 libc: posix_openpty should u
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 73bfef8 Publishing web
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r805455108
##
File path: tools/ci/testlist/sim-02.dat
##
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review commen
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r805455482
##
File path: tools/testbuild.sh
##
@@ -276,6 +281,18 @@ function build {
return $fail
}
+function run {
+ if [ ${RUN} -ne 0 ]; then
+run_
raiden00pl commented on pull request #5479:
URL: https://github.com/apache/incubator-nuttx/pull/5479#issuecomment-1038004024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zouboan closed pull request #5472:
URL: https://github.com/apache/incubator-nuttx/pull/5472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commit
xiaoxiang781216 commented on a change in pull request #5484:
URL: https://github.com/apache/incubator-nuttx/pull/5484#discussion_r805349514
##
File path: arch/risc-v/src/common/riscv_cpuidlestack.c
##
@@ -0,0 +1,177 @@
+/*
xiaoxiang781216 commented on a change in pull request #5480:
URL: https://github.com/apache/incubator-nuttx/pull/5480#discussion_r805319740
##
File path: net/can/can_setsockopt.c
##
@@ -76,7 +76,7 @@ int can_setsockopt(FAR struct socket *psock, int option,
int ret = OK;
i
ptka commented on a change in pull request #5401:
URL: https://github.com/apache/incubator-nuttx/pull/5401#discussion_r805203870
##
File path: arch/sim/include/setjmp.h
##
@@ -111,7 +145,8 @@
#ifndef __ASSEMBLY__
-#if defined(CONFIG_HOST_X86_64) && !defined(CONFIG_SIM_M32)
raiden00pl commented on pull request #5472:
URL: https://github.com/apache/incubator-nuttx/pull/5472#issuecomment-1037372954
There is nothing wrong with park_transform in other places. That's why it's
available in dsp.h/dspb16.h.
`v_dq_mod` is still application specific data which can be
xiaoxiang781216 commented on pull request #5476:
URL: https://github.com/apache/incubator-nuttx/pull/5476#issuecomment-1037967270
depends on https://github.com/apache/incubator-nuttx-apps/pull/1000 and
https://github.com/apache/incubator-nuttx-apps/pull/1002.
--
This is an automated mess
xiaoxiang781216 merged pull request #5480:
URL: https://github.com/apache/incubator-nuttx/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
zouboan commented on pull request #5472:
URL: https://github.com/apache/incubator-nuttx/pull/5472#issuecomment-1037268034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
michi-jung edited a comment on pull request #5470:
URL: https://github.com/apache/incubator-nuttx/pull/5470#issuecomment-1037873160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
xiaoxiang781216 commented on pull request #5401:
URL: https://github.com/apache/incubator-nuttx/pull/5401#issuecomment-1037471467
@ptka it's better that you could fix the stack alignment issue first.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
xiaoxiang781216 merged pull request #5459:
URL: https://github.com/apache/incubator-nuttx/pull/5459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
zouboan commented on pull request #5479:
URL: https://github.com/apache/incubator-nuttx/pull/5479#issuecomment-1038184019
> It's great to see that someone starts working with FOC and NuttX :)
> I had done some of this earlier but I didn't find the motivation to make
it ready to upstream.
masayuki2009 merged pull request #5468:
URL: https://github.com/apache/incubator-nuttx/pull/5468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
zouboan commented on pull request #1001:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1001#issuecomment-1038204258
>
[apache/incubator-nuttx#5483](https://github.com/apache/incubator-nuttx/pull/5483)
> This PR separate observers logic in libdsp.
thanks, let me see!
raiden00pl commented on pull request #1001:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1001#issuecomment-1038055936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r805455108
##
File path: tools/ci/testlist/sim-02.dat
##
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review commen
zouboan commented on a change in pull request #5479:
URL: https://github.com/apache/incubator-nuttx/pull/5479#discussion_r805349002
##
File path: libs/libdsp/lib_observer.c
##
@@ -495,6 +504,190 @@ void motor_sobserver_div(FAR struct motor_observer_f32_s
*o,
so->angle_prev
xiaoxiang781216 merged pull request #5171:
URL: https://github.com/apache/incubator-nuttx/pull/5171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 commented on a change in pull request #5401:
URL: https://github.com/apache/incubator-nuttx/pull/5401#discussion_r805203341
##
File path: arch/sim/include/setjmp.h
##
@@ -111,7 +145,8 @@
#ifndef __ASSEMBLY__
-#if defined(CONFIG_HOST_X86_64) && !defined(CONF
raiden00pl commented on a change in pull request #5480:
URL: https://github.com/apache/incubator-nuttx/pull/5480#discussion_r805324601
##
File path: net/can/can_setsockopt.c
##
@@ -76,7 +76,7 @@ int can_setsockopt(FAR struct socket *psock, int option,
int ret = OK;
int co
xiaoxiang781216 merged pull request #5478:
URL: https://github.com/apache/incubator-nuttx/pull/5478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
michi-jung commented on pull request #5470:
URL: https://github.com/apache/incubator-nuttx/pull/5470#issuecomment-1037873160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
xiaoxiang781216 commented on pull request #5470:
URL: https://github.com/apache/incubator-nuttx/pull/5470#issuecomment-1037475506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
xiaoxiang781216 merged pull request #5469:
URL: https://github.com/apache/incubator-nuttx/pull/5469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 commented on pull request #1000:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1000#issuecomment-1037923833
Found by PR https://github.com/apache/incubator-nuttx/pull/5476
--
This is an automated message from the Apache Git Service.
To respond to the message, p
raiden00pl commented on a change in pull request #5479:
URL: https://github.com/apache/incubator-nuttx/pull/5479#discussion_r805320061
##
File path: libs/libdsp/lib_observer.c
##
@@ -495,6 +504,190 @@ void motor_sobserver_div(FAR struct motor_observer_f32_s
*o,
so->angle_pr
xiaoxiang781216 merged pull request #5471:
URL: https://github.com/apache/incubator-nuttx/pull/5471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
yamt commented on a change in pull request #5452:
URL: https://github.com/apache/incubator-nuttx/pull/5452#discussion_r805433938
##
File path: arch/sim/src/Makefile
##
@@ -285,11 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libboard$(LIBEXT
xiaoxiang781216 merged pull request #5470:
URL: https://github.com/apache/incubator-nuttx/pull/5470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
masayuki2009 merged pull request #5474:
URL: https://github.com/apache/incubator-nuttx/pull/5474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
xiaoxiang781216 commented on a change in pull request #5452:
URL: https://github.com/apache/incubator-nuttx/pull/5452#discussion_r805468103
##
File path: arch/sim/src/Makefile
##
@@ -285,11 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libbo
xiaoxiang781216 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r805468511
##
File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs
##
@@ -45,6 +45,9 @@ ARCHWARNINGS = -Wall -Wstrict-prototypes -Wshadow -Wundef
xiaoxiang781216 merged pull request #5481:
URL: https://github.com/apache/incubator-nuttx/pull/5481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 34baf47 libc: posix_openpty should use the absolute path("dev/ptmx")
add dd8408a stm32/fdcan: use
yamt commented on a change in pull request #5452:
URL: https://github.com/apache/incubator-nuttx/pull/5452#discussion_r805470855
##
File path: arch/sim/src/Makefile
##
@@ -285,11 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libboard$(LIBEXT
yamt opened a new pull request #5486:
URL: https://github.com/apache/incubator-nuttx/pull/5486
## Summary
```
/usr/bin/ld: cannot open linker script file nuttx.ld: No such file or
directory
clang: error: linker command failed with exit code 1 (use -v to see
invocation)
yamt commented on a change in pull request #5452:
URL: https://github.com/apache/incubator-nuttx/pull/5452#discussion_r805476529
##
File path: arch/sim/src/Makefile
##
@@ -285,11 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libboard$(LIBEXT
xiaoxiang781216 opened a new pull request #5487:
URL: https://github.com/apache/incubator-nuttx/pull/5487
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
masayuki2009 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r805479196
##
File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs
##
@@ -45,6 +45,9 @@ ARCHWARNINGS = -Wall -Wstrict-prototypes -Wshadow -Wundef
A
xiaoxiang781216 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r805480356
##
File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs
##
@@ -39,8 +39,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
endif
ARCHCPUFLAGS =
xiaoxiang781216 opened a new pull request #5488:
URL: https://github.com/apache/incubator-nuttx/pull/5488
## Summary
like other's Make.defs
## Impact
No
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from cbbe1c6 net/can/can_recvmsg.c: fix unused variable 'conn' error
add 55d8862 risc-v: Implement comm
xiaoxiang781216 merged pull request #5484:
URL: https://github.com/apache/incubator-nuttx/pull/5484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
masayuki2009 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r805483079
##
File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs
##
@@ -39,8 +39,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
endif
ARCHCPUFLAGS = -mc
xiaoxiang781216 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r805483425
##
File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs
##
@@ -39,8 +39,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
endif
ARCHCPUFLAGS =
xiaoxiang781216 commented on pull request #5399:
URL: https://github.com/apache/incubator-nuttx/pull/5399#issuecomment-1038601386
@davids5 more people prefer the default value is better to align with other
debugging related option. How to avoid the PR stuck for a long time?
--
This is an
no1wudi opened a new pull request #1003:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1003
## Summary
Minor change
## Impact
None
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
masayuki2009 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r805491532
##
File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs
##
@@ -39,8 +39,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
endif
ARCHCPUFLAGS = -mc
masayuki2009 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r805491532
##
File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs
##
@@ -39,8 +39,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
endif
ARCHCPUFLAGS = -mc
xiaoxiang781216 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r805492565
##
File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs
##
@@ -39,8 +39,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
endif
ARCHCPUFLAGS =
xiaoxiang781216 closed pull request #5488:
URL: https://github.com/apache/incubator-nuttx/pull/5488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 commented on pull request #5488:
URL: https://github.com/apache/incubator-nuttx/pull/5488#issuecomment-1038617381
abandon see here: https://github.com/apache/incubator-nuttx/pull/5485
--
This is an automated message from the Apache Git Service.
To respond to the message, p
xiaoxiang781216 commented on a change in pull request #5486:
URL: https://github.com/apache/incubator-nuttx/pull/5486#discussion_r805493478
##
File path: arch/sim/src/Makefile
##
@@ -285,14 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libbo
xiaoxiang781216 commented on a change in pull request #5486:
URL: https://github.com/apache/incubator-nuttx/pull/5486#discussion_r805493618
##
File path: arch/sim/src/Makefile
##
@@ -285,14 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libbo
xiaoxiang781216 commented on pull request #5486:
URL: https://github.com/apache/incubator-nuttx/pull/5486#issuecomment-1038620919
@yamt please reorganize your pachset and remove the intermediate change.
--
This is an automated message from the Apache Git Service.
To respond to the message
yamt commented on pull request #5486:
URL: https://github.com/apache/incubator-nuttx/pull/5486#issuecomment-1038628351
> @yamt please reorganize your pachset and remove the intermediate change.
why? this PR contains only three commits and i feel they are independent.
--
This is
yamt commented on a change in pull request #5486:
URL: https://github.com/apache/incubator-nuttx/pull/5486#discussion_r805496906
##
File path: arch/sim/src/Makefile
##
@@ -285,14 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libboard$(LIBEXT
masayuki2009 commented on pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#issuecomment-1038660562
Hmm, I don't know why the Build / macOS (macos) failed.
```
Config
yamt commented on pull request #5476:
URL: https://github.com/apache/incubator-nuttx/pull/5476#issuecomment-1038663994
for simple functions like memset it might make sense.
for more complex functions, i'm not sure.
isn't it safer to enable them selectively as we do for alloca?
--
Th
masayuki2009 commented on pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#issuecomment-1038665127
>Hmm, I don't know why the Build / macOS (macos) failed.
My local build without this PR also fails.
--
This is an automated message from the Apache Git
xiaoxiang781216 commented on a change in pull request #5486:
URL: https://github.com/apache/incubator-nuttx/pull/5486#discussion_r805520014
##
File path: arch/sim/src/Makefile
##
@@ -285,14 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libbo
xiaoxiang781216 commented on a change in pull request #5486:
URL: https://github.com/apache/incubator-nuttx/pull/5486#discussion_r805520014
##
File path: arch/sim/src/Makefile
##
@@ -285,14 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libbo
xiaoxiang781216 commented on a change in pull request #5486:
URL: https://github.com/apache/incubator-nuttx/pull/5486#discussion_r805520014
##
File path: arch/sim/src/Makefile
##
@@ -285,14 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libbo
1 - 100 of 123 matches
Mail list logo
