masayuki2009 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r805483079
##########
File path: boards/arm/imx6/sabre-6quad/scripts/Make.defs
##########
@@ -39,8 +39,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
endif
ARCHCPUFLAGS = -mcpu=cortex-a9 -mfpu=vfpv4-d16
-ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections
-ARCHCXXFLAGS = -fno-builtin -fno-exceptions -fcheck-new -fno-rtti
+ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections -fno-common
Review comment:
> After checking other Make.defs, it look like the better place is add
-fno-common to CELFFLAGS/CXXELFFLAGS.
@xiaoxiang781216
I found that adding -fno-common to CELFFLAGS/CXXELFFLAGS does not work with
CONFIG_BUILD_KERNEL=y.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
