zhaoxiu-zeng opened a new pull request #955:
URL: https://github.com/apache/incubator-nuttx-apps/pull/955
task is blocked by semphore1, signal handler is blocked by semphore2,
after post semphore2, the task must get -EINTR.
Signed-off-by: Zeng Zhaoxiu
## Summary
## I
zhaoxiu-zeng commented on pull request #5120:
URL: https://github.com/apache/incubator-nuttx/pull/5120#issuecomment-1004597983
> > For example, task is blocked by nxsem_wait(sem1), use nxsem_wait(sem2)
> > in signal handler, and take sem2 successfully, after exit from signal
> > handle
Ouss4 commented on pull request #5147:
URL: https://github.com/apache/incubator-nuttx/pull/5147#issuecomment-1004611524
@AlanRosenthal sorry can you try to rebase again and drop the merge commit.
Looks like there are still issues.
--
This is an automated message from the Apache Git Serv
anchao opened a new pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154
## Summary
net/usrsock: replace xid type to uint64_t to avoid limitation of connections
## Impact
remove connect index logic and use usrsock_conn instance address
##
anchao opened a new pull request #956:
URL: https://github.com/apache/incubator-nuttx-apps/pull/956
## Summary
net/usrsock: replace xid type to uint64_t to avoid limitation of connections
## Impact
remove connect index logic and use usrsock_conn instance address
xiaoxiang781216 opened a new pull request #5155:
URL: https://github.com/apache/incubator-nuttx/pull/5155
## Summary
so all sdio client driver can reuse them
## Impact
Minor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respo
Ouss4 commented on pull request #5153:
URL: https://github.com/apache/incubator-nuttx/pull/5153#issuecomment-1004614537
Is this generic enough to have it in the top level Makefile?
In the descrption it says:
> This step is currently required for MPFS.
If it's only an MPF
anchao opened a new pull request #5156:
URL: https://github.com/apache/incubator-nuttx/pull/5156
## Summary
net/usrsock: add support for CONFIG_NET_ALLOC_CONNS
## Impact
N/A
## Testing
CI-check
--
This is an automated message from the Apache Git Service.
eenurkka commented on pull request #5153:
URL: https://github.com/apache/incubator-nuttx/pull/5153#issuecomment-1004619527
Ouss4, thanks for the pointers. I had something like that in mind, but
couldn't do it. I will try out & update this PR.
--
This is an automated message from the Apac
pkarashchenko commented on a change in pull request #5146:
URL: https://github.com/apache/incubator-nuttx/pull/5146#discussion_r777921360
##
File path: arch/arm/src/samv7/sam_freerun.c
##
@@ -220,8 +220,8 @@ int sam_freerun_initialize(struct sam_freerun_s *freerun,
int chan,
Ouss4 commented on a change in pull request #5155:
URL: https://github.com/apache/incubator-nuttx/pull/5155#discussion_r777931139
##
File path: drivers/mmcsd/sdio.c
##
@@ -1,5 +1,5 @@
/
- * drivers/wir
xiaoxiang781216 commented on a change in pull request #5155:
URL: https://github.com/apache/incubator-nuttx/pull/5155#discussion_r777939085
##
File path: drivers/mmcsd/sdio.c
##
@@ -1,5 +1,5 @@
/
- * d
xiaoxiang781216 commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r777940865
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +227,8 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock
xiaoxiang781216 commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r777941456
##
File path: include/nuttx/net/usrsock.h
##
@@ -96,8 +96,8 @@ enum usrsock_message_types_e
begin_packed_struct struct usrsock_request_
Ouss4 commented on a change in pull request #5153:
URL: https://github.com/apache/incubator-nuttx/pull/5153#discussion_r777944462
##
File path: tools/mpfs/Config.mk
##
@@ -0,0 +1,36 @@
+
+# tools/mpfs/C
eenurkka commented on a change in pull request #5153:
URL: https://github.com/apache/incubator-nuttx/pull/5153#discussion_r777945226
##
File path: tools/mpfs/Config.mk
##
@@ -0,0 +1,36 @@
+
+# tools/mpf
anchao commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r777959547
##
File path: include/nuttx/net/usrsock.h
##
@@ -96,8 +96,8 @@ enum usrsock_message_types_e
begin_packed_struct struct usrsock_request_common_s
xiaoxiang781216 commented on pull request #955:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/955#issuecomment-1004690155
@masayuki2009 cloud you try this patch with/without
https://github.com/apache/incubator-nuttx/pull/5120?
--
This is an automated message from the Apache G
xiaoxiang781216 commented on a change in pull request #952:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/952#discussion_r777975346
##
File path: netutils/netcat/Kconfig
##
@@ -47,4 +47,16 @@ config NETUTILS_NETCAT_STACKSIZE
int "netcat stack size"
d
xiaoxiang781216 commented on pull request #952:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/952#issuecomment-1004693194
@a-lunev do you have any perf number with/without this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
xiaoxiang781216 merged pull request #5153:
URL: https://github.com/apache/incubator-nuttx/pull/5153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new b4d2944 tools/mpfs: prepare OpenSBI
Donny9 opened a new pull request #5157:
URL: https://github.com/apache/incubator-nuttx/pull/5157
## Summary
fs/romfs: remove the error single list and using reference to manager file
opened.
## Impact
N/A
## Testing
daily test
--
This is an automated message from the A
Donny9 opened a new pull request #5158:
URL: https://github.com/apache/incubator-nuttx/pull/5158
## Summary
uart_rpmsg: fix data loss
Signed-off-by: Jiuzhu Dong
## Impact
get console output by cmd:cu correctly.
## Testing
daily test
--
This is an automat
Donny9 opened a new pull request #5159:
URL: https://github.com/apache/incubator-nuttx/pull/5159
## Summary
Extend socket_storage to fix compile warning about rexecd.
rexecd.c: In function 'rexecd_main':
rexecd.c:191:9: warning: array subscript 18 is outside array bounds
xiaoxiang781216 merged pull request #954:
URL: https://github.com/apache/incubator-nuttx-apps/pull/954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 0c79d57 note main: system/sche
no1wudi opened a new pull request #5160:
URL: https://github.com/apache/incubator-nuttx/pull/5160
## Summary
It can provide better auto complete experience for modern code editor,
since they use clang/gcc based parser to analyze code but lacks some
target dependent info such as __LP
xiaoxiang781216 commented on a change in pull request #5160:
URL: https://github.com/apache/incubator-nuttx/pull/5160#discussion_r778061230
##
File path: arch/risc-v/include/spinlock.h
##
@@ -78,7 +78,7 @@
* RISC-V architecture supports fence instruction to ensure memory orde
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new dce8c96 uart_rpmsg: fix data loss
d
xiaoxiang781216 merged pull request #5158:
URL: https://github.com/apache/incubator-nuttx/pull/5158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
jlaitine opened a new pull request #5161:
URL: https://github.com/apache/incubator-nuttx/pull/5161
Number of bits was set wrongly in TCSETS for mpfs
Signed-off-by: Jukka Laitinen
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
pkarashchenko commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778080793
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_m
pkarashchenko commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778083404
##
File path: include/nuttx/net/usrsock.h
##
@@ -96,8 +96,9 @@ enum usrsock_message_types_e
begin_packed_struct struct usrsock_request_co
pkarashchenko commented on a change in pull request #5156:
URL: https://github.com/apache/incubator-nuttx/pull/5156#discussion_r778088951
##
File path: net/usrsock/usrsock_conn.c
##
@@ -45,7 +46,9 @@
/* The array containing all usrsock connections. */
+#ifndef CONFIG_NET_A
pkarashchenko commented on a change in pull request #5156:
URL: https://github.com/apache/incubator-nuttx/pull/5156#discussion_r778089628
##
File path: net/usrsock/usrsock_conn.c
##
@@ -94,23 +97,36 @@ static void _usrsock_semgive(FAR sem_t *sem)
FAR struct usrsock_conn_s *usr
pkarashchenko commented on a change in pull request #5161:
URL: https://github.com/apache/incubator-nuttx/pull/5161#discussion_r778091306
##
File path: arch/risc-v/src/mpfs/mpfs_serial.c
##
@@ -907,10 +907,28 @@ static int up_ioctl(struct file *filep, int cmd, unsigned
long ar
pkarashchenko commented on a change in pull request #5161:
URL: https://github.com/apache/incubator-nuttx/pull/5161#discussion_r778091572
##
File path: arch/risc-v/src/mpfs/mpfs_serial.c
##
@@ -907,10 +907,28 @@ static int up_ioctl(struct file *filep, int cmd, unsigned
long ar
anchao commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778095657
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_message_
pkarashchenko commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778098949
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_m
pkarashchenko commented on a change in pull request #5159:
URL: https://github.com/apache/incubator-nuttx/pull/5159#discussion_r778104011
##
File path: include/sys/socket.h
##
@@ -284,23 +284,13 @@
* aligned at an appropriate boundary so that pointers to it can be cast
* as
pkarashchenko commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778098949
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_m
anchao commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778120305
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_message_
anchao commented on a change in pull request #5156:
URL: https://github.com/apache/incubator-nuttx/pull/5156#discussion_r778140212
##
File path: net/usrsock/usrsock_conn.c
##
@@ -45,7 +46,9 @@
/* The array containing all usrsock connections. */
+#ifndef CONFIG_NET_ALLOC_CO
anchao commented on a change in pull request #5156:
URL: https://github.com/apache/incubator-nuttx/pull/5156#discussion_r778142296
##
File path: net/usrsock/usrsock_conn.c
##
@@ -94,23 +97,36 @@ static void _usrsock_semgive(FAR sem_t *sem)
FAR struct usrsock_conn_s *usrsock_al
pkarashchenko commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778149092
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_m
pkarashchenko commented on a change in pull request #5156:
URL: https://github.com/apache/incubator-nuttx/pull/5156#discussion_r778155218
##
File path: net/usrsock/usrsock_conn.c
##
@@ -94,23 +97,36 @@ static void _usrsock_semgive(FAR sem_t *sem)
FAR struct usrsock_conn_s *usr
anchao commented on a change in pull request #5156:
URL: https://github.com/apache/incubator-nuttx/pull/5156#discussion_r778160048
##
File path: net/usrsock/usrsock_conn.c
##
@@ -94,23 +97,36 @@ static void _usrsock_semgive(FAR sem_t *sem)
FAR struct usrsock_conn_s *usrsock_al
pkarashchenko commented on a change in pull request #5156:
URL: https://github.com/apache/incubator-nuttx/pull/5156#discussion_r778161335
##
File path: net/usrsock/usrsock_conn.c
##
@@ -94,23 +97,36 @@ static void _usrsock_semgive(FAR sem_t *sem)
FAR struct usrsock_conn_s *usr
xiaoxiang781216 commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778164713
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock
anchao commented on a change in pull request #5156:
URL: https://github.com/apache/incubator-nuttx/pull/5156#discussion_r778164956
##
File path: net/usrsock/usrsock_conn.c
##
@@ -94,23 +97,36 @@ static void _usrsock_semgive(FAR sem_t *sem)
FAR struct usrsock_conn_s *usrsock_al
xiaoxiang781216 merged pull request #5160:
URL: https://github.com/apache/incubator-nuttx/pull/5160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from dce8c96 uart_rpmsg: fix data loss
add 3a0e86c arch/risc-v: Replace __LP64__ with CONFIG_ARCH_RV64
xiaoxiang781216 commented on a change in pull request #5159:
URL: https://github.com/apache/incubator-nuttx/pull/5159#discussion_r778168069
##
File path: include/sys/socket.h
##
@@ -284,23 +284,13 @@
* aligned at an appropriate boundary so that pointers to it can be cast
*
xiaoxiang781216 commented on a change in pull request #5159:
URL: https://github.com/apache/incubator-nuttx/pull/5159#discussion_r778168069
##
File path: include/sys/socket.h
##
@@ -284,23 +284,13 @@
* aligned at an appropriate boundary so that pointers to it can be cast
*
pkarashchenko commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778171266
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_m
AlanRosenthal commented on pull request #5147:
URL: https://github.com/apache/incubator-nuttx/pull/5147#issuecomment-1004907868
> @AlanRosenthal sorry can you try to rebase again and drop the merge
commit. Looks like there are still issues.
I tried resolving the conflict with github'
pkarashchenko commented on a change in pull request #5159:
URL: https://github.com/apache/incubator-nuttx/pull/5159#discussion_r778172599
##
File path: include/sys/socket.h
##
@@ -284,23 +284,13 @@
* aligned at an appropriate boundary so that pointers to it can be cast
* as
xiaoxiang781216 commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778178526
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock
xiaoxiang781216 commented on a change in pull request #5138:
URL: https://github.com/apache/incubator-nuttx/pull/5138#discussion_r778182272
##
File path: net/tcp/tcp_input.c
##
@@ -870,6 +870,11 @@ static void tcp_input(FAR struct net_driver_s *dev,
uint8_t domain,
pkarashchenko commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778182912
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_m
AlanRosenthal opened a new pull request #5162:
URL: https://github.com/apache/incubator-nuttx/pull/5162
## Summary
This PR improved dirlinks dependencies for Makefile.unix:
https://github.com/apache/incubator-nuttx/pull/5069
## Impact
This PR copies the changes into Makefile.wi
anchao commented on a change in pull request #5156:
URL: https://github.com/apache/incubator-nuttx/pull/5156#discussion_r778164956
##
File path: net/usrsock/usrsock_conn.c
##
@@ -94,23 +97,36 @@ static void _usrsock_semgive(FAR sem_t *sem)
FAR struct usrsock_conn_s *usrsock_al
xiaoxiang781216 commented on a change in pull request #5159:
URL: https://github.com/apache/incubator-nuttx/pull/5159#discussion_r778189089
##
File path: include/sys/socket.h
##
@@ -284,23 +284,13 @@
* aligned at an appropriate boundary so that pointers to it can be cast
*
xiaoxiang781216 commented on pull request #5162:
URL: https://github.com/apache/incubator-nuttx/pull/5162#issuecomment-1004927702
> ## Testing
> I'm relying on CI to verify the changes since I don't currently have a
windows env setup.
Sadly, we don't have CI for Windows yet:(, but
pkarashchenko commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778182912
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_m
pkarashchenko commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778182912
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_m
xiaoxiang781216 commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778201656
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock
xiaoxiang781216 commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778201656
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock
AlanRosenthal opened a new pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163
## Summary
This PR renames `tools/Makefile.*` to have the `.mk` extension. This PR also
updates `README.md` and other files that references the other files.
## Impact
By usin
AlanRosenthal opened a new pull request #5164:
URL: https://github.com/apache/incubator-nuttx/pull/5164
## Summary
With recent improvements to Makefiles in these PRs:
* https://github.com/apache/incubator-nuttx/pull/5055
* https://github.com/apache/incubator-nuttx/pull/5069
* htt
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 828f04f sdio: Move sdio utils fun
Ouss4 merged pull request #5155:
URL: https://github.com/apache/incubator-nuttx/pull/5155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-
Ouss4 commented on pull request #5147:
URL: https://github.com/apache/incubator-nuttx/pull/5147#issuecomment-1004987626
> > @AlanRosenthal sorry can you try to rebase again and drop the merge
commit. Looks like there are still issues.
>
> I tried resolving the conflict with github's
Ouss4 merged pull request #5147:
URL: https://github.com/apache/incubator-nuttx/pull/5147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 0951f70 Improve dependencies for
Ouss4 commented on pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163#issuecomment-1004992994
@AlanRosenthal we've got sone chicken'n'egg conflicts here. :)
Now that https://github.com/apache/incubator-nuttx/pull/5147 is merged, this
PR has conflicts. It will a
Ouss4 edited a comment on pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163#issuecomment-1004992994
@AlanRosenthal we've got sone chicken'n'egg conflicts here. :)
Now that https://github.com/apache/incubator-nuttx/pull/5147 is merged, this
PR has conflicts. It
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 57a19de Improve dirlinks dependenci
xiaoxiang781216 merged pull request #5162:
URL: https://github.com/apache/incubator-nuttx/pull/5162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 6ec006e socket: extend socket_stora
xiaoxiang781216 merged pull request #5159:
URL: https://github.com/apache/incubator-nuttx/pull/5159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 commented on a change in pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163#discussion_r778288307
##
File path: boards/mips/pic32mz/pic32mz-starterkit/README.txt
##
@@ -78,9 +78,9 @@ On Board Debug Support
The starter kit includes a
AlanRosenthal commented on a change in pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163#discussion_r778290301
##
File path: boards/mips/pic32mz/pic32mz-starterkit/README.txt
##
@@ -78,9 +78,9 @@ On Board Debug Support
The starter kit includes a PI
xiaoxiang781216 commented on pull request #904:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/904#issuecomment-1005056486
Nice idea, @coffee809721232 please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
xiaoxiang781216 commented on a change in pull request #904:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/904#discussion_r778290829
##
File path: netutils/dhcpc/dhcpc.c
##
@@ -445,6 +448,47 @@ static uint8_t dhcpc_parsemsg(FAR struct dhcpc_state_s
*pdhcpc, int bufl
pkarashchenko commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778319423
##
File path: include/nuttx/net/usrsock.h
##
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_m
a-lunev commented on pull request #952:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/952#issuecomment-1005114071
> @a-lunev do you have any perf number with/without this feature?
1. CONFIG_NET_TCP_WRITE_BUFFERS=n, CONFIG_NETUTILS_NETCAT_SENDFILE=n,
transmitted file size
a-lunev edited a comment on pull request #952:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/952#issuecomment-1005114071
> @a-lunev do you have any perf number with/without this feature?
1. CONFIG_NET_TCP_WRITE_BUFFERS=n, CONFIG_NETUTILS_NETCAT_SENDFILE=n, file
size is 50
a-lunev edited a comment on pull request #952:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/952#issuecomment-1005114071
> @a-lunev do you have any perf number with/without this feature?
Based on the current state of sim:tcpblaster config, the results are as
follow:
pkarashchenko commented on pull request #5157:
URL: https://github.com/apache/incubator-nuttx/pull/5157#issuecomment-1005129867
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
pkarashchenko commented on a change in pull request #5159:
URL: https://github.com/apache/incubator-nuttx/pull/5159#discussion_r778393269
##
File path: include/sys/socket.h
##
@@ -284,23 +284,13 @@
* aligned at an appropriate boundary so that pointers to it can be cast
* as
jlaitine commented on a change in pull request #5161:
URL: https://github.com/apache/incubator-nuttx/pull/5161#discussion_r778394624
##
File path: arch/risc-v/src/mpfs/mpfs_serial.c
##
@@ -907,10 +907,28 @@ static int up_ioctl(struct file *filep, int cmd, unsigned
long arg)
jlaitine commented on a change in pull request #5161:
URL: https://github.com/apache/incubator-nuttx/pull/5161#discussion_r778394798
##
File path: arch/risc-v/src/mpfs/mpfs_serial.c
##
@@ -907,10 +907,28 @@ static int up_ioctl(struct file *filep, int cmd, unsigned
long arg)
jlaitine commented on pull request #5161:
URL: https://github.com/apache/incubator-nuttx/pull/5161#issuecomment-1005177929
Thanks for reviews everyone, I still addressed points which @pkarashchenko
raised
--
This is an automated message from the Apache Git Service.
To respond to the mess
a-lunev commented on a change in pull request #952:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/952#discussion_r778423033
##
File path: netutils/netcat/Kconfig
##
@@ -47,4 +47,16 @@ config NETUTILS_NETCAT_STACKSIZE
int "netcat stack size"
default D
a-lunev commented on a change in pull request #952:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/952#discussion_r778423033
##
File path: netutils/netcat/Kconfig
##
@@ -47,4 +47,16 @@ config NETUTILS_NETCAT_STACKSIZE
int "netcat stack size"
default D
masayuki2009 commented on pull request #5159:
URL: https://github.com/apache/incubator-nuttx/pull/5159#issuecomment-1005267419
@Donny9 @xiaoxiang781216
Hmm, I noticed that the NTP daemon with spresense:wifi_smp crashed due to
stack corruption.
Before this PR,
```
24
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 70a2b9c Publishing web
yamt commented on a change in pull request #4881:
URL: https://github.com/apache/incubator-nuttx/pull/4881#discussion_r778486542
##
File path: drivers/video/vnc/vnc_keymap.c
##
@@ -29,13 +29,8 @@
#include
#include
-
-#define XK_MISCELLANY 1 /* Select X11 character set */
1 - 100 of 130 matches
Mail list logo
