pkarashchenko commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778182912
##########
File path: include/nuttx/net/usrsock.h
##########
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_message_common_s head;
- uint8_t xid;
- uint8_t reserved;
- int32_t result;
+ int16_t reserved;
Review comment:
@xiaoxiang781216 that is exactly what I have started from. The usecase
is either native alignment or `packed`. In both cases any `reserved` does not
make any sense because in case of native alignment all "reserved" will be added
by the compiler and in case of `packed` no padding will be done.
Maybe I'm missing something, but please point me to why do we need to add
any `reserved` into the structures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
