xiaoxiang781216 commented on a change in pull request #5154:
URL: https://github.com/apache/incubator-nuttx/pull/5154#discussion_r778178526
##########
File path: include/nuttx/net/usrsock.h
##########
@@ -227,9 +228,9 @@ begin_packed_struct struct usrsock_message_req_ack_s
{
struct usrsock_message_common_s head;
- uint8_t xid;
- uint8_t reserved;
- int32_t result;
+ int16_t reserved;
Review comment:
Yes, SoC which mix 32bit and 64bit arch is definitely the case we must
to support, that's why:
1. All struct shared by multi-core add [begin|end]_packed_struct to avoid
the different alignment on 32bit/64bit arch
2. All field use the explicit size type(e.g. int8_t/int16_t/int32_t) instead
of (int/long/size_t/intptr_t)
In this particular case, @anchao change xid from uint8_t to uint64_t,
because he want to save conn self(pionter) into xid, and then uint64_t is the
most suitable choice compare with uintptr_t or uint32_t.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
