[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3003: ESP32: Re-organise the different heap regions

2021-03-12 Thread GitBox
yamt commented on a change in pull request #3003: URL: https://github.com/apache/incubator-nuttx/pull/3003#discussion_r592976425 ## File path: boards/xtensa/esp32/esp32-devkitc/scripts/esp32.template.ld ## @@ -50,7 +50,7 @@ MEMORY * be used. */ - dram0_0_seg (RW) :

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3043: net/local: Remove local_send.c since nobody use it now

2021-03-12 Thread GitBox
xiaoxiang781216 opened a new pull request #3043: URL: https://github.com/apache/incubator-nuttx/pull/3043 ## Summary ## Impact Should no ## Testing Pass the build This is an automated message from the

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3036: License change : arch/risc-v, boards/risc-v

2021-03-12 Thread GitBox
xiaoxiang781216 merged pull request #3036: URL: https://github.com/apache/incubator-nuttx/pull/3036 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (9aaa406 -> d90f868)

2021-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 9aaa406 arch: imx6: Fix an error message in imx_enet.c add bb255d0 arch: risc-v: Author Masayuki I

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3003: ESP32: Re-organise the different heap regions

2021-03-12 Thread GitBox
yamt commented on a change in pull request #3003: URL: https://github.com/apache/incubator-nuttx/pull/3003#discussion_r592985326 ## File path: arch/xtensa/include/esp32/memory_layout.h ## @@ -32,66 +32,121 @@ * * CONFIG_HEAP2_BASE eg. 3f80 *

[incubator-nuttx] branch master updated (d90f868 -> e65d5d8)

2021-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from d90f868 boards: risc-v: Author Masayuki Ishikawa: Update license to Apache add e65d5d8 Revert "ne

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3037: Revert "net: tcp: Add DEBUGASSERT() in psock_tcp_send()"

2021-03-12 Thread GitBox
xiaoxiang781216 merged pull request #3037: URL: https://github.com/apache/incubator-nuttx/pull/3037 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (e65d5d8 -> 51be5c0)

2021-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from e65d5d8 Revert "net: tcp: Add DEBUGASSERT() in psock_tcp_send()" add 51be5c0 arch/sim/include/limi

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3039: arch/sim/include/limits.h: Fix the type of LONG_MIN, LONG_MAX, ULONG_MAX

2021-03-12 Thread GitBox
xiaoxiang781216 merged pull request #3039: URL: https://github.com/apache/incubator-nuttx/pull/3039 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] PeterBee97 opened a new pull request #3044: fix local_sendmsg return length

2021-03-12 Thread GitBox
PeterBee97 opened a new pull request #3044: URL: https://github.com/apache/incubator-nuttx/pull/3044 Previous patch for sendmsg left a bug in local socket which returns the wrong length. Fixed here :) This is an automate

[incubator-nuttx] branch master updated (51be5c0 -> d28962b)

2021-03-12 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 51be5c0 arch/sim/include/limits.h: Fix the type of LONG_MIN, LONG_MAX, ULONG_MAX add d28962b ri

[GitHub] [incubator-nuttx] Ouss4 merged pull request #3029: risc-v/esp32-c3: Adds termios support.

2021-03-12 Thread GitBox
Ouss4 merged pull request #3029: URL: https://github.com/apache/incubator-nuttx/pull/3029 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3003: ESP32: Re-organise the different heap regions

2021-03-12 Thread GitBox
Ouss4 commented on a change in pull request #3003: URL: https://github.com/apache/incubator-nuttx/pull/3003#discussion_r593010032 ## File path: arch/xtensa/include/esp32/memory_layout.h ## @@ -32,66 +32,121 @@ * * CONFIG_HEAP2_BASE eg. 3f80 *

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
Ouss4 commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593012573 ## File path: arch/risc-v/src/esp32c3/esp32c3_irq.c ## @@ -166,6 +189,52 @@ void up_disable_irq(int cpuint) leave_critical_section(irqstate); }

[GitHub] [incubator-nuttx] davids5 commented on pull request #3042: Do some adjustments for epoll

2021-03-12 Thread GitBox
davids5 commented on pull request #3042: URL: https://github.com/apache/incubator-nuttx/pull/3042#issuecomment-797347660 @buyuer - Please fill in the details [here](https://github.com/apache/incubator-nuttx/pull/3042#issue-591452871) ---

[GitHub] [incubator-nuttx] donghengqaz commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
donghengqaz commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593108929 ## File path: arch/risc-v/src/esp32c3/esp32c3_irq.c ## @@ -166,6 +189,52 @@ void up_disable_irq(int cpuint) leave_critical_section(irqstate

[GitHub] [incubator-nuttx] donghengqaz commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
donghengqaz commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593110165 ## File path: arch/risc-v/src/esp32c3/esp32c3_irq.c ## @@ -166,6 +189,52 @@ void up_disable_irq(int cpuint) leave_critical_section(irqstate

[GitHub] [incubator-nuttx] acassis commented on pull request #3043: net/local: Remove local_send.c since nobody use it now

2021-03-12 Thread GitBox
acassis commented on pull request #3043: URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797437216 Hi @xiaoxiang781216 please describe the commit better. Why we don't need it anymore? Please cite other commit or issue. Is it because local_sendmsg.c can be a replacemen

[GitHub] [incubator-nuttx] acassis commented on pull request #3043: net/local: Remove local_send.c since nobody use it now

2021-03-12 Thread GitBox
acassis commented on pull request #3043: URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797438520 Please supply more information [here](https://github.com/apache/incubator-nuttx/pull/3043#issue-591464860) -

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
acassis commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593115273 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,83 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depends o

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
acassis commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593115733 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,83 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depends o

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
acassis commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593115733 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,83 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depends o

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
Ouss4 commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593116852 ## File path: arch/risc-v/src/esp32c3/esp32c3_irq.c ## @@ -166,6 +189,52 @@ void up_disable_irq(int cpuint) leave_critical_section(irqstate); }

[GitHub] [incubator-nuttx] donghengqaz commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
donghengqaz commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593118241 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,83 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depen

[GitHub] [incubator-nuttx] davids5 commented on pull request #3043: net/local: Remove local_send.c since nobody use it now

2021-03-12 Thread GitBox
davids5 commented on pull request #3043: URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797443935 @acassis - I grepped the code base all the resent changes orphaned it. There has been a lot of really good work done on networking. @xiaoxiang781216 What is neede

[GitHub] [incubator-nuttx] davids5 commented on pull request #3043: net/local: Remove local_send.c since nobody use it now

2021-03-12 Thread GitBox
davids5 commented on pull request #3043: URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797444801 @acassis - when you satisfied please mereg This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #3043: net/local: Remove local_send.c since nobody use it now

2021-03-12 Thread GitBox
davids5 edited a comment on pull request #3043: URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797444801 @acassis - when you satisfied please merge This is an automated message from the Apache Git Servi

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593122074 ## File path: arch/risc-v/src/esp32c3/esp32c3_rt_timer.c ## @@ -0,0 +1,678 @@ +/*

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593122307 ## File path: arch/risc-v/src/esp32c3/esp32c3_rt_timer.c ## @@ -0,0 +1,678 @@ +/*

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593123955 ## File path: arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.h ## @@ -0,0 +1,242 @@ +/*

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593125978 ## File path: arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.h ## @@ -0,0 +1,242 @@ +/*

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593126262 ## File path: arch/risc-v/src/esp32c3/esp32c3_rt_timer.h ## @@ -0,0 +1,206 @@ +/*

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593126352 ## File path: arch/risc-v/src/esp32c3/esp32c3_rt_timer.h ## @@ -0,0 +1,206 @@ +/*

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-12 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593126415 ## File path: arch/risc-v/src/esp32c3/esp32c3_rt_timer.h ## @@ -0,0 +1,206 @@ +/*

[GitHub] [incubator-nuttx] acassis commented on pull request #3043: net/local: Remove local_send.c since nobody use it now

2021-03-12 Thread GitBox
acassis commented on pull request #3043: URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797462405 > @acassis - when you satisfied please merge Thank you @davids5 I just will wait for @xiaoxiang781216 reply/fix and merge it. ---

[GitHub] [incubator-nuttx] Donny9 opened a new pull request #3045: fs: Allocate file/socket dynamically

2021-03-12 Thread GitBox
Donny9 opened a new pull request #3045: URL: https://github.com/apache/incubator-nuttx/pull/3045 ## Summary Allocate file/socket dynamically. ## Impact Dynamically allocated file descriptor for every task can reduce ram, especially super task in a project. ## Testing daily te

[incubator-nuttx] branch master updated (d28962b -> 6f995e3)

2021-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from d28962b risc-v/esp32-c3: Adds termios support. add 6f995e3 fix local_sendmsg return length No new

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3044: fix local_sendmsg return length

2021-03-12 Thread GitBox
xiaoxiang781216 merged pull request #3044: URL: https://github.com/apache/incubator-nuttx/pull/3044 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r593152732 ## File path: arch/xtensa/src/esp32/Kconfig ## @@ -852,6 +852,21 @@ endmenu # ESP32_EMAC menu "WiFi configuration" depends on ESP32_

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r593163753 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c ## @@ -516,6 +561,70 @@ static inline int32_t esp_errno_trans(int ret) } } +

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-12 Thread GitBox
acassis commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r593148992 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c ## @@ -3960,6 +4088,47 @@ static unsigned long esp_random_ulong(void) return esp_rando

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r593165669 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c ## @@ -638,26 +755,20 @@ static int esp_event_lock(bool lock) static void esp_set_i

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r593173482 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c ## @@ -638,26 +755,20 @@ static int esp_event_lock(bool lock) static void esp_set_i

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r593173928 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c ## @@ -4682,82 +4775,812 @@ int esp_wifi_set_ssid(const uint8_t *pdata, uint8_t len

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r593176188 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c ## @@ -4682,82 +4775,812 @@ int esp_wifi_set_ssid(const uint8_t *pdata, uint8_t len

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r593177302 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c ## @@ -4682,82 +4775,812 @@ int esp_wifi_set_ssid(const uint8_t *pdata, uint8_t len

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r593177827 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.h ## @@ -121,10 +188,10 @@ int esp_wifi_sta_send_data(void *pbuf, uint32_t len); * N

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r593178367 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.h ## @@ -152,26 +235,178 @@ int esp_wifi_sta_register_recv_cb(int (*recv_cb)(void *bu

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #2939: URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r593178715 ## File path: arch/xtensa/src/esp32/esp32_wifi_adapter.h ## @@ -152,26 +235,178 @@ int esp_wifi_sta_register_recv_cb(int (*recv_cb)(void *bu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3043: net/local: Remove local_send.c since nobody use it now

2021-03-12 Thread GitBox
xiaoxiang781216 commented on pull request #3043: URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797501614 @acassis the commit message is updated This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #3046: arch/stm32: Fix nxstyle errors

2021-03-12 Thread GitBox
hartmannathan opened a new pull request #3046: URL: https://github.com/apache/incubator-nuttx/pull/3046 ## Summary Fix nxstyle errors in: - arch/arm/include/stm32h7/irq.h - arch/arm/include/stm32h7/stm32h7x7xx_irq.h ## Impact Removes nxstyle errors. ## T

[GitHub] [incubator-nuttx] davids5 opened a new pull request #3047: mmcsd:Stuck in 1-bit mode, Removed CONFIG_ARCH_HAVE_SDIO_DELAYED_INVLDT

2021-03-12 Thread GitBox
davids5 opened a new pull request #3047: URL: https://github.com/apache/incubator-nuttx/pull/3047 ## Summary mmcsd:Remove CONFIG_ARCH_HAVE_SDIO_DELAYED_INVLDT stm32h7:sdmmc remove CONFIG_ARCH_HAVE_SDIO_DELAYED_INVLDT stm32f7:sdmmc remove CONFIG_ARCH_HAVE_SDIO_DELAYED_IN

[GitHub] [incubator-nuttx] hartmannathan commented on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
hartmannathan commented on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797535193 Unless there is a reason why the final product should have NSH, for example if user interaction through NSH is a valid use case, then the vendor might consider removin

[GitHub] [incubator-nuttx] davids5 commented on pull request #3047: mmcsd:Stuck in 1-bit mode, Removed CONFIG_ARCH_HAVE_SDIO_DELAYED_INVLDT

2021-03-12 Thread GitBox
davids5 commented on pull request #3047: URL: https://github.com/apache/incubator-nuttx/pull/3047#issuecomment-797539793 FYI @jlaitine. I have asked Bob F to review this as well. This is an automated message from the Apache

[GitHub] [incubator-nuttx] antmerlino commented on pull request #3047: mmcsd:Stuck in 1-bit mode, Removed CONFIG_ARCH_HAVE_SDIO_DELAYED_INVLDT

2021-03-12 Thread GitBox
antmerlino commented on pull request #3047: URL: https://github.com/apache/incubator-nuttx/pull/3047#issuecomment-797559092 @davids5 Looks good to me, except I still think we need to protect for the case where the GPIO doesn't get configured for interrupt until after the interrupt fired. T

[GitHub] [incubator-nuttx] antmerlino edited a comment on pull request #3047: mmcsd:Stuck in 1-bit mode, Removed CONFIG_ARCH_HAVE_SDIO_DELAYED_INVLDT

2021-03-12 Thread GitBox
antmerlino edited a comment on pull request #3047: URL: https://github.com/apache/incubator-nuttx/pull/3047#issuecomment-797559092 @davids5 Looks good to me, except I still think we need to protect for the case where the GPIO doesn't get configured for interrupt until after the interrupt f

[GitHub] [incubator-nuttx-apps] Donny9 opened a new pull request #609: app: delete NFILE_DESCRIPTORS limits

2021-03-12 Thread GitBox
Donny9 opened a new pull request #609: URL: https://github.com/apache/incubator-nuttx-apps/pull/609 ## Summary Dynamically allocated file descriptor and delete NFILE_DESCRIPTORS limits. This patch associates with https://github.com/apache/incubator-nuttx/pull/3045. ## Impact ##

[GitHub] [incubator-nuttx] nix7965 commented on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 commented on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the following opini

[GitHub] [incubator-nuttx] nix7965 edited a comment on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 edited a comment on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the followin

[GitHub] [incubator-nuttx] nix7965 edited a comment on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 edited a comment on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the followin

[GitHub] [incubator-nuttx] nix7965 edited a comment on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 edited a comment on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the followin

[GitHub] [incubator-nuttx] nix7965 edited a comment on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 edited a comment on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the followin

[GitHub] [incubator-nuttx] nix7965 edited a comment on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 edited a comment on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the followin

[GitHub] [incubator-nuttx] nix7965 edited a comment on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 edited a comment on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the followin

[GitHub] [incubator-nuttx] nix7965 edited a comment on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 edited a comment on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the followin

[GitHub] [incubator-nuttx] nix7965 edited a comment on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 edited a comment on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the followin

[GitHub] [incubator-nuttx] nix7965 edited a comment on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 edited a comment on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the followin

[GitHub] [incubator-nuttx] nix7965 edited a comment on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 edited a comment on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the followin

[GitHub] [incubator-nuttx] nix7965 edited a comment on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
nix7965 edited a comment on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797603358 I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful Also, I have the followin

[GitHub] [incubator-nuttx] patacongo commented on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
patacongo commented on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797620137 > I would suggest we may need to disable "mw"-like commands as > @patacongo mentioned at default because > it does not look like s

[GitHub] [incubator-nuttx] btashton commented on issue #3011: Nsh Debug Commands Vulnerability Report

2021-03-12 Thread GitBox
btashton commented on issue #3011: URL: https://github.com/apache/incubator-nuttx/issues/3011#issuecomment-797621741 > I would suggest we may need to disable "mw"-like commands as @patacongo mentioned at default because it does not look like such useful > Also, I have the following

[incubator-nuttx] branch master updated (6f995e3 -> 6061981)

2021-03-12 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 6f995e3 fix local_sendmsg return length add 6061981 arch/stm32h7: Fix nxstyle errors No new rev

[GitHub] [incubator-nuttx] Ouss4 merged pull request #3046: arch/stm32h7: Fix nxstyle errors

2021-03-12 Thread GitBox
Ouss4 merged pull request #3046: URL: https://github.com/apache/incubator-nuttx/pull/3046 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3045: fs: Allocate file/socket dynamically

2021-03-12 Thread GitBox
acassis commented on a change in pull request #3045: URL: https://github.com/apache/incubator-nuttx/pull/3045#discussion_r593337052 ## File path: sched/Kconfig ## @@ -1058,12 +1058,12 @@ config SDCLONE_DISABLE descriptors by task_create() when a new task is started. If

[GitHub] [incubator-nuttx] jlaitine commented on pull request #3047: mmcsd:Stuck in 1-bit mode, Removed CONFIG_ARCH_HAVE_SDIO_DELAYED_INVLDT

2021-03-12 Thread GitBox
jlaitine commented on pull request #3047: URL: https://github.com/apache/incubator-nuttx/pull/3047#issuecomment-797642264 I agree that delayed invalidate doesn't really give any benefit; I am not sure I even really ever understood the motivation behind it. I fully support removing it ---

[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #3048: xtensa/esp32: timer driver refactor

2021-03-12 Thread GitBox
saramonteiro opened a new pull request #3048: URL: https://github.com/apache/incubator-nuttx/pull/3048 ## Summary It applies several improvements that were done while developing the timer driver for the ESP32-C3. It removes unused code. It Improves some logic in the isr attach func

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3048: xtensa/esp32: timer driver refactor

2021-03-12 Thread GitBox
acassis commented on a change in pull request #3048: URL: https://github.com/apache/incubator-nuttx/pull/3048#discussion_r593358395 ## File path: arch/xtensa/src/esp32/esp32_tim.c ## @@ -73,35 +71,28 @@ static void esp32_tim_modifyreg32(FAR struct esp32_tim_dev_s *dev, /* T

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3048: xtensa/esp32: timer driver refactor

2021-03-12 Thread GitBox
acassis commented on a change in pull request #3048: URL: https://github.com/apache/incubator-nuttx/pull/3048#discussion_r593361260 ## File path: arch/xtensa/src/esp32/esp32_tim.c ## @@ -252,13 +248,10 @@ static void esp32_tim_modifyreg32(FAR struct esp32_tim_dev_s *dev, *

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3048: xtensa/esp32: timer driver refactor

2021-03-12 Thread GitBox
acassis commented on a change in pull request #3048: URL: https://github.com/apache/incubator-nuttx/pull/3048#discussion_r593363359 ## File path: arch/xtensa/src/esp32/esp32_tim.c ## @@ -286,98 +276,12 @@ static int esp32_tim_stop(FAR struct esp32_tim_dev_s *dev) *

[GitHub] [incubator-nuttx] acassis commented on pull request #3048: xtensa/esp32: timer driver refactor

2021-03-12 Thread GitBox
acassis commented on pull request #3048: URL: https://github.com/apache/incubator-nuttx/pull/3048#issuecomment-797663912 I think it is not a good idea to move these functions to void, you could implement some logic testings in the future that you are don't realize now. ---

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #3048: xtensa/esp32: timer driver refactor

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #3048: URL: https://github.com/apache/incubator-nuttx/pull/3048#discussion_r593392204 ## File path: arch/xtensa/src/esp32/esp32_tim.c ## @@ -269,13 +262,10 @@ static int esp32_tim_start(FAR struct esp32_tim_dev_s *dev) * *

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #3048: xtensa/esp32: timer driver refactor

2021-03-12 Thread GitBox
saramonteiro commented on a change in pull request #3048: URL: https://github.com/apache/incubator-nuttx/pull/3048#discussion_r593392043 ## File path: arch/xtensa/src/esp32/esp32_tim.c ## @@ -252,13 +248,10 @@ static void esp32_tim_modifyreg32(FAR struct esp32_tim_dev_s *dev,

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3048: xtensa/esp32: timer driver refactor

2021-03-12 Thread GitBox
acassis commented on a change in pull request #3048: URL: https://github.com/apache/incubator-nuttx/pull/3048#discussion_r593393302 ## File path: arch/xtensa/src/esp32/esp32_tim.c ## @@ -269,13 +262,10 @@ static int esp32_tim_start(FAR struct esp32_tim_dev_s *dev) * **

[GitHub] [incubator-nuttx] saramonteiro commented on pull request #3048: xtensa/esp32: timer driver refactor

2021-03-12 Thread GitBox
saramonteiro commented on pull request #3048: URL: https://github.com/apache/incubator-nuttx/pull/3048#issuecomment-797697382 > I think it is not a good idea to move these functions to void, you could implement some logic testings in the future that you are don't realize now. I don't

[incubator-nuttx] branch master updated (6061981 -> 0c57351)

2021-03-12 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 6061981 arch/stm32h7: Fix nxstyle errors add 0c57351 mmcsd:Stuck in 1-bit mode, Removed CONFIG_ARCH

[GitHub] [incubator-nuttx] acassis merged pull request #3047: mmcsd:Stuck in 1-bit mode, Removed CONFIG_ARCH_HAVE_SDIO_DELAYED_INVLDT

2021-03-12 Thread GitBox
acassis merged pull request #3047: URL: https://github.com/apache/incubator-nuttx/pull/3047 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-nuttx] branch master updated (0c57351 -> 9523d4b)

2021-03-12 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 0c57351 mmcsd:Stuck in 1-bit mode, Removed CONFIG_ARCH_HAVE_SDIO_DELAYED_INVLDT add 9523d4b net/loc

[GitHub] [incubator-nuttx] acassis merged pull request #3043: net/local: Remove local_send.c since nobody use it now

2021-03-12 Thread GitBox
acassis merged pull request #3043: URL: https://github.com/apache/incubator-nuttx/pull/3043 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx] davids5 commented on pull request #3047: mmcsd:Stuck in 1-bit mode, Removed CONFIG_ARCH_HAVE_SDIO_DELAYED_INVLDT

2021-03-12 Thread GitBox
davids5 commented on pull request #3047: URL: https://github.com/apache/incubator-nuttx/pull/3047#issuecomment-797716774 > @davids5 Looks good to me, except I still think we need to protect for the case where the GPIO doesn't get configured for interrupt until after the interrupt fired. Th

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3048: xtensa/esp32: timer driver refactor

2021-03-12 Thread GitBox
acassis commented on a change in pull request #3048: URL: https://github.com/apache/incubator-nuttx/pull/3048#discussion_r593421574 ## File path: arch/xtensa/src/esp32/esp32_tim.c ## @@ -252,13 +248,10 @@ static void esp32_tim_modifyreg32(FAR struct esp32_tim_dev_s *dev, *

[GitHub] [incubator-nuttx] davids5 commented on pull request #3045: fs: Allocate file/socket dynamically

2021-03-12 Thread GitBox
davids5 commented on pull request #3045: URL: https://github.com/apache/incubator-nuttx/pull/3045#issuecomment-79770 @Donny9 is there a set of PRs for this that need to come in in some order? This is an automated message

[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #3045: fs: Allocate file/socket dynamically

2021-03-12 Thread GitBox
Donny9 commented on a change in pull request #3045: URL: https://github.com/apache/incubator-nuttx/pull/3045#discussion_r593518073 ## File path: sched/Kconfig ## @@ -1058,12 +1058,12 @@ config SDCLONE_DISABLE descriptors by task_create() when a new task is started. If

[GitHub] [incubator-nuttx] Donny9 commented on pull request #3045: fs: Allocate file/socket dynamically

2021-03-12 Thread GitBox
Donny9 commented on pull request #3045: URL: https://github.com/apache/incubator-nuttx/pull/3045#issuecomment-797822834 > @Donny9 is there a set of PRs for this that need to come in in some order? yes, This patch associates with apache/incubator-nuttx-apps#609,it need to merge firstl

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #609: app: delete NFILE_DESCRIPTORS limits

2021-03-12 Thread GitBox
xiaoxiang781216 merged pull request #609: URL: https://github.com/apache/incubator-nuttx-apps/pull/609 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated: app: delete NFILE_DESCRIPTORS limits

2021-03-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 4c6ded2 app: delete NFILE_DESC