yamt commented on a change in pull request #3003:
URL: https://github.com/apache/incubator-nuttx/pull/3003#discussion_r592985326
##########
File path: arch/xtensa/include/esp32/memory_layout.h
##########
@@ -32,66 +32,121 @@
*
* CONFIG_HEAP2_BASE eg. 3f80 0000
* :
- * : g_mmheap region3 (CONFIG_ESP32_SPIRAM)
+ * : g_mmheap (CONFIG_ESP32_SPIRAM)
* :
* CONFIG_HEAP2_BASE + CONFIG_HEAP2_SIZE eg. 3fc0 0000
*
- * _sheap eg. 3ffc 8c6c
+ * HEAP_REGION0_START 3ffa e6f0
* :
- * : g_iheap (CONFIG_XTENSA_IMEM_USE_SEPARATE_HEAP)
+ * : g_mmheap region0
* :
- * _sheap + CONFIG_XTENSA_IMEM_REGION_SIZE eg. 3ffd ebfc
+ * HEAP_REGION0_END 3ffa fff0
+ * :
+ * _sheap eg. 3ffc 8c6c
* :
* : g_mmheap region1
* :
* HEAP_REGION1_END 3ffd fff0
* :
* : ROM data
* :
- * HEAP_REGION2_START 3ffe 1330 or 3ffe 7e40
+ * HEAP_REGION2_START 3ffe 0450
+ * :
+ * : g_iheap (CONFIG_XTENSA_IMEM_USE_SEPARATE_HEAP)
Review comment:
this iheap region is only for !SMP, right?
i guess it's more straightforward to make the `if CONFIG_SMP` block below
start from `HEAP_REGION2_START`.
that is:
```
------------
if !CONFIG_SMP
HEAP_REGION2_START
:
(omit)
:
------------
if CONFIG_SMP
HEAP_REGION2_START
:
(omit)
:
------------
_eheap
```
how do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
