acassis commented on a change in pull request #3048:
URL: https://github.com/apache/incubator-nuttx/pull/3048#discussion_r593358395
##########
File path: arch/xtensa/src/esp32/esp32_tim.c
##########
@@ -73,35 +71,28 @@ static void esp32_tim_modifyreg32(FAR struct
esp32_tim_dev_s *dev,
/* TIM operations ***********************************************************/
-static int esp32_tim_start(FAR struct esp32_tim_dev_s *dev);
-static int esp32_tim_stop(FAR struct esp32_tim_dev_s *dev);
-static int esp32_tim_clear(FAR struct esp32_tim_dev_s *dev);
-static int esp32_tim_configure(FAR struct esp32_tim_dev_s *dev, uint16_t pre,
- uint8_t mode, uint64_t counter_value,
- uint64_t alarm_value, bool alarm,
- bool autoreload);
-static int esp32_tim_setmode(FAR struct esp32_tim_dev_s *dev, uint8_t mode);
-static int esp32_tim_setpre(FAR struct esp32_tim_dev_s *dev, uint16_t pre);
-static int esp32_tim_getconfig(FAR struct esp32_tim_dev_s *dev,
- uint32_t *value);
-static int esp32_tim_getcounter(FAR struct esp32_tim_dev_s *dev,
- uint64_t *value);
-static int esp32_tim_setcounter(FAR struct esp32_tim_dev_s *dev,
- uint64_t value);
-static int esp32_tim_reload_now(FAR struct esp32_tim_dev_s *dev);
-static int esp32_tim_getalarmvalue(FAR struct esp32_tim_dev_s *dev,
- uint64_t *value);
-static int esp32_tim_setalarmvalue(FAR struct esp32_tim_dev_s *dev,
- uint64_t value);
-static int esp32_tim_setalarm(FAR struct esp32_tim_dev_s *dev, bool enable);
-static int esp32_tim_setautoreload(FAR struct esp32_tim_dev_s *dev,
- bool enable);
-static int esp32_tim_setisr(FAR struct esp32_tim_dev_s *dev, xcpt_t handler,
- FAR void * arg);
-static int esp32_tim_enableint(FAR struct esp32_tim_dev_s *dev);
-static int esp32_tim_disableint(FAR struct esp32_tim_dev_s *dev);
-static int esp32_tim_checkint(FAR struct esp32_tim_dev_s *dev);
-static int esp32_tim_ackint(FAR struct esp32_tim_dev_s *dev);
+static void esp32_tim_start(FAR struct esp32_tim_dev_s *dev);
+static void esp32_tim_stop(FAR struct esp32_tim_dev_s *dev);
+static void esp32_tim_clear(FAR struct esp32_tim_dev_s *dev);
+static void esp32_tim_setmode(FAR struct esp32_tim_dev_s *dev, uint8_t mode);
+static void esp32_tim_setpre(FAR struct esp32_tim_dev_s *dev, uint16_t pre);
+static void esp32_tim_getcounter(FAR struct esp32_tim_dev_s *dev,
+ uint64_t *value);
+static void esp32_tim_setcounter(FAR struct esp32_tim_dev_s *dev,
+ uint64_t value);
+static void esp32_tim_reload_now(FAR struct esp32_tim_dev_s *dev);
+static void esp32_tim_getalarmvalue(FAR struct esp32_tim_dev_s *dev,
+ uint64_t *value);
+static void esp32_tim_setalarmvalue(FAR struct esp32_tim_dev_s *dev,
+ uint64_t value);
+static void esp32_tim_setalarm(FAR struct esp32_tim_dev_s *dev, bool enable);
+static void esp32_tim_setautoreload(FAR struct esp32_tim_dev_s *dev,
+ bool enable);
+static int esp32_tim_setisr(FAR struct esp32_tim_dev_s *dev, xcpt_t handler,
+ FAR void * arg);
Review comment:
please remove space "* arg"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
