masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525880123
##
File path: drivers/audio/cxd56.c
##
@@ -1272,6 +1276,149 @@ static void cxd56_reset_channel_sel(cxd56_dmahandle_t
handle)
}
}
+#i
xiaoxiang781216 commented on pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-729507112
> > > > Yes, it is used, but all configs can build fine by removing
compiler_stdint.h. So I think it is redundant and should be removed.
> > >
> > >
>
masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525880696
##
File path: drivers/audio/cxd56.c
##
@@ -1272,6 +1276,149 @@ static void cxd56_reset_channel_sel(cxd56_dmahandle_t
handle)
}
}
+#i
masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525880123
##
File path: drivers/audio/cxd56.c
##
@@ -1272,6 +1276,149 @@ static void cxd56_reset_channel_sel(cxd56_dmahandle_t
handle)
}
}
+#i
xiaoxiang781216 merged pull request #483:
URL: https://github.com/apache/incubator-nuttx-apps/pull/483
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new a96867a test/sensor: fix test
xiaoxiang781216 edited a comment on pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-729507112
> > > > Yes, it is used, but all configs can build fine by removing
compiler_stdint.h. So I think it is redundant and should be removed.
> > >
> > >
Donny9 commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729523664
> Also, why the need to introduce a config variable for the gyro which is
actually on-board? I would presume this should always be zero (many boards do
this).
okay
Donny9 commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729523777
> Can you move the check for HPWORK define in code to Kconfig, only for when
BUFFER > 0?
done
Thi
jerpelea commented on pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#issuecomment-729524065
@xiaoxiang781216 moved to libc/audio
This is an automated message from the Apache Git Service.
To respo
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525901566
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/cir
xiaoxiang781216 merged pull request #2331:
URL: https://github.com/apache/incubator-nuttx/pull/2331
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from c22ab31 fs: flashback to release all file descriptors in group to
increase debugging time.
add bc4
xiaoxiang781216 commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525914316
##
File path:
libs/libc/audio/libsrc/0001-samplerate-define-package-and-version-for-NuttX-OS.patch
##
@@ -0,0 +1,34 @@
+From 23d050a04e00
jerpelea commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525918901
##
File path:
libs/libc/audio/libsrc/0001-samplerate-define-package-and-version-for-NuttX-OS.patch
##
@@ -0,0 +1,34 @@
+From 23d050a04e00d7029a6
jerpelea commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525919257
##
File path: libs/libc/audio/libsrc/Make.defs
##
@@ -0,0 +1,49 @@
+
xiaoxiang781216 commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525926531
##
File path: libs/libc/audio/libsrc/Make.defs
##
@@ -0,0 +1,49 @@
+##
xiaoxiang781216 commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525926531
##
File path: libs/libc/audio/libsrc/Make.defs
##
@@ -0,0 +1,49 @@
+##
Ouss4 commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525937558
##
File path: libs/libc/audio/libsrc/Make.defs
##
@@ -0,0 +1,49 @@
+
+#
Ouss4 commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525937558
##
File path: libs/libc/audio/libsrc/Make.defs
##
@@ -0,0 +1,49 @@
+
+#
jerpelea commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525938688
##
File path: libs/libc/audio/libsrc/Make.defs
##
@@ -0,0 +1,49 @@
+
retogaeh opened a new pull request #2332:
URL: https://github.com/apache/incubator-nuttx/pull/2332
## Summary
Simplification of previous fix. Also fixes the case when new data should
be sent while a keepalive is not yet ACKed.
_Previous fix did not work properly_
## Impac
rzr opened a new pull request #2333:
URL: https://github.com/apache/incubator-nuttx/pull/2333
Change-Id: I98e72d341f46c2e03efdb6cc93124a2f49613f19
Relate-to: https://github.com/apache/incubator-nuttx/issues/1988
Relate-to: https://github.com/apache/incubator-nuttx-apps/pull/482
Rela
jerpelea commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525938688
##
File path: libs/libc/audio/libsrc/Make.defs
##
@@ -0,0 +1,49 @@
+
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525956903
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/cir
juniskane commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r525998185
##
File path: include/unistd.h
##
@@ -44,6 +44,8 @@
#include
#include
+#include
Review comment:
Should not include this here. Non
masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r526005031
##
File path: drivers/audio/cxd56_src.c
##
@@ -0,0 +1,607 @@
+/
+
jerpelea commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r526012405
##
File path: drivers/audio/cxd56_src.c
##
@@ -0,0 +1,607 @@
+/
+ * d
xiaoxiang781216 commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526016958
##
File path: include/unistd.h
##
@@ -44,6 +44,8 @@
#include
#include
+#include
Review comment:
Done.
-
donghengqaz commented on a change in pull request #2294:
URL: https://github.com/apache/incubator-nuttx/pull/2294#discussion_r526031328
##
File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c
##
@@ -2210,6 +2300,19 @@ void esp_phy_disable_clock(void)
leave_critical_section(
xiaoxiang781216 commented on pull request #2333:
URL: https://github.com/apache/incubator-nuttx/pull/2333#issuecomment-729632660
@rzr please run:
./tools/refresh.sh --silent freedom-k64f/demo
This is an automated message f
xiaoxiang781216 edited a comment on pull request #2333:
URL: https://github.com/apache/incubator-nuttx/pull/2333#issuecomment-729632660
@rzr please run to fix the check error:
./tools/refresh.sh --silent freedom-k64f/demo
yamt commented on pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-729650746
> > > > > Yes, it is used, but all configs can build fine by removing
compiler_stdint.h. So I think it is redundant and should be removed.
> > > >
> > > >
> > > >
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526055620
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/cir
patacongo commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526064104
##
File path: include/getopt.h
##
@@ -0,0 +1,154 @@
+/
+ * include/g
patacongo commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526064407
##
File path: include/getopt.h
##
@@ -0,0 +1,154 @@
+/
+ * include/g
patacongo commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526064739
##
File path: include/getopt.h
##
@@ -0,0 +1,154 @@
+/
+ * include/g
patacongo commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526064407
##
File path: include/getopt.h
##
@@ -0,0 +1,154 @@
+/
+ * include/g
patacongo commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526065660
##
File path: libs/libc/unistd/lib_getopterrp.c
##
@@ -0,0 +1,57 @@
+/**
xiaoxiang781216 commented on a change in pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#discussion_r526081941
##
File path: arch/sim/include/types.h
##
@@ -75,9 +75,16 @@ typedef unsigned int _uint32_t;
/* Note about host OS types:
* - int
davids5 commented on pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-729673647
> @davids5 do you think my anwser resolve your concern?
No. but let's merge it for what it is.
> Would you provide the 2 debug.h files for example.
I
davids5 merged pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 6d2c28e drivers/wireless/gs2200m.c: Fix scanf format warnings
add 55deefd Add debug.h selection choi
xiaoxiang781216 commented on pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-729679114
@yamt after reviewing the final patchset, I found that the common typedef
for intmax_t/uintmax_t should work fine after we correct
_int64_t/_uint64_t/_int32_t/_u
xiaoxiang781216 edited a comment on pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-729679114
@yamt after reviewing the final patchset, I found that the common typedef
for intmax_t/uintmax_t:
```
#ifdef __INT64_DEFINED
typedef _int64_t
xiaoxiang781216 edited a comment on pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-729679114
@yamt after reviewing the final patchset, I found that the common typedef
for intmax_t/uintmax_t in include/stdint.h:
```
#ifdef __INT64_DEFINED
t
xiaoxiang781216 commented on pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-729683886
> > @davids5 do you think my anwser resolve your concern?
>
> No. but let's merge it for what it is.
>
> > Would you provide the 2 debug.h files for
xiaoxiang781216 edited a comment on pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-729683886
> > @davids5 do you think my anwser resolve your concern?
>
> No. but let's merge it for what it is.
>
> > Would you provide the 2 debug.h fil
xiaoxiang781216 commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526103172
##
File path: include/getopt.h
##
@@ -0,0 +1,154 @@
+/
+ * inc
xiaoxiang781216 commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526103688
##
File path: include/getopt.h
##
@@ -0,0 +1,154 @@
+/
+ * inc
xiaoxiang781216 commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526105526
##
File path: libs/libc/unistd/lib_getopterrp.c
##
@@ -0,0 +1,57 @@
+/
xiaoxiang781216 commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526103172
##
File path: include/getopt.h
##
@@ -0,0 +1,154 @@
+/
+ * inc
v01d commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526108626
##
File path: drivers/sensors/sensor.c
##
@@ -801,9 +654,9 @@ int sensor_register(FAR struct sensor_lowerhalf_s *lower,
int devno)
/* Initializ
v01d commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526111350
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/circ_
v01d commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526112082
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,474 @@
+/
+ * mm/circ_
v01d commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526112321
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,474 @@
+/
+ * mm/circ_
patacongo commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526122605
##
File path: include/getopt.h
##
@@ -0,0 +1,154 @@
+/
+ * include/g
v01d opened a new pull request #2334:
URL: https://github.com/apache/incubator-nuttx/pull/2334
## Summary
Mention the preferred commit message as ": "
## Impact
Contributing document
## Testing
N/A
-
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526124239
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,474 @@
+/
+ * mm/cir
xiaoxiang781216 commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526128114
##
File path: include/getopt.h
##
@@ -0,0 +1,154 @@
+/
+ * inc
v01d commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526129189
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,474 @@
+/
+ * mm/circ_
xiaoxiang781216 commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526128114
##
File path: include/getopt.h
##
@@ -0,0 +1,154 @@
+/
+ * inc
patacongo commented on a change in pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r526139794
##
File path: include/getopt.h
##
@@ -0,0 +1,154 @@
+/
+ * include/g
acassis merged pull request #2333:
URL: https://github.com/apache/incubator-nuttx/pull/2333
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
acassis commented on pull request #2332:
URL: https://github.com/apache/incubator-nuttx/pull/2332#issuecomment-729737936
Hi @retogaeh why #ifdef CONFIG_NET_TCP_KEEPALIVE is not used anymore? Is it
modification able to handle the case where ACK is not received? I noticed
conn->tx_unacked is
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 55deefd Add debug.h selection choice to support include chip debug.h
add b3c2873 freedom-k64f/demo:
retogaeh commented on pull request #2332:
URL: https://github.com/apache/incubator-nuttx/pull/2332#issuecomment-729753010
> Hi @retogaeh why #ifdef CONFIG_NET_TCP_KEEPALIVE is not used anymore? Is
it modification able to handle the case where ACK is not received? I noticed
conn->tx_unacked
acassis commented on pull request #2269:
URL: https://github.com/apache/incubator-nuttx/pull/2269#issuecomment-729765008
CI is failing:
Run actions/upload-artifact@v2
With the provided path, there will be 121 file(s) uploaded
An error has been caught http-client index 0, retryin
xiaoxiang781216 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526233482
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+
xiaoxiang781216 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526233482
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+
xiaoxiang781216 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526242485
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,474 @@
+/
+
v01d opened a new pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335
## Summary
This is a WIP to paralellize generation of Make.dep files. It does so by
generating temporary per-file dep file as a separate make target (which allows
parallelization) which ar
xiaoxiang781216 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526233482
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+
v01d commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526245248
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,474 @@
+/
+ * mm/circ_
v01d commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r526246847
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/circ_
xiaoxiang781216 commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526302883
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
xiaoxiang781216 commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526302883
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
xiaoxiang781216 commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526302883
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
v01d commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526305597
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
+
+%.dd:
davids5 commented on a change in pull request #2334:
URL: https://github.com/apache/incubator-nuttx/pull/2334#discussion_r526307364
##
File path: CONTRIBUTING.md
##
@@ -14,6 +14,11 @@ it is very important you follow these guidelines:
+
+* The f
v01d commented on a change in pull request #2334:
URL: https://github.com/apache/incubator-nuttx/pull/2334#discussion_r526309282
##
File path: CONTRIBUTING.md
##
@@ -14,6 +14,11 @@ it is very important you follow these guidelines:
+
+* The firs
davids5 merged pull request #2334:
URL: https://github.com/apache/incubator-nuttx/pull/2334
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 5394c8a freedom-k64f/demo: Enable netcat app
add 06fa2a4 CONTRIBUTING.md: talk about preferred commi
xiaoxiang781216 commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526316225
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
xiaoxiang781216 commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526316225
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
xiaoxiang781216 commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526316225
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
xiaoxiang781216 commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526316225
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
v01d commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526320269
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
+
+%.dd:
xiaoxiang781216 commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526331509
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
v01d commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526332302
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
+
+%.dd:
xiaoxiang781216 commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526331509
##
File path: boards/Makefile
##
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 0c8870f CONTRIBUTING.md: add example
add cbd4e90 net/tcp: Rectified keepalive fix
No new revisions
acassis commented on pull request #2332:
URL: https://github.com/apache/incubator-nuttx/pull/2332#issuecomment-729940826
Thank you @retogaeh !
This is an automated message from the Apache Git Service.
To respond to the messag
acassis merged pull request #2332:
URL: https://github.com/apache/incubator-nuttx/pull/2332
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
Ouss4 merged pull request #2269:
URL: https://github.com/apache/incubator-nuttx/pull/2269
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from cbd4e90 net/tcp: Rectified keepalive fix
add f09d103 xtensa/esp32: Add high memory support to wo
ppisa opened a new pull request #2336:
URL: https://github.com/apache/incubator-nuttx/pull/2336
It seems that part of the patch
stm32l4: correct build of stm32l4_can.c to respect L4 variant
has been lost on its way to mainline.
Signed-off-by: Pavel Pisa
--
yamt commented on a change in pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#discussion_r526458158
##
File path: arch/sim/include/inttypes.h
##
@@ -44,7 +44,7 @@
* Pre-processor Definitions
**
yamt commented on pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-729994654
> @yamt after reviewing the final patchset, I found that the common typedef
for intmax_t/uintmax_t in include/stdint.h:
>
> ```
> #ifdef __INT64_DEFINED
> typed
masayuki2009 merged pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
1 - 100 of 143 matches
Mail list logo
