yamt commented on pull request #2222: URL: https://github.com/apache/incubator-nuttx/pull/2222#issuecomment-729994654
> @yamt after reviewing the final patchset, I found that the common typedef for intmax_t/uintmax_t in include/stdint.h: > > ``` > #ifdef __INT64_DEFINED > typedef _int64_t intmax_t; > typedef _uint64_t uintmax_t; > #else > typedef _int32_t intmax_t; > typedef _uint32_t uintmax_t; > #endif > ``` > > should work fine after we correct _int64_t/_uint64_t/_int32_t/_uint32_t. Why we move intmax_t/uintmax_t to arch/inttype.h? * you suggested it's better to have them in arch types.h for consistency with other types and i agreed. * the common definition doesn't work well for macOS: ``` spacetanuki% cc -dM -E - < /dev/null|grep -E "__INT(32|64|MAX)_TYPE__" #define __INT32_TYPE__ int #define __INT64_TYPE__ long long int #define __INTMAX_TYPE__ long int spacetanuki% ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
