xiaoxiang781216 commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526316225
##########
File path: boards/Makefile
##########
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
+
+%.dd: %.c
+ $(Q) $(MKDEP) $(DEPPATH) "$(CC)" -- $(CFLAGS) -- $< > $@
+
+%.ddxx: %.cxx
+ $(Q) $(MKDEP) $(DEPPATH) "$(CC)" -- $(CXXFLAGS) -- $< > $@
+
+makedepfile: $(patsubst %.c,%.dd,$(SRCS))
+ @for f in $^; do cat $$f; done >> Make.dep
+ $(call DELFILE, $^)
+
+makedepxxfile: $(patsubst %.cxx,%.ddxx,$(CXXSRCS))
+ @for f in $^; do cat $$f; done >> Make.dep
+ $(call DELFILE, $^)
.depend: Makefile $(SRCS) $(TOPDIR)$(DELIM).config
+ $(call DELFILE, Make.dep)
Review comment:
No we don't need, all Makefile can keep as before, in mkdeps:
1. launch gcc in parallel to generate the individual dep file
2. Wait all gcc instance finish, and merge small dep files into the big one
Basically, the change do the same thing in mkdeps.c as you modify in each
Makefile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
