[GitHub] [incubator-nuttx] YuuichiNakamura commented on pull request #1955: Add note filters documentation

YuuichiNakamura commented on pull request #1955: URL: https://github.com/apache/incubator-nuttx/pull/1955#issuecomment-707543267 > The docs look fine, albeit there should also be some explanation inside the first section of _what_ the note driver does. Keep in mind that not everyone (as me

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1977: freedom-k64f: Support raw binary firmware format

xiaoxiang781216 merged pull request #1977: URL: https://github.com/apache/incubator-nuttx/pull/1977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated: freedom-k64f: Support raw binary firmware format

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new fff15f1 freedom-k64f: Support raw b

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503733788 ## File path: system/trace/trace.h ## @@ -0,0 +1,59 @@ +/

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503733998 ## File path: system/trace/trace.c ## @@ -0,0 +1,812 @@ +/

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503734423 ## File path: system/trace/trace.c ## @@ -0,0 +1,812 @@ +/

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503734494 ## File path: system/trace/trace.c ## @@ -0,0 +1,812 @@ +/

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503734715 ## File path: system/trace/trace.c ## @@ -0,0 +1,812 @@ +/

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503734916 ## File path: system/trace/trace.c ## @@ -0,0 +1,812 @@ +/

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503735096 ## File path: system/trace/trace.c ## @@ -0,0 +1,812 @@ +/

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503735462 ## File path: system/trace/trace_dump.c ## @@ -0,0 +1,570 @@ +/***

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503735633 ## File path: system/trace/trace_dump.c ## @@ -0,0 +1,570 @@ +/***

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503735944 ## File path: system/trace/trace.c ## @@ -0,0 +1,812 @@ +/

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503735944 ## File path: system/trace/trace.c ## @@ -0,0 +1,812 @@ +/

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1958: xtensa/esp32: When PSRAM is enabled allow drivers and tasks to allocate memory from a separate internal memory

yamt commented on a change in pull request #1958: URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r503727146 ## File path: arch/xtensa/Kconfig ## @@ -81,6 +81,21 @@ config XTENSA_CP_INITSET is provided by CONFIG_XTENSA_CP_INITSET. Each bit c

[incubator-nuttx-apps] 01/01: Remove all fclose with stdin, stdout and stderr

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch fclose in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 772f68a16bb8f93dfc2ace380bb5c36c12dda3f9 Author: Xiang Xiao AuthorDate: Tue Oct 13 15:53:19 2020 +0800

[incubator-nuttx-apps] branch fclose created (now 772f68a)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch fclose in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. at 772f68a Remove all fclose with stdin, stdout and stderr This branch includes the following new com

[incubator-nuttx] 01/01: Remove all fclose with stdin, stdout and stderr

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch fclose in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 7ecd501a0d1a6ae7316c3c97b272f6faa40091e0 Author: Xiang Xiao AuthorDate: Tue Oct 13 16:08:01 2020 +0800

[incubator-nuttx] branch fclose created (now 7ecd501)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch fclose in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 7ecd501 Remove all fclose with stdin, stdout and stderr This branch includes the following new commits:

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #425: Remove all fclose with stdin, stdout and stderr

xiaoxiang781216 opened a new pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425 ## Summary since it is wrong to close the builtin stream and specially note https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html: Since after the call t

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #425: Remove all fclose with stdin, stdout and stderr

xiaoxiang781216 commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-707576241 @juniskane could you try whether this patch can fix your issue? This is an automated message

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #425: Remove all fclose with stdin, stdout and stderr

jerpelea commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-707576924 LGTM This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1979: Remove all fclose with stdin, stdout and stderr

xiaoxiang781216 opened a new pull request #1979: URL: https://github.com/apache/incubator-nuttx/pull/1979 ## Summary since it is wrong to close the builtin stream and specially note https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html: Since after the call to f

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1958: xtensa/esp32: When PSRAM is enabled allow drivers and tasks to allocate memory from a separate internal memory

Ouss4 commented on a change in pull request #1958: URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r503759404 ## File path: arch/xtensa/src/esp32/esp32_spi.c ## @@ -924,6 +955,21 @@ static void esp32_spi_dma_exchange(FAR struct esp32_spi_priv_s *priv,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1979: Remove all fclose with stdin, stdout and stderr

xiaoxiang781216 commented on pull request #1979: URL: https://github.com/apache/incubator-nuttx/pull/1979#issuecomment-707578194 Here is the similar fix in apps: https://github.com/apache/incubator-nuttx-apps/pull/425 This i

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1958: xtensa/esp32: When PSRAM is enabled allow drivers and tasks to allocate memory from a separate internal memory

Ouss4 commented on a change in pull request #1958: URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r503762198 ## File path: arch/xtensa/Kconfig ## @@ -81,6 +81,21 @@ config XTENSA_CP_INITSET is provided by CONFIG_XTENSA_CP_INITSET. Each bit

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1958: xtensa/esp32: When PSRAM is enabled allow drivers and tasks to allocate memory from a separate internal memory

Ouss4 commented on a change in pull request #1958: URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r503764904 ## File path: arch/xtensa/Kconfig ## @@ -81,6 +81,21 @@ config XTENSA_CP_INITSET is provided by CONFIG_XTENSA_CP_INITSET. Each bit

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503735462 ## File path: system/trace/trace_dump.c ## @@ -0,0 +1,570 @@ +/***

[GitHub] [incubator-nuttx] davids5 commented on pull request #1979: Remove all fclose with stdin, stdout and stderr

davids5 commented on pull request #1979: URL: https://github.com/apache/incubator-nuttx/pull/1979#issuecomment-707653661 @patacongo Are there any negative ramification of these changes that are specific to the NuttX implementations?

[GitHub] [incubator-nuttx] rzr opened a new pull request #1980: freedom-k64f: Add renew DHCP client for netnsh

rzr opened a new pull request #1980: URL: https://github.com/apache/incubator-nuttx/pull/1980 Also enable ifup, use USB console and create raw image. Windows is not mandatory, I use linux as host so defconfig can rely on defaults. Change-Id: Ic0e5f79f28facb6eff1d9831bcb31e1f

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1980: freedom-k64f: Add renew DHCP client for netnsh

jerpelea commented on pull request #1980: URL: https://github.com/apache/incubator-nuttx/pull/1980#issuecomment-707660279 @rzr You have 3 unreleated changes in 1 commit Do you want to split them for clarity or do you want them together? -

[GitHub] [incubator-nuttx] rzr commented on pull request #1980: freedom-k64f: Add renew DHCP client for netnsh

rzr commented on pull request #1980: URL: https://github.com/apache/incubator-nuttx/pull/1980#issuecomment-707670996 I can split them but since they were trivial on a single file i squashed them into a single PR This is an a

[GitHub] [incubator-nuttx] v01d commented on pull request #1955: Add note filters documentation

v01d commented on pull request #1955: URL: https://github.com/apache/incubator-nuttx/pull/1955#issuecomment-707694122 > > The docs look fine, albeit there should also be some explanation inside the first section of _what_ the note driver does. Keep in mind that not everyone (as me) is awar

[GitHub] [incubator-nuttx] v01d commented on issue #1954: IP clearance checks via CI

v01d commented on issue #1954: URL: https://github.com/apache/incubator-nuttx/issues/1954#issuecomment-707708672 hi @yy-gu , great that you and Peter can take on this task. Regarding the workflow, I have a few comments: * the checks you mention are already in place in the script I w

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1959: Documentation for the Timer Driver

v01d commented on a change in pull request #1959: URL: https://github.com/apache/incubator-nuttx/pull/1959#discussion_r503922645 ## File path: Documentation/components/drivers/character/timer.rst ## @@ -16,3 +16,274 @@ locations: reside in ``arch/``\ **\ ``/src/``\ ** d

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1959: Documentation for the Timer Driver

v01d commented on a change in pull request #1959: URL: https://github.com/apache/incubator-nuttx/pull/1959#discussion_r503922436 ## File path: Documentation/components/drivers/character/timer.rst ## @@ -16,3 +16,274 @@ locations: reside in ``arch/``\ **\ ``/src/``\ ** d

[GitHub] [incubator-nuttx] v01d commented on pull request #1959: Documentation for the Timer Driver

v01d commented on pull request #1959: URL: https://github.com/apache/incubator-nuttx/pull/1959#issuecomment-707716387 Changes look good. I added a few comments. Also, I'm not sure if it is good idea to mention internal functions such as `start`/`stop`. Or do are you refering to the lower-h

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1978: xtensa/esp32: Add power management of deep-sleep

Ouss4 commented on a change in pull request #1978: URL: https://github.com/apache/incubator-nuttx/pull/1978#discussion_r503947296 ## File path: arch/xtensa/src/esp32/esp32_pm.c ## @@ -180,8 +215,28 @@ static struct esp32_sleep_config_t s_config = * Private Functions ***

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1958: xtensa/esp32: When PSRAM is enabled allow drivers and tasks to allocate memory from a separate internal memory

patacongo commented on a change in pull request #1958: URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r503965858 ## File path: arch/xtensa/include/arch.h ## @@ -91,6 +91,18 @@ extern "C" #define EXTERN extern #endif +#ifdef CONFIG_XTENSA_USE_SEPERATE_IM

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1958: xtensa/esp32: When PSRAM is enabled allow drivers and tasks to allocate memory from a separate internal memory

patacongo commented on a change in pull request #1958: URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r503966963 ## File path: arch/xtensa/include/arch.h ## @@ -91,6 +91,18 @@ extern "C" #define EXTERN extern #endif +#ifdef CONFIG_XTENSA_USE_SEPERATE_IM

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r503970834 ## File path: system/trace/trace_dump.c ## @@ -0,0 +1,570 @@ +/***

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #1981: tiva: Fix nxstyle warnings

hartmannathan opened a new pull request #1981: URL: https://github.com/apache/incubator-nuttx/pull/1981 ## Summary arch/arm/src/tiva/cc13xx/cc13xx_prcm.c: * Fix nxstyle warnings. No functional changes. ## Impact Removes nxstyle errors. ## Testing

[GitHub] [incubator-nuttx] rzr opened a new pull request #1982: freedom-k64f: Add I2C initial support

rzr opened a new pull request #1982: URL: https://github.com/apache/incubator-nuttx/pull/1982 It was checked using i2c tool and onboard sensor: nsh> i2c bus Bus 0: YES nsh> i2c dev 1 0x7F 10: -- -- -- -- -- -- -- -- -- -- -- -- -- 1d -- -- nsh>

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1958: xtensa/esp32: When PSRAM is enabled allow drivers and tasks to allocate memory from a separate internal memory

Ouss4 commented on a change in pull request #1958: URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r504024420 ## File path: arch/xtensa/include/arch.h ## @@ -91,6 +91,18 @@ extern "C" #define EXTERN extern #endif +#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM +

[incubator-nuttx] branch master updated: tiva: Fix nxstyle warnings

This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9e70e35 tiva: Fix nxstyle warning

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1981: tiva: Fix nxstyle warnings

Ouss4 merged pull request #1981: URL: https://github.com/apache/incubator-nuttx/pull/1981 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx-website] v01d opened a new pull request #35: fix deploy not working on schedule

v01d opened a new pull request #35: URL: https://github.com/apache/incubator-nuttx-website/pull/35 ## Summary the deploy step was not considering the schedule event ## Impact Fixes scheduled deploy ## Testing CI ---

[incubator-nuttx-website] branch asf-site updated: Publishing web: 2f707fab502861230a6449a661a8b77fa8c9d4f8 docs: 9e70e3580f63270bd0035f5b9ebb96927f1e64bc

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 28fa40e Publishing web

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #1983: [BACKPORT-1950]Fix spresense SMP

Ouss4 opened a new pull request #1983: URL: https://github.com/apache/incubator-nuttx/pull/1983 ## Summary This backports #1950 ## Impact N/A ## Testing N/A This is an automated message from the Apache

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #1984: [BACKPORT-1951]sched: task: Fix nxtask_exit() for SMP

Ouss4 opened a new pull request #1984: URL: https://github.com/apache/incubator-nuttx/pull/1984 ## Summary This backports #1951 ## Impact N/A ## Testing N/A This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] patacongo opened a new issue #1985: Commit 567962bd626 broke the Ubuntu on Windows build

patacongo opened a new issue #1985: URL: https://github.com/apache/incubator-nuttx/issues/1985 Eduard Niesner reported this problem: When building for Ubuntu on Windows, the build fails because all of the host tools are build with the .exe extension, in particulare, tools/mkconfig.exe. T

[GitHub] [incubator-nuttx] yy-gu commented on issue #1954: IP clearance checks via CI

yy-gu commented on issue #1954: URL: https://github.com/apache/incubator-nuttx/issues/1954#issuecomment-708092071 @v01d Agree with all your comments. We will give it a first try and report back our progress. This is an aut

[GitHub] [incubator-nuttx] cwespressif commented on a change in pull request #1978: xtensa/esp32: Add power management of deep-sleep

cwespressif commented on a change in pull request #1978: URL: https://github.com/apache/incubator-nuttx/pull/1978#discussion_r504354776 ## File path: arch/xtensa/src/esp32/esp32_pm.c ## @@ -180,8 +215,28 @@ static struct esp32_sleep_config_t s_config = * Private Functions *

[GitHub] [incubator-nuttx] cwespressif commented on a change in pull request #1978: xtensa/esp32: Add power management of deep-sleep

cwespressif commented on a change in pull request #1978: URL: https://github.com/apache/incubator-nuttx/pull/1978#discussion_r504357332 ## File path: arch/xtensa/src/esp32/esp32_pm.c ## @@ -180,8 +215,28 @@ static struct esp32_sleep_config_t s_config = * Private Functions *

[GitHub] [incubator-nuttx] cwespressif commented on a change in pull request #1978: xtensa/esp32: Add power management of deep-sleep

cwespressif commented on a change in pull request #1978: URL: https://github.com/apache/incubator-nuttx/pull/1978#discussion_r504357332 ## File path: arch/xtensa/src/esp32/esp32_pm.c ## @@ -180,8 +215,28 @@ static struct esp32_sleep_config_t s_config = * Private Functions *

[incubator-nuttx] branch wsl created (now 86c6afe)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch wsl in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 86c6afe tools/Config.mk: Don't set HOSTEXEEXT to .exe for Ubuntu on Windows This branch includes the foll

[incubator-nuttx] 01/01: tools/Config.mk: Don't set HOSTEXEEXT to .exe for Ubuntu on Windows

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch wsl in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 86c6afe9a5998e2eba98fa0944e5e29de7027171 Author: Xiang Xiao AuthorDate: Wed Oct 14 11:01:39 2020 +0800 too

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1986: tools/Config.mk: Don't set HOSTEXEEXT to .exe for Ubuntu on Windows

xiaoxiang781216 opened a new pull request #1986: URL: https://github.com/apache/incubator-nuttx/pull/1986 ## Summary Fix issue report here: https://github.com/apache/incubator-nuttx/issues/1985 ## Impact WSL user ## Testing The follow command should work without error:

[GitHub] [incubator-nuttx] RB-tel opened a new pull request #1987: [BACKPORT-1940]cygwin build - path issue fix for Renesas Arch

RB-tel opened a new pull request #1987: URL: https://github.com/apache/incubator-nuttx/pull/1987 ## Summary BACKPORT to Release 10.0 ## Impact NA ## Testing NA This is an automated message from the Apache G

[GitHub] [incubator-nuttx] jerpelea merged pull request #1980: freedom-k64f: Add renew DHCP client for netnsh

jerpelea merged pull request #1980: URL: https://github.com/apache/incubator-nuttx/pull/1980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-nuttx] branch master updated (9e70e35 -> 8f9cd88)

This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 9e70e35 tiva: Fix nxstyle warnings add 8f9cd88 freedom-k64f: Add renew DHCP client for netnsh No n