v01d commented on pull request #1959:
URL: https://github.com/apache/incubator-nuttx/pull/1959#issuecomment-707716387


   Changes look good. I added a few comments. Also, I'm not sure if it is good 
idea to mention internal functions such as `start`/`stop`. Or do are you 
refering to the lower-half interface operations? If so, maybe you can mention 
that explicitly and show the ops struct here


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to