[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1958: xtensa/esp32: When PSRAM is enabled allow drivers and tasks to allocate memory from a separate internal memory

[GitBox]

Ouss4 commented on a change in pull request #1958:
URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r503759404



##########
File path: arch/xtensa/src/esp32/esp32_spi.c
##########
@@ -924,6 +955,21 @@ static void esp32_spi_dma_exchange(FAR struct 
esp32_spi_priv_s *priv,
       tp += n;
       rp += n;
     }
+
+#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM
+  if (esp32_ptr_extram(rxbuffer))
+    {
+      memcpy(rxbuffer, rp, bytes);
+      up_imm_free(rp);

Review comment:
       Indeed.  Thanks, done.

##########
File path: arch/xtensa/src/esp32/esp32_spi.c
##########
@@ -924,6 +955,21 @@ static void esp32_spi_dma_exchange(FAR struct 
esp32_spi_priv_s *priv,
       tp += n;
       rp += n;
     }
+
+#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM
+  if (esp32_ptr_extram(rxbuffer))
+    {
+      memcpy(rxbuffer, rp, bytes);
+      up_imm_free(rp);
+    }
+#endif
+
+#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM
+  if (esp32_ptr_extram(txbuffer))
+    {
+      up_imm_free(tp);

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org