Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-20 Thread via GitHub
xiaoxiang781216 closed pull request #14755: semaphore: Fix a few regressions URL: https://github.com/apache/nuttx/pull/14755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-14 Thread via GitHub
yamt commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1843218561 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUGASSERT(atom

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-14 Thread via GitHub
yamt commented on PR #14755: URL: https://github.com/apache/nuttx/pull/14755#issuecomment-2478016341 i marked this draft because i'm now inclined to think it's simpler to make a revert. https://github.com/apache/nuttx/pull/14804 -- This is an automated message from the Apache Git Service.

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1843173658 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUG

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1843173658 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUG

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1843173658 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUG

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-14 Thread via GitHub
yamt commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1841832439 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUGASSERT(atom

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-14 Thread via GitHub
yamt commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1841828096 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUGASSERT(atom

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
crafcat7 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1841618746 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUGASSERT(

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
crafcat7 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1841618746 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUGASSERT(

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
crafcat7 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1841618746 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUGASSERT(

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1841581599 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUG

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
zyfeier commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1841567383 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUGASSERT(a

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1841511874 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUG

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
yamt commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1839753989 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUGASSERT(atom

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
yamt commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1839761542 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUGASSERT(atom

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1840090144 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUG

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1839660022 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUG

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1839755704 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUG

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
yamt commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1839770620 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUGASSERT(atom

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1839755704 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUG

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-13 Thread via GitHub
yamt commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1839739619 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUGASSERT(atom

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-12 Thread via GitHub
xiaoxiang781216 commented on code in PR #14755: URL: https://github.com/apache/nuttx/pull/14755#discussion_r1839660022 ## sched/semaphore/sem_holder.c: ## @@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUG

Re: [PR] semaphore: Fix a few regressions [nuttx]

2024-11-12 Thread via GitHub
nuttxpr commented on PR #14755: URL: https://github.com/apache/nuttx/pull/14755#issuecomment-2472474716 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.