xiaoxiang781216 commented on code in PR #14755:
URL: https://github.com/apache/nuttx/pull/14755#discussion_r1843173658


##########
sched/semaphore/sem_holder.c:
##########
@@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem)
 {
   /* Check our assumptions */
 
-  DEBUGASSERT(atomic_load(NXSEM_COUNT(sem)) <= 0);
+  DEBUGASSERT((int16_t)atomic_load(NXSEM_COUNT(sem)) <= 0);

Review Comment:
   Ok, let's limit the kernel to use only one type of atomic type, so we can 
provide a compatible implementation when the compiler doesn't provide the 
atomic operation. @zyfeier @crafcat7



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to