nuttxpr commented on PR #14755: URL: https://github.com/apache/nuttx/pull/14755#issuecomment-2472474716
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the *why* and *how*, it lacks detail in several crucial sections: * **Summary:** Missing "What functional part of the code is being changed?". Be specific (e.g., semaphore implementation, specific files modified). * **Impact:** Completely empty. This is a critical section. Address *all* the points, even if the answer is "NO". Justify each "NO". For example: "Impact on user: NO (Existing applications using semaphores should not require modification)." * **Testing:** Insufficient. While a target is mentioned, there are no "before" and "after" logs. These logs are crucial for demonstrating the fix and justifying the change. "A few unrelated local changes" are also concerning; the PR should ideally be tested in isolation. The build host details are also missing. Specifically, the author needs to: 1. **Clarify the scope of changes:** List the affected files/functions. 2. **Complete the Impact section:** Address every point, justifying each answer. 3. **Provide valid testing logs:** Include "before" and "after" logs demonstrating the issue and the fix. Remove any unrelated local changes before generating these logs. Specify the build host details. Without these changes, the PR is incomplete and difficult to review properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
