xiaoxiang781216 merged PR #16231:
URL: https://github.com/apache/nuttx/pull/16231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
xiaoxiang781216 commented on PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#issuecomment-2854034824
@Fix-Point please fix:
```
/home/runner/work/nuttx/nuttx/nuttx/sched/wdog/wd_start.c:297: Absoulute ==>
Absolute
``
--
This is an automated message from the Apache Git
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074918858
##
libs/libc/wqueue/work_cancel.c:
##
@@ -89,7 +89,7 @@ static int work_qcancel(FAR struct usr_wqueue_s *wqueue,
*/
curr = wqueue->q.head;
- whi
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074762646
##
libs/libc/wqueue/work_queue.c:
##
@@ -87,17 +87,17 @@ static int work_qqueue(FAR struct usr_wqueue_s *wqueue,
/* Initialize the work structure */
- w
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074681300
##
libs/libc/wqueue/work_cancel.c:
##
@@ -89,7 +89,7 @@ static int work_qcancel(FAR struct usr_wqueue_s *wqueue,
*/
curr = wqueue->q.head;
-
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074680567
##
sched/wqueue/kwork_thread.c:
##
@@ -110,6 +116,53 @@ struct lp_wqueue_s g_lpwork =
* Private Functions
**
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074680361
##
sched/wqueue/wqueue.h:
##
@@ -159,6 +148,65 @@ static inline_function FAR struct kwork_wqueue_s
*work_qid2wq(int qid)
}
}
+/
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074674647
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,17 +59,37 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqsave(&w
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074673094
##
sched/wqueue/kwork_thread.c:
##
@@ -148,33 +193,54 @@ static int work_thread(int argc, FAR char *argv[])
kworker = (FAR struct kworker_s *)
((uintp
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074669532
##
sched/wqueue/wqueue.h:
##
@@ -159,6 +148,65 @@ static inline_function FAR struct kwork_wqueue_s
*work_qid2wq(int qid)
}
}
+/**
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074663527
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,17 +59,37 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqs
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074646362
##
sched/wqueue/kwork_thread.c:
##
@@ -148,33 +193,54 @@ static int work_thread(int argc, FAR char *argv[])
kworker = (FAR struct kworker_s *)
((uintp
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074646468
##
sched/wqueue/kwork_queue.c:
##
@@ -141,65 +80,72 @@ int work_queue_period_wq(FAR struct kwork_wqueue_s *wqueue,
FAR void *arg, clock_t de
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074631788
##
sched/wqueue/kwork_thread.c:
##
@@ -148,33 +193,54 @@ static int work_thread(int argc, FAR char *argv[])
kworker = (FAR struct kworker_s *)
((uintp
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074631337
##
sched/wqueue/wqueue.h:
##
@@ -159,6 +148,65 @@ static inline_function FAR struct kwork_wqueue_s
*work_qid2wq(int qid)
}
}
+/**
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074628950
##
include/nuttx/wqueue.h:
##
@@ -249,19 +249,11 @@ typedef CODE void (*worker_t)(FAR void *arg);
struct work_s
{
- union
- {
-struct
-{
- struct l
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074630963
##
sched/wqueue/kwork_queue.c:
##
@@ -141,65 +80,72 @@ int work_queue_period_wq(FAR struct kwork_wqueue_s *wqueue,
FAR void *arg, clock_t de
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074628825
##
sched/wqueue/kwork_cancel.c:
##
@@ -31,7 +31,7 @@
#include
#include
-#include
+#include
Review Comment:
Done.
##
sched/wqueue/wqueue.h:
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2072976590
##
sched/wqueue/wqueue.h:
##
@@ -66,14 +66,15 @@ struct kworker_s
struct kwork_wqueue_s
{
- struct list_node q; /* The queue of pending work */
-
fdcavalcanti commented on PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#issuecomment-2845214664
I've found no issues on Espressif's CI test results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
fdcavalcanti commented on PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#issuecomment-2841971496
Most tests look ok, however `sotest` defconfig is failing to build across
many SoCs due to some LIBC errors, which I suspect is due to the apps directory
not in sync. Some other apps
fdcavalcanti commented on PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#issuecomment-2841709726
I'll run this through Espressif's CI and see if anything comes up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2065351185
##
sched/wqueue/kwork_queue.c:
##
@@ -141,65 +80,50 @@ int work_queue_period_wq(FAR struct kwork_wqueue_s *wqueue,
FAR void *arg, clock_t de
GUIDINGLI commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2063219741
##
sched/wqueue/kwork_queue.c:
##
@@ -141,65 +80,50 @@ int work_queue_period_wq(FAR struct kwork_wqueue_s *wqueue,
FAR void *arg, clock_t de
GUIDINGLI commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2062565038
##
sched/wqueue/wqueue.h:
##
@@ -66,14 +66,15 @@ struct kworker_s
struct kwork_wqueue_s
{
- struct dq_queue_s q; /* The queue of pending work */
- sem_t
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2057799243
##
sched/wqueue/kwork_thread.c:
##
@@ -216,17 +278,54 @@ static int work_thread(int argc, FAR char *argv[])
* posted.
*/
- wqueue->wait_count++
GUIDINGLI commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2055620048
##
sched/wqueue/kwork_thread.c:
##
@@ -216,17 +278,54 @@ static int work_thread(int argc, FAR char *argv[])
* posted.
*/
- wqueue->wait_count++
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051878926
##
sched/wqueue/kwork_thread.c:
##
@@ -216,18 +288,49 @@ static int work_thread(int argc, FAR char *argv[])
* posted.
*/
+ /* Check the waiting
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051878460
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,40 +61,36 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqsave(&w
anchao commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051672835
##
sched/wqueue/kwork_thread.c:
##
@@ -216,18 +288,49 @@ static int work_thread(int argc, FAR char *argv[])
* posted.
*/
+ /* Check the waiting qu
anchao commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051672996
##
sched/wqueue/kwork_thread.c:
##
@@ -216,18 +288,49 @@ static int work_thread(int argc, FAR char *argv[])
* posted.
*/
+ /* Check the waiting qu
anchao commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051672835
##
sched/wqueue/kwork_thread.c:
##
@@ -216,18 +288,49 @@ static int work_thread(int argc, FAR char *argv[])
* posted.
*/
+ /* Check the waiting qu
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051427658
##
sched/wqueue/kwork_thread.c:
##
@@ -148,30 +196,35 @@ static int work_thread(int argc, FAR char *argv[])
kworker = (FAR struct kworker_s *)
(
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051350753
##
sched/wqueue/kwork_thread.c:
##
@@ -148,30 +196,35 @@ static int work_thread(int argc, FAR char *argv[])
kworker = (FAR struct kworker_s *)
((uintp
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051350399
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,37 +61,36 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqsave(&w
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051342956
##
sched/wqueue/kwork_thread.c:
##
@@ -136,10 +182,12 @@ static int work_thread(int argc, FAR char *argv[])
{
FAR struct kwork_wqueue_s *wqueue;
FAR struct kwo
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051342772
##
sched/wqueue/kwork_thread.c:
##
@@ -148,30 +196,35 @@ static int work_thread(int argc, FAR char *argv[])
kworker = (FAR struct kworker_s *)
((uintp
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051342390
##
sched/wqueue/wqueue.h:
##
@@ -66,14 +66,15 @@ struct kworker_s
struct kwork_wqueue_s
{
- struct list_node q; /* The queue of pending work */
- sem_t
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049951035
##
sched/wqueue/kwork_thread.c:
##
@@ -110,6 +118,44 @@ struct lp_wqueue_s g_lpwork =
* Private Functions
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049963827
##
sched/wqueue/kwork_thread.c:
##
@@ -83,11 +83,15 @@
struct hp_wqueue_s g_hpwork =
{
- LIST_INITIAL_VALUE(g_hpwork.q),
- SEM_INITIALIZER(0),
- SEM_INITIALIZE
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050582467
##
sched/wqueue/wqueue.h:
##
@@ -66,14 +66,15 @@ struct kworker_s
struct kwork_wqueue_s
{
- struct list_node q; /* The queue of pending work */
-
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050366248
##
sched/wqueue/wqueue.h:
##
@@ -104,13 +100,7 @@ struct hp_wqueue_s
#ifdef CONFIG_SCHED_LPWORK
struct lp_wqueue_s
{
- struct list_node q; /* The queue o
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050365050
##
include/nuttx/wqueue.h:
##
@@ -249,19 +249,11 @@ typedef CODE void (*worker_t)(FAR void *arg);
struct work_s
{
- union
- {
-struct
-{
- struct l
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050363865
##
sched/wqueue/wqueue.h:
##
@@ -159,6 +148,32 @@ static inline_function FAR struct kwork_wqueue_s
*work_qid2wq(int qid)
}
}
+static inline_function
+void wo
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050363865
##
sched/wqueue/wqueue.h:
##
@@ -159,6 +148,32 @@ static inline_function FAR struct kwork_wqueue_s
*work_qid2wq(int qid)
}
}
+static inline_function
+void wo
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050352585
##
sched/wqueue/wqueue.h:
##
@@ -159,6 +148,32 @@ static inline_function FAR struct kwork_wqueue_s
*work_qid2wq(int qid)
}
}
+static inline_function
+v
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050351112
##
sched/wqueue/kwork_queue.c:
##
@@ -155,49 +94,48 @@ int work_queue_period_wq(FAR struct kwork_wqueue_s *wqueue,
flags = spin_lock_irqsave(&wqueue->lock);
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050349735
##
include/nuttx/wqueue.h:
##
@@ -249,19 +249,11 @@ typedef CODE void (*worker_t)(FAR void *arg);
struct work_s
{
- union
- {
-struct
-{
- st
anchao commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049923533
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,38 +59,20 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqsave(&wque
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050107421
##
sched/wqueue/kwork_thread.c:
##
@@ -110,6 +118,44 @@ struct lp_wqueue_s g_lpwork =
* Private Functions
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050007793
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,38 +59,20 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqs
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050007021
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,38 +59,20 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqs
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050007021
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,38 +59,20 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqs
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049938581
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,38 +59,20 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqsave(&w
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049939836
##
sched/wqueue/kwork_thread.c:
##
@@ -160,14 +208,19 @@ static int work_thread(int argc, FAR char *argv[])
* so ourselves, and (2) there will be no changes t
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049947713
##
include/nuttx/wqueue.h:
##
@@ -249,19 +249,11 @@ typedef CODE void (*worker_t)(FAR void *arg);
struct work_s
{
- union
- {
-struct
-{
- struct l
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049958705
##
sched/wqueue/kwork_thread.c:
##
@@ -83,11 +83,15 @@
struct hp_wqueue_s g_hpwork =
{
- LIST_INITIAL_VALUE(g_hpwork.q),
- SEM_INITIALIZER(0),
- SEM_INITIALIZE
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049951335
##
sched/wqueue/kwork_thread.c:
##
@@ -110,6 +118,44 @@ struct lp_wqueue_s g_lpwork =
* Private Functions
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049949011
##
sched/wqueue/kwork_queue.c:
##
@@ -155,49 +94,48 @@ int work_queue_period_wq(FAR struct kwork_wqueue_s *wqueue,
flags = spin_lock_irqsave(&wqueue->lock);
sch
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049948161
##
include/nuttx/wqueue.h:
##
@@ -249,19 +249,11 @@ typedef CODE void (*worker_t)(FAR void *arg);
struct work_s
{
- union
- {
-struct
-{
- struct l
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049939697
##
sched/wqueue/kwork_thread.c:
##
@@ -211,6 +288,17 @@ static int work_thread(int argc, FAR char *argv[])
}
}
+ if (!list_is_empty(&wque
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049939572
##
sched/wqueue/kwork_thread.c:
##
@@ -110,6 +118,44 @@ struct lp_wqueue_s g_lpwork =
* Private Functions
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049938678
##
sched/wqueue/kwork_queue.c:
##
@@ -155,51 +94,48 @@ int work_queue_period_wq(FAR struct kwork_wqueue_s *wqueue,
flags = spin_lock_irqsave(&wqueue->lock);
sch
anchao commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049926527
##
sched/wqueue/kwork_thread.c:
##
@@ -160,14 +208,19 @@ static int work_thread(int argc, FAR char *argv[])
* so ourselves, and (2) there will be no changes to t
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049854411
##
include/nuttx/wqueue.h:
##
@@ -249,19 +249,11 @@ typedef CODE void (*worker_t)(FAR void *arg);
struct work_s
{
- union
- {
-struct
-{
- st
anchao commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049169728
##
sched/wqueue/kwork_thread.c:
##
@@ -211,6 +288,17 @@ static int work_thread(int argc, FAR char *argv[])
}
}
+ if (!list_is_empty(&wqueue-
anchao commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049150464
##
sched/wqueue/kwork_thread.c:
##
@@ -110,6 +118,44 @@ struct lp_wqueue_s g_lpwork =
* Private Functions
***
acassis commented on PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#issuecomment-2813291589
@Fix-Point @xiaoxiang781216 I think it should be tested on real hardware as
well. Normally small changes on core features like this could break the system.
I think it requires test on sen
nuttxpr commented on PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#issuecomment-2812005286
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
The PR summary is good, clearly explaining the "why" an
69 matches
Mail list logo
