Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2051342390
##########
sched/wqueue/wqueue.h:
##########
@@ -66,14 +66,15 @@ struct kworker_s
struct kwork_wqueue_s
{
- struct list_node q; /* The queue of pending work */
- sem_t sem; /* The counting semaphore of the wqueue */
- sem_t exsem; /* Sync waiting for thread exit */
- spinlock_t lock; /* Spinlock */
- uint8_t nthreads; /* Number of worker threads */
- bool exit; /* A flag to request the thread to exit */
- int16_t wait_count;
- struct kworker_s worker[0]; /* Describes a worker thread */
+ struct list_node wait_q; /* The queue of pending periodical work. */
Review Comment:
Done.
##########
sched/wqueue/kwork_thread.c:
##########
@@ -394,6 +493,8 @@ int work_queue_free(FAR struct kwork_wqueue_s *wqueue)
/* Mark the work queue as exiting */
+ wd_cancel(&wqueue->timer);
+
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
