Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-21 Thread via GitHub
yf13 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2123750612 Removed temporary fixes from this patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-21 Thread via GitHub
xiaoxiang781216 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2123719802 > @xiaoxiang781216 now the remaining issues are in [this log](https://github.com/apache/nuttx/actions/runs/9173629303/job/25222879619): > > ``` > Configuration/Tool: rv-v

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-21 Thread via GitHub
xiaoxiang781216 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2123712990 > @xiaoxiang781216 now the remaining issues are in [this log](https://github.com/apache/nuttx/actions/runs/9173629303/job/25222879619): > > ``` > Configuration/Tool: rv-v

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-21 Thread via GitHub
yf13 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2123613920 @xiaoxiang781216 now the remaining issues are in [this log](https://github.com/apache/nuttx/actions/runs/9173629303/job/25222879619): ``` Configuration/Tool: rv-virt/citest64 us

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-21 Thread via GitHub
yf13 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2123610619 @xiaoxiang781216 now the remaining issue is in [this log](https://github.com/apache/nuttx/actions/runs/9173629303/job/25222879619): ``` Configuration/Tool: rv-virt/citest64 ...

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-20 Thread via GitHub
yf13 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2121894110 @xiangxiang781216 not sure if CI checks are back to normal? I saw issues with some LTP tests thus checked them with local build: ``` nsh> time ltp_behavior_WIFEXITED_1_1 Test PAS

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-19 Thread via GitHub
xiaoxiang781216 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2119558379 > @xiaoxiang781216 thanks, I did that way before but stopped to reduce number of changing lines. now let's go back to avoid warnings. > > Is the CI system still broken? This

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-19 Thread via GitHub
yf13 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2119458920 @xiaoxiang781216 thanks, I did that way before but stopped to reduce number of changing lines. now let's go back to avoid warnings. Is the CI system still broken? This [Linux(sim-02)

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-19 Thread via GitHub
yf13 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2119457132 @xiaoxiang781216 thanks, I did that way before but stopped to reduce number of changing lines. now let's go back that way. Is the CI system still broken? This [log](https://github.com

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-18 Thread via GitHub
xiaoxiang781216 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2119085814 > @xiaoxiang781216 I removed `volatile uintptr_t` usage in `nx_start.c` and the `out-bounds` warnings come back for `sim/sotest` as per the [CI log from Linux(sim-02)](https://git

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
yf13 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2118635243 @xiaoxiang781216 I removed uintptr_t usage in nx_start() and the `sim/sotest` warning appeared. Please look at the CI issue and let me know if there is better ways or I shall add it back.

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1605670042 ## sched/task/task_setup.c: ## @@ -630,8 +632,11 @@ static int nxtask_setup_stackargs(FAR struct task_tcb_s *tcb, stackargv[argc + 1] = NULL; - tcb->cm

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
yf13 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1605633265 ## sched/task/task_setup.c: ## @@ -630,8 +632,11 @@ static int nxtask_setup_stackargs(FAR struct task_tcb_s *tcb, stackargv[argc + 1] = NULL; - tcb->cmn.group->tg

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
yf13 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1605633265 ## sched/task/task_setup.c: ## @@ -630,8 +632,11 @@ static int nxtask_setup_stackargs(FAR struct task_tcb_s *tcb, stackargv[argc + 1] = NULL; - tcb->cmn.group->tg

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
yf13 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1605633265 ## sched/task/task_setup.c: ## @@ -630,8 +632,11 @@ static int nxtask_setup_stackargs(FAR struct task_tcb_s *tcb, stackargv[argc + 1] = NULL; - tcb->cmn.group->tg

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
yf13 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1605633265 ## sched/task/task_setup.c: ## @@ -630,8 +632,11 @@ static int nxtask_setup_stackargs(FAR struct task_tcb_s *tcb, stackargv[argc + 1] = NULL; - tcb->cmn.group->tg

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
yf13 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1605633265 ## sched/task/task_setup.c: ## @@ -630,8 +632,11 @@ static int nxtask_setup_stackargs(FAR struct task_tcb_s *tcb, stackargv[argc + 1] = NULL; - tcb->cmn.group->tg

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
yf13 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1605633792 ## sched/init/nx_start.c: ## @@ -460,14 +462,16 @@ static void idle_task_initialize(void) static void idle_group_initialize(void) { FAR struct task_tcb_s *tcb; + vol

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
yf13 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1605633792 ## sched/init/nx_start.c: ## @@ -460,14 +462,16 @@ static void idle_task_initialize(void) static void idle_group_initialize(void) { FAR struct task_tcb_s *tcb; + vol

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
yf13 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1605633792 ## sched/init/nx_start.c: ## @@ -460,14 +462,16 @@ static void idle_task_initialize(void) static void idle_group_initialize(void) { FAR struct task_tcb_s *tcb; + vol

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
yf13 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1605633265 ## sched/task/task_setup.c: ## @@ -630,8 +632,11 @@ static int nxtask_setup_stackargs(FAR struct task_tcb_s *tcb, stackargv[argc + 1] = NULL; - tcb->cmn.group->tg

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1604820884 ## sched/init/nx_start.c: ## @@ -460,14 +462,16 @@ static void idle_task_initialize(void) static void idle_group_initialize(void) { FAR struct task_tcb_s *

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-16 Thread via GitHub
xiaoxiang781216 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2116479814 yes, @ttnie is looking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] sched/tcb: share group for kthreads [nuttx]

2024-05-16 Thread via GitHub
yf13 commented on PR #12320: URL: https://github.com/apache/nuttx/pull/12320#issuecomment-2116464120 Seems CI system is having similar issue like [here](https://github.com/apache/nuttx/pull/12361#issuecomment-2116099462) -- This is an automated message from the Apache Git Service. To resp