yf13 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1605633265
########## sched/task/task_setup.c: ########## @@ -630,8 +632,11 @@ static int nxtask_setup_stackargs(FAR struct task_tcb_s *tcb, stackargv[argc + 1] = NULL; - tcb->cmn.group->tg_info->ta_argc = argc; - tcb->cmn.group->tg_info->ta_argv = stackargv; + if (ttype != TCB_FLAG_TTYPE_KERNEL) + { + tcb->cmn.group->tg_info->ta_argc = argc; Review Comment: Seems group arguments are still needed to support use cases like `cat /proc/n/cmdline`, maybe we can review that later this purpose of this patch is to share group among kthreads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org