xiaoxiang781216 commented on code in PR #12320:
URL: https://github.com/apache/nuttx/pull/12320#discussion_r1604820884
##########
sched/init/nx_start.c:
##########
@@ -460,14 +462,16 @@ static void idle_task_initialize(void)
static void idle_group_initialize(void)
{
FAR struct task_tcb_s *tcb;
+ volatile uintptr_t p;
Review Comment:
remove, let's cast directly.
##########
sched/init/nx_start.c:
##########
@@ -352,11 +352,14 @@ static void idle_task_initialize(void)
{
FAR struct task_tcb_s *tcb;
FAR dq_queue_t *tasklist;
+ volatile uintptr_t p;
Review Comment:
remove
##########
sched/task/task_setup.c:
##########
@@ -630,8 +632,11 @@ static int nxtask_setup_stackargs(FAR struct task_tcb_s
*tcb,
stackargv[argc + 1] = NULL;
- tcb->cmn.group->tg_info->ta_argc = argc;
- tcb->cmn.group->tg_info->ta_argv = stackargv;
+ if (ttype != TCB_FLAG_TTYPE_KERNEL)
+ {
+ tcb->cmn.group->tg_info->ta_argc = argc;
Review Comment:
why not remvoe ta_argc and ta_argv fields? and always get argv from
nxsched_get_stackargs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
