anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2694688690
> * Do we want to tag this change with `[BREAKING]` tag in the PR titile and
git commits?
Done.
> * It will impact build of nuttx/nuttx-apps and whoever used modlib.
Th
cederom commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2694345647
* Do we want to tag this change with `[BREAKING]` tag in the PR titile and
git commits?
* It will impact build of nuttx/nuttx-apps and whoever used modlib.
* Maybe a candidate for f
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2692966037
> @anchao please verify the compilation issue
Thanks @acassis , this PR depends on apps repo
https://github.com/apache/nuttx-apps/pull/2985, so it may not be possible to
pass CI sep
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2692965250
> * Okay, there seems to be a common agreement to approve this change, so I
will remove my blocking vote :-)
Thank you. :)
> * Do we want to think of compatibility with existi
cederom commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2691459144
* Okay, there seems to be a common agreement to approve this change, so I
will remove my blocking vote :-)
* Do we want to think of compatibility with existing libelf implementations
h
acassis commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2691012489
@anchao please verify the compilation issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jerpelea commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2687243519
@anchao please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2686611524
I'm not saying that the structure of Linux must be correct. However, I think
that @gregory-nutt and Linus had similar ideas in the initial design. Compared
with the kernels implements of
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2686602047
> I know about the implementation duplication before, libelf and modlib were
about the same. However, will we have a need to "re-introduce" modlib, if it
gets capability to load modules ot
pussuw commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2685782557
I know about the implementation duplication before, libelf and modlib were
about the same. However, will we have a need to "re-introduce" modlib, if it
gets capability to load modules othe
acassis commented on PR #2985:
URL: https://github.com/apache/nuttx-apps/pull/2985#issuecomment-2685524162
@anchao could you please verify, it is failing in the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2641773417
> Thanks @anchao :-)
>
> * Why this change is really necessary? What it fixes / improves?
> * Modlib library [1] is meant for loadable modules of various formats. So
far we only s
anchao commented on PR #2985:
URL: https://github.com/apache/nuttx-apps/pull/2985#issuecomment-2641700861
> Thanks @anchao :-)
>
> * Why this change is really necessary? What it fixes / improves?
> * Modlib library [1] is meant for loadable modules of various formats. So
far we onl
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636459231
> > Cool lemme know when we're ready to retest, I'll run my script again.
Thanks :-)
>
> It seems that qemu 8.2.2 cannot execute rv-virt/knsh64 not caused by my
PR. If your test env
anchao commented on code in PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#discussion_r1942662048
##
libs/libc/libelf/libelf.h:
##
@@ -1,5 +1,5 @@
/
- * libs/libc/modlib/modlib.h
+ * libs/li
anchao commented on code in PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#discussion_r1942661759
##
Documentation/applications/examples/module/index.rst:
##
@@ -55,8 +55,8 @@ configuration options:
6. Linker scripts. You might also want to use a linker scripts to
xiaoxiang781216 commented on code in PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#discussion_r1942578268
##
libs/libc/libelf/libelf.h:
##
@@ -1,5 +1,5 @@
/
- * libs/libc/modlib/modlib.h
+
xiaoxiang781216 commented on code in PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#discussion_r1942576398
##
Documentation/platforms/arm/samv7/boards/samv71-xult/README.txt:
##
@@ -1819,10 +1819,10 @@ Configuration sub-directories
CONFIG_FS_ROMFS=y
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636251257
> Cool lemme know when we're ready to retest, I'll run my script again.
Thanks :-)
It seems that qemu 8.2.2 cannot execute rv-virt/knsh64 not caused by my PR.
If your test environme
lupyuen commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636242496
Cool lemme know when we're ready to retest, I'll run my script again. Thanks
:-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636236723
> @lupyuen Thank you, I updated my modification and changed elf to libelf,
so that rv-virt:knsh64 can be compiled successfully, but I found a new issue,
rv-virt:knsh64 cannot be starte
anchao commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636121996
> Sorry @anchao I tested the new branch `anchao:25020501` for NuttX and
Apps, it fails to build for rv-virt:knsh64. Did I miss something? Thanks :-)
https://gist.github.com/lupyuen/58c3b95
xiaoxiang781216 commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636025659
> Sorry @anchao I tested the new branch `anchao:25020501` for NuttX and
Apps, it fails to build for rv-virt:knsh64. Did I miss something? Thanks :-)
https://gist.github.com/lupyue
lupyuen commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2636029832
@xiaoxiang781216 There's no Build Bot yet. It's a Manual Bot :-) Lemme know
when the PR is ready, perhaps we should set the PR to Draft Mode?
--
This is an automated message from the Ap
nuttxpr commented on PR #2985:
URL: https://github.com/apache/nuttx-apps/pull/2985#issuecomment-2635989079
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
No, this PR does not fully meet the NuttX requiremen
nuttxpr commented on PR #15765:
URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2635968256
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
No. This PR, as described, does not fully meet the Nutt
anchao opened a new pull request, #2985:
URL: https://github.com/apache/nuttx-apps/pull/2985
## Summary
libc/elf: rename modlib to elf
Renaming "modlib" to "elf" is more in line with the implementation content,
which makes it easier for independent developers to understand th
anchao opened a new pull request, #15765:
URL: https://github.com/apache/nuttx/pull/15765
## Summary
libc/elf: rename modlib to elf
Renaming "modlib" to "elf" is more in line with the implementation content,
which makes it easier for independent developers to understand the
28 matches
Mail list logo
