anchao commented on PR #15765: URL: https://github.com/apache/nuttx/pull/15765#issuecomment-2641773417
> Thanks @anchao :-) > > * Why this change is really necessary? What it fixes / improves? > * Modlib library [1] is meant for loadable modules of various formats. So far we only support ELF but other formats may be added. When other formats are added then elf name will be confusing again. We should stick to name modlib as this is loadable module component, not just elf handler. > * How does that change impact existing configurations and backward-compatibility (i.e. older nuttx-apps)? You marked impact `N/A` but this seems breaking change so description is invalid? Also providing reference to different change is not an impact factor just a reference / dependency and should belong to summary section. > * This change will breaks existing libc and configuration. It will break compatibility with nuttx-apps out of sync with nuttx. This change should be marked as breaking change. It would be good to first discuss this kind of change on mailing lists. > * Where are build / runtime test logs? Did you verify build and runtime with latest release of nuttx-apps to see if it does not break things? > * How does that align with other standards (libc) and OS/RTOS implementations? > * Okay I can see that `modlib_` calls [2] are renamed to `libelf_`. Is this in align and compatibility with existing `libelf` library? > > [1] https://nuttx.apache.org/docs/latest/applications/examples/module/index.html [2] https://github.com/apache/nuttx/tree/fdc0b608b5893a207ea37a276e0adade6ded3b62/libs/libc/modlib https://github.com/apache/nuttx-apps/pull/2985#issuecomment-2641700861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
