nuttxpr commented on PR #2985: URL: https://github.com/apache/nuttx-apps/pull/2985#issuecomment-2635989079
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details. Here's what's missing: * **Summary:** While the "what" is explained, the "why" is weak. Why is "elf" a *better* name than "modlib"? What confusion does the current name cause? More context is needed. The summary also needs the related NuttX issue number. * **Impact:** "N/A, depends on another PR" is insufficient. Even with a dependency, this PR *will* have an impact. At minimum, it will change the configuration option name, which has build system impact. All impact sections should be explicitly addressed with "YES" or "NO" and a description if "YES." Consider the impact if/when the other PR is merged. Will this rename break anything? Will documentation need updates? * **Testing:** "sim/sotest" is inadequate. Provide specifics: Which sim? Which sotest? What commands were run? Actual log output, even if minimal, is required *before* and *after* the change. The current entry provides no evidence of testing. It also needs details about the build host used. Therefore, the PR needs revision before it can be considered complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
