jerpelea commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2703321333
@acassis the PR was merged with documentation and board configs mixed in the
same commit !
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
acassis commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2704064936
@jerpelea true, but at least the Documentation is related to the same logic
thing of the boards defconfigs.
Also when I said that Zephyr doesn't enforce it, you said that Linux does
xiaoxiang781216 commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2705329541
> @cederom basically all the requested changes were fixed. But I agree this
PR could have high risk to break existing system and the author didn't test on
real hardware.
no
acassis commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2704774615
@cederom basically all the requested changes were fixed. But I agree this PR
could have high risk to break existing system and the author didn't test on
real hardware.
--
This is an au
cederom commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2704648981
@acassis this is second time recently you have merged PR despite unresolved
discussions and potentially breaking changes :-(
--
This is an automated message from the Apache Git Service.
xiaoxiang781216 commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2704103928
I prefer all related change in one patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
acassis merged PR #15931:
URL: https://github.com/apache/nuttx/pull/15931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
xiaoxiang781216 commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2701255545
> > @yangsong8-a1: @cederom I see what you mean. I will split the changes in
2 pr. Please help confirm whether it is appropriate to split as described below.
> > ```
> > 1. d
cederom commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2701145576
> @yangsong8-a1: @cederom I see what you mean. I will split the changes in 2
pr. Please help confirm whether it is appropriate to split as described below.
>
> 1. drivers/serial
yangsong8-a1 commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2700067198
> > > @cederom: Should we use `[BREAKING]` tag in the PR name and commits?
So its easier to trace if anyone have problem after that change?
> >
> >
> > @yangsong8-a1: There
cederom commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2699621969
> > @cederom: Should we use `[BREAKING]` tag in the PR name and commits? So
its easier to trace if anyone have problem after that change?
>
> @yangsong8-a1: There is no problem with
yangsong8-a1 commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2699534857
> Should we use `[BREAKING]` tag in the PR name and commits? So its easier
to trace if anyone have problem after that change?
There is no problem with local compilation. The CI
cederom commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2698938860
Should we use `[BREAKING]` tag in the PR name and commits? So its easier to
trace if anyone have problem after that change?
--
This is an automated message from the Apache Git Service.
yangsong8-a1 commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2696887953
> please note that there are many configs which must be updated after the
driver change
@jerpelea done. thank you.
--
This is an automated message from the Apache Git Servi
yangsong8-a1 commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2696885111
> please split the changes in 2 pr drivers/serial/cdcacm: Reduce one copy of
data between serial and cdcacm framework boards/mips/pic32mx: remove fixed
CDACM BUFFER SIXE
@jerp
yangsong8-a1 commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2696460938
> Thank you @yangsong8-a1 :-)
>
> * There are build errors, please fix :-)
> * Is this solution portable over different archs/boards?
> * This is a potential breaking chan
nuttxpr commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2694202924
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
No, this PR does not fully meet the NuttX requirements
yangsong8-a1 opened a new pull request, #15931:
URL: https://github.com/apache/nuttx/pull/15931
*Note: Please adhere to [Contributing
Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
Data form serial framework will be written to usb reqbuf d
18 matches
Mail list logo
