yangsong8-a1 commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2700067198
> > > @cederom: Should we use `[BREAKING]` tag in the PR name and commits?
So its easier to trace if anyone have problem after that change?
> >
> >
> > @yangsong8-a1: There is no problem with local compilation. The CI in
github will prompt that the two configs do not match. Is it due to format
detection?
>
> This change is not only about "reducing one copy operation in CDC ACM" as
stated in the PR title.. there are much more CDC ACM changes including
configuration variables etc.. therefore after this change someone who used
existing code and configuration may have problems building and/org running..
thus this is breaking change and the `[BREAKING]` mark on the PR/commit line
containing also `usb cdc adm` keywords would help affected people quickly find
what where and why changed so they can update their local code.
>
> Its not that we do not want to change things for better.. but we need
special attention if changes may break existing stuff for other people (for
instance some company have a project that stops building or working after git
pull after change is merged to upstream). If breaking changes are absolutely
necessary then we need to mark them as such (i.e. `[BREAKING]` tag in the PR /
git commit).
>
> Thus @jerpelea request to split this PR into TWO separate PRs:
>
> > please split the changes in 2 pr
> >
> > 1. drivers/serial/cdcacm: Reduce one copy of data between serial and
cdcacm framework
> > 2. boards/mips/pic32mx: remove fixed CDACM BUFFER SIXE
>
> The 1 is a simple fix and can be merged easily. The 2 seems breaking
change that will break build on existing projects. We need to think very
seriously not to break projects for other people by our changes. When possible
all fixes should not be breaking (i.e. something is fixed, plus still builds
and runs on older projects code).
@cederom I see what you mean. I will split the changes in 2 pr. Please help
confirm whether it is appropriate to split as described below.
1. drivers/serial/cdcacm: Reduce one copy of data between serial and cdcacm
framework
This PR only contains code modifications. In order to ensure that CI
passes, the content in Kconfig remains unchanged.
2. [BREAKING] boards/defconfig: remove fixed CDACM BUFFER SIXE
Modify Kconfig and all related boards defconfig in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
