nuttxpr commented on PR #15931: URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2694202924
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements based on the information provided. Here's why: * **Insufficient Summary:** The summary is too brief. It mentions *what* is changing but not *why*. What problem does this solve? Is it a performance improvement, bug fix, or new feature? How does writing directly to the `reqbuf` work? No related issues are referenced. * **Incomplete Impact Assessment:** The impact section only mentions "cdcacm." This is insufficient. All other impact categories need to be addressed with either "NO" or "YES (with an explanation)." The lack of detail makes it impossible to assess the risks and benefits of this change. * **Inadequate Testing:** "selftest" is not enough. Provide specific details about the selftest performed, including: * Build Host information (OS, CPU, Compiler) * Target information (Architecture, Board, Configuration) * **Crucially:** Actual "before" and "after" logs demonstrating the change in behavior. Empty code blocks are unacceptable. Show the output demonstrating the problem before the change and the improved/corrected behavior after the change. **To make this PR acceptable, it needs the following:** 1. **Expanded Summary:** Explain the rationale behind the change. What problem does it solve or what improvement does it provide? Provide more detail on the mechanism of writing directly to `reqbuf`. Link to relevant NuttX or NuttX Apps issues. 2. **Complete Impact Assessment:** Address *all* impact categories. Explain any "YES" answers thoroughly. 3. **Detailed Testing Information:** Fill in the blanks for build host and target details. Provide *actual* log output before and after the change, demonstrating the issue being fixed or the new functionality working as expected. If "selftest" is a specific NuttX test, name it explicitly. By addressing these points, the PR will be much more likely to be accepted. The more information provided, the easier it is for reviewers to understand and approve the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
