anchao closed pull request #2918: apps/system: replace CONFIG_NSH_LINELEN to
LINE_MAX
URL: https://github.com/apache/nuttx-apps/pull/2918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
anchao commented on PR #2918:
URL: https://github.com/apache/nuttx-apps/pull/2918#issuecomment-2595979078
> @anchao do we still need this patch?
not anymore, let me abandon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
xiaoxiang781216 commented on PR #2918:
URL: https://github.com/apache/nuttx-apps/pull/2918#issuecomment-2595931838
@anchao do we still need this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
cederom commented on PR #2918:
URL: https://github.com/apache/nuttx-apps/pull/2918#issuecomment-2568612757
> > > 3. Where is `LINE_MAX` defined?
> >
> >
> > here: [apache/nuttx#15344](https://github.com/apache/nuttx/pull/15344)
LINE_MAX is POSIX defined macro.
>
> Specifica
patacongo commented on PR #2918:
URL: https://github.com/apache/nuttx-apps/pull/2918#issuecomment-2568611200
> > 3\. Where is `LINE_MAX` defined?
>
> here: [apache/nuttx#15344](https://github.com/apache/nuttx/pull/15344)
LINE_MAX is POSIX defined macro.
Specifically, limits.h:
xiaoxiang781216 commented on PR #2918:
URL: https://github.com/apache/nuttx-apps/pull/2918#issuecomment-2568603108
> Thank you @anchao :-) My questions:
>
> 1. Where `LINE_MAX` should be used and where `CONFIG_NSH_LINELEN`?
Yes, the patch plan to replace all XXX_LINELEN to LINE_
xiaoxiang781216 commented on code in PR #2918:
URL: https://github.com/apache/nuttx-apps/pull/2918#discussion_r1899979968
##
nshlib/nsh.h:
##
@@ -380,7 +380,7 @@
/* Maximum size of one command line (telnet or serial) */
#ifndef CONFIG_NSH_LINELEN
Review Comment:
let's re
xiaoxiang781216 commented on code in PR #2918:
URL: https://github.com/apache/nuttx-apps/pull/2918#discussion_r1899978461
##
nshlib/nsh_console.h:
##
@@ -157,6 +157,14 @@ struct nsh_vtbl_s
char traceline[CONFIG_NSH_LINELEN];
#endif
+ /* Temporary line buffer */
+
+#if (!d
anchao commented on code in PR #2918:
URL: https://github.com/apache/nuttx-apps/pull/2918#discussion_r1899073456
##
nshlib/nsh_console.h:
##
@@ -157,6 +157,14 @@ struct nsh_vtbl_s
char traceline[CONFIG_NSH_LINELEN];
#endif
+ /* Temporary line buffer */
+
+#if (!defined(CO
xiaoxiang781216 commented on code in PR #2918:
URL: https://github.com/apache/nuttx-apps/pull/2918#discussion_r1899069478
##
nshlib/nsh_console.h:
##
@@ -157,6 +157,14 @@ struct nsh_vtbl_s
char traceline[CONFIG_NSH_LINELEN];
#endif
+ /* Temporary line buffer */
+
+#if (!d
nuttxpr commented on PR #2918:
URL: https://github.com/apache/nuttx-apps/pull/2918#issuecomment-2563373235
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
No, this PR does not fully meet the NuttX requiremen
anchao opened a new pull request, #2918:
URL: https://github.com/apache/nuttx-apps/pull/2918
## Summary
1. apps/system: replace CONFIG_NSH_LINELEN to LINE_MAX
Applications should not depend on any properties of nshlib
Signed-off-by: chao an
2. nshlib/nshline: move
12 matches
Mail list logo
