xiaoxiang781216 commented on PR #2918: URL: https://github.com/apache/nuttx-apps/pull/2918#issuecomment-2568603108
> Thank you @anchao :-) My questions: > > 1. Where `LINE_MAX` should be used and where `CONFIG_NSH_LINELEN`? Yes, the patch plan to replace all XXX_LINELEN to LINE_MAX. > 2. Where is `LINE_MAX` defined? here: https://github.com/apache/nuttx/pull/15344 LINE_MAX is POSIX defined macro. > 3. Wouldn't that create inconsistency? no, it improves the consistency, since all places will use the standard macro defined by POSIX. > 4. This seems to require a documentation update? Or at least mention on the change and what/where is preferred in regard to above two questions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
