xiaoxiang781216 commented on code in PR #2918: URL: https://github.com/apache/nuttx-apps/pull/2918#discussion_r1899978461
########## nshlib/nsh_console.h: ########## @@ -157,6 +157,14 @@ struct nsh_vtbl_s char traceline[CONFIG_NSH_LINELEN]; #endif + /* Temporary line buffer */ + +#if (!defined(CONFIG_NSH_DISABLE_MEMDUMP) && defined(NSH_HAVE_WRITEFILE)) || \ + !defined(CONFIG_NSH_DISABLEBG) || defined(CONFIG_NSH_PIPELINE) || \ + !defined(CONFIG_NSH_DISABLE_WATCH) + char templine[CONFIG_NSH_LINELEN]; Review Comment: could you split the rename from moving buffer to nsh_vtbl? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
