Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-13 Thread via GitHub
xiaoxiang781216 merged PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-12 Thread via GitHub
yamt commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1889447865 > > > @yamt please change INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX, thanks. > > > > > > done > > but could you sqaush i

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-12 Thread via GitHub
xiaoxiang781216 commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1889444779 > > @yamt please change INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX, thanks. > > done but could you sqaush into one

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-12 Thread via GitHub
yamt commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1889417593 > @yamt please change INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX, thanks. done -- This is an automated message from the Apache Gi

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-12 Thread via GitHub
xiaoxiang781216 commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1888729630 @yamt please change INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX, thanks. -- This is an automated message from the Apache Git S

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-11 Thread via GitHub
yamt commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1888476790 > > > > > Perhaps we could consider renaming the option to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC. > > > > > > > > > > > > i have no problem with the name. > > >

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-11 Thread via GitHub
xiaoxiang781216 commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1888475418 > > > > Perhaps we could consider renaming the option to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC. > > > > > > > > > i have no problem with the name. > >

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-11 Thread via GitHub
yamt commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1888434168 > > > Perhaps we could consider renaming the option to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC. > > > > > > i have no problem with the name. > > it's a pure nuttx

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-11 Thread via GitHub
no1wudi commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1886663808 > it's a pure nuttx option, why need append _FOR_NUTTX_LIBC? INTERPRETERS_WAMR_BUILD_MODULES is enough to represent the intent. In fact, these modules from NuttX's build syst

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-11 Thread via GitHub
xiaoxiang781216 commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1886638836 > > Perhaps we could consider renaming the option to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC. > > i have no problem with the name. it's a pure nuttx option,

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-11 Thread via GitHub
yamt commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1886590357 > Perhaps we could consider renaming the option to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC. i have no problem with the name. -- This is an automated message from the A

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-10 Thread via GitHub
no1wudi commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1886496843 @xiaoxiang781216 I think we should land this patch first because there are indeed users who use WAMR on NuttX, but they don't need to build applications from within NuttX. This way, th

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-10 Thread via GitHub
no1wudi commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1886444618 @yamt I'm sorry to cause you trouble, and I think it's reasonable to add an option to control this behavior. However, building Wasm applications with NuttX headers in the NuttX build

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-10 Thread via GitHub
yamt commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1886183693 do anyone still have any concerns? it was a bit surprising me that it was this controversial to disable a very experimental feature which is breaking unrelated workloads. -- This is

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-12-29 Thread via GitHub
no1wudi commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1438084238 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INTERPRETER

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-12-28 Thread via GitHub
xiaoxiang781216 commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1438071951 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INT

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-12-28 Thread via GitHub
yamt commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1437854940 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INTERPRETERS_W

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-12-28 Thread via GitHub
xiaoxiang781216 commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1437833385 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INT

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-12-28 Thread via GitHub
yamt commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1437492288 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INTERPRETERS_W

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-12-28 Thread via GitHub
xiaoxiang781216 commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1437477025 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INT

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-12-28 Thread via GitHub
yamt commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1437475267 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INTERPRETERS_W

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-12-28 Thread via GitHub
xiaoxiang781216 commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1437471579 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INT

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-12-27 Thread via GitHub
yamt commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1437367571 ## tools/Wasm.mk: ## @@ -19,8 +19,8 @@ # -# Only build wasm if one of the following run

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-12-27 Thread via GitHub
yamt commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1437366645 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INTERPRETERS_W

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-12-27 Thread via GitHub
xiaoxiang781216 commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1437186005 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INT

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-10-23 Thread via GitHub
yamt commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1369665754 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INTERPRETERS_W

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-10-23 Thread via GitHub
acassis commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1368813404 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INTERPRETER

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-10-18 Thread via GitHub
acassis commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1363980142 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INTERPRETER

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2023-10-10 Thread via GitHub
yamt commented on code in PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1351872733 ## interpreters/wamr/Kconfig: ## @@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN bool "Enable built-in libc" default n +config INTERPRETERS_W