xiaoxiang781216 commented on code in PR #2065:
URL: https://github.com/apache/nuttx-apps/pull/2065#discussion_r1437471579
##########
interpreters/wamr/Kconfig:
##########
@@ -70,6 +70,11 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN
bool "Enable built-in libc"
default n
+config INTERPRETERS_WAMR_BUILD_WASM_MODULES_FOR_WAMR_LIBC_BUILTIN
Review Comment:
> WASM_BUILD is supposed to be set by each apps, isn't it? eg.
>
Yes.
>
https://github.com/apache/nuttx-apps/blob/ba075747be4bbd8b9a2a2f86a02593d4a5a40413/benchmarks/coremark/Makefile#L135
>
>
> i'm not sure what you mean by "change the default value of WASM_BUILD to n
directly".
The build system doesn't generate wasm module unless the user set
WASM_BUILD=y in Makefile explicitly. So WASM_BUILD support the same
functionality of INTERPRETERS_WAMR_BUILD_WASM_MODULES_FOR_WAMR_LIBC_BUILTIN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
