yamt commented on PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065#issuecomment-1888476790
> > > > > Perhaps we could consider renaming the option to INTERPRETERS_WAMR_BUILD_MODULES_FOR_NUTTX_LIBC. > > > > > > > > > > > > i have no problem with the name. > > > > > > > > > it's a pure nuttx option, why need append _FOR_NUTTX_LIBC? INTERPRETERS_WAMR_BUILD_MODULES is enough to represent the intent. > > > > > > wasm modules are often expected more "run anywhere" than eg. ELF objects. there is even a standard (well, at least de-facto) system interface available, wasi. just INTERPRETERS_WAMR_BUILD_MODULES gives me a false impression that it uses wasi. > > Ok, but it's better to remove _LIBC suffix from the option since many non libc api can expose too. ok, it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
