xiaoxiang781216 commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2873324787
I am fine with either, but the rule require at least two member approve to
merge your change.
--
This is an automated message from the Apache Git Service.
To respond to the mess
sumpfralle commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2873226277
> why not fix the spell error file by file?
I tried to explain it before.
Sorry - I do not want to sound rude. And I do not want to the waste the
boring labor of two long
sumpfralle closed pull request #16318: Documentation: fix spelling
URL: https://github.com/apache/nuttx/pull/16318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
xiaoxiang781216 commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2870575447
> > > I would like to wrap this PR up. Is there anything missing?
> >
> >
> > still has error not fix yet:
https://github.com/apache/nuttx/actions/runs/14902428691/job/4
sumpfralle commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2870190208
> > I would like to wrap this PR up. Is there anything missing?
>
> still has error not fix yet:
https://github.com/apache/nuttx/actions/runs/14902428691/job/41857195862?pr=16318
xiaoxiang781216 commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2868336497
> I would like to wrap this PR up. Is there anything missing?
still has error not fix yet:
https://github.com/apache/nuttx/actions/runs/14902428691/job/41857195862?pr=16
sumpfralle commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2867509007
I would like to wrap this PR up. Is there anything missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
sumpfralle commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2862312868
> please fix the conflict.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
xiaoxiang781216 commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2862246153
please fix the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
sumpfralle commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2862244574
Following @xiaoxiang781216's suggestion, I prolonged the three release note
lines instead of adding exceptions.
The remaining exceptions for release note lines refer to commit ti
xiaoxiang781216 commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2854683859
If we already modify Release note, I prefer to fix all problems directly
instead adding the exception rule. It's always good to minimize the exception
rule as much as possible.
sumpfralle commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2854536217
I am trying to summarize the state of discussion:
* A) Enabling codespell checks in `checkpatch.sh` by default?
* At the moment, *no tests* are enabled by default in that s
xiaoxiang781216 commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2854250308
> I think that the release notes should not be corrected since those are
spelling errors in the actual commit titles
but the similar issue in commit message is already fixed
sumpfralle commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2852038376
hint: updated PR with one more spelling fix (`MingGW`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
acassis commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2852015092
Thank you @sumpfralle now I saw the point, the -c parameter already existed
in checkpatch.sh. The issue is: in the past it was optional, since there is no
codespell check in the CI.
sumpfralle commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2852005777
> @sumpfralle I looked again and didn't see it included inside checkpatch.sh
script.
>
> More info about the script:
https://nuttx.apache.org/docs/latest/components/tools/index.
acassis commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2851981753
> > I think now the checkpatch should include the code spelling test, [..]
>
> I think, this was done in #16302? Or do you mean something else?
@sumpfralle I looked again and
sumpfralle commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2851955035
> I think now the checkpatch should include the code spelling test, [..]
I think, this was done in #16302? Or do you mean something else?
--
This is an automated message from t
acassis commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2851946384
@sumpfralle @xiaoxiang781216 I think now the checkpatch should include the
code spelling test, otherwise devs only will discover about the fault too late
(then it is using the CI) and we
sumpfralle commented on code in PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#discussion_r2073738401
##
.codespell-ignore-lines:
##
@@ -12,3 +12,10 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A
24V
THN,
# define AES_ISR_URAT_WORRDACC (5 <<
nuttxpr commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2851468744
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
__Fill In The Commit Message:__ This PR contains a Commit with
xiaoxiang781216 commented on code in PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#discussion_r2073708462
##
.codespell-ignore-lines:
##
@@ -12,3 +12,10 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A
24V
THN,
# define AES_ISR_URAT_WORRDACC
sumpfralle opened a new pull request, #16318:
URL: https://github.com/apache/nuttx/pull/16318
## Summary
This changeset builds upon previous PRs:
* #16282: fix typos in documentation
* #16302: enable codespell in CI
This changeset fixes (or masks) all remaining issues (as
23 matches
Mail list logo
