Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086063197 ## fs/inode/fs_files.c: ## @@ -554,16 +663,25 @@ int file_allocate_from_tcb(FAR struct tcb_s *tcb, FAR struct inode *inode, { int i = minfd / CONFIG_NFILE_DESCRIPTO

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086061232 ## include/nuttx/fs/fs.h: ## @@ -490,20 +495,20 @@ struct file * (file descriptor % CONFIG_NFILE_DESCRIPTORS_PER_BLOCK) as column index. */ -struct filelist +struc

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086061787 ## fs/inode/fs_files.c: ## @@ -554,16 +663,25 @@ int file_allocate_from_tcb(FAR struct tcb_s *tcb, FAR struct inode *inode, { int i = minfd / CONFIG_NFILE_DESCRIPTO

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on PR #16360: URL: https://github.com/apache/nuttx/pull/16360#issuecomment-2875132203 > > @jlaitine but is it wrong to skip sem holder updating in the fast path if user enable priority inheritance? > > This is a good question, and raises from a confusion in t

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
jlaitine commented on PR #16360: URL: https://github.com/apache/nuttx/pull/16360#issuecomment-2875088409 > Are there any stats I can get for this, how much I got slow routines on running system? Like irqinfo stats. It would be great to have something like seminfo stats in proc There

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
jlaitine commented on PR #16360: URL: https://github.com/apache/nuttx/pull/16360#issuecomment-2875077580 Re-based against latest master and added UNUSED(..) macros to pass the CI for targets which don't enable the fast path at all. -- This is an automated message from the Apache Git Servi

[PR] Bluetooth SMP: added support for Legacy pairing (MITM) with passkey [nuttx]

2025-05-12 Thread via GitHub
robertc2000 opened a new pull request, #16364: URL: https://github.com/apache/nuttx/pull/16364 ## Summary This PR introduces support for Legacy Bluetooth Pairing with Passkey Entry, specifically enabling the NuttX device to act in a "DisplayOnly" I/O capability role. This allows the

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
jlaitine commented on PR #16360: URL: https://github.com/apache/nuttx/pull/16360#issuecomment-2875003933 > @jlaitine but is it wrong to skip sem holder updating in the fast path if user enable priority inheritance? This is a good question, and raises from a confusion in the original

Re: [PR] boards/arm/rp23xx/raspberrypi-pico-2: add smp config [nuttx]

2025-05-12 Thread via GitHub
shtirlic commented on PR #16354: URL: https://github.com/apache/nuttx/pull/16354#issuecomment-2874963550 @acassis update to address readme.txt and baord docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Add GlobalPlatform API client library (libteec) and example app (optee_gp) [nuttx-apps]

2025-05-12 Thread via GitHub
gpoulios commented on PR #3074: URL: https://github.com/apache/nuttx-apps/pull/3074#issuecomment-2874921458 > Done, but you can update the patch to retrigger ci too. Thank you @xiaoxiang781216. I know, I just didn’t want to lose the approvals. -- This is an automated message from th

Re: [PR] Add GlobalPlatform API client library (libteec) and example app (optee_gp) [nuttx-apps]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on PR #3074: URL: https://github.com/apache/nuttx-apps/pull/3074#issuecomment-2874911563 > One check should pass now that [apache/nuttx#16356](https://github.com/apache/nuttx/pull/16356) is merged. > > The other failing check (msys), I don’t quite understand.

Re: [PR] Add GlobalPlatform API client library (libteec) and example app (optee_gp) [nuttx-apps]

2025-05-12 Thread via GitHub
gpoulios commented on PR #3074: URL: https://github.com/apache/nuttx-apps/pull/3074#issuecomment-2874893172 One check should pass now that https://github.com/apache/nuttx/pull/16356 is merged. The other failing check (msys), I don’t quite understand. Can someone re-trigger thos

Re: [I] [BUG] RP2040 Unstability, garbled NSH [nuttx]

2025-05-12 Thread via GitHub
linguini1 commented on issue #16305: URL: https://github.com/apache/nuttx/issues/16305#issuecomment-2874887088 It gets much worse when I enable the command line editor mode instead of just readline: ![Image](https://github.com/user-attachments/assets/4338d6fb-0dd8-42f2-813c-8c2612714

(nuttx) 05/07: drivers/misc/optee: Fix non-registered memory ref passing

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 47064e42df59e7ac4c41a289aff97989aa688df8 Author: George Poulios AuthorDate: Sat May 10 21:39:54 2025 +0300 driver

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
Donny9 commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2084821846 ## include/nuttx/fs/fs.h: ## @@ -490,20 +495,20 @@ struct file * (file descriptor % CONFIG_NFILE_DESCRIPTORS_PER_BLOCK) as column index. */ -struct filelist +struc

(nuttx) 02/07: drivers/misc/optee: Fix GP API compatibility

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit a2a689fee046d2bdb14e4f6feba8d82cc9de9040 Author: George Poulios AuthorDate: Sat May 10 14:40:26 2025 +0300 driver

(nuttx) 04/07: drivers/misc/optee: Proper cleanup of registered shm

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 6f77cb6dce35272f07a6e7a2c2716c000c41789f Author: George Poulios AuthorDate: Sat May 10 17:46:59 2025 +0300 driver

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 merged PR #16356: URL: https://github.com/apache/nuttx/pull/16356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) 07/07: boards/imx93-evk: kernel build with OPTEE/SMC

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 70b595146bec486dd5282238b8778339625b3705 Author: George Poulios AuthorDate: Sun May 11 11:40:33 2025 +0300 boards

(nuttx) 06/07: tools/nxstyle.c: Whitelist libteec mixed case symbols

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 2799cba36b3690ea764748f0f7cb312163c5b282 Author: George Poulios AuthorDate: Sun May 11 02:52:07 2025 +0300 tools/

(nuttx) 01/07: drivers/misc/optee: Harmonize invalid user addr errors

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit c497ee249b4ea4aa7ce41afe8a13986bf5612e40 Author: George Poulios AuthorDate: Fri May 9 18:04:20 2025 +0300 drivers

(nuttx) branch master updated (c0a6afff11 -> 70b595146b)

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from c0a6afff11 drivers/usbdev/Kconfig: fix COMPOSITE_VENDORSTR description new c497ee249b drivers/misc/optee: Harmo

(nuttx) 03/07: drivers/misc/optee: Rename optee_shm_entry to optee_shm

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 7f20487f56ad9e95cd2ec5ff2d2c77a30523a275 Author: George Poulios AuthorDate: Sat May 10 15:17:27 2025 +0300 driver

Re: [I] [BUG] RP2040 Unstability, garbled NSH [nuttx]

2025-05-12 Thread via GitHub
linguini1 commented on issue #16305: URL: https://github.com/apache/nuttx/issues/16305#issuecomment-2874811083 I've noticed that `nsh_update_prompt()` get's called every time I hit enter, which seems incorrect to me since it's only called during initialization and `nsh_session()`. I don't t

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2085787448 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR

Re: [PR] drivers/usbdev/Kconfig: fix COMPOSITE_VENDORSTR description [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 merged PR #16359: URL: https://github.com/apache/nuttx/pull/16359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: drivers/usbdev/Kconfig: fix COMPOSITE_VENDORSTR description

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new c0a6afff11 drivers/usbdev/Kconfig: fix COMPOSI

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on PR #16360: URL: https://github.com/apache/nuttx/pull/16360#issuecomment-2874786311 @jlaitine but is it wrong to skip sem holder updating in the fast path if user enable priority inheritance. -- This is an automated message from the Apache Git Service. To respo

Re: [I] [BUG] RP2040 Unstability, garbled NSH [nuttx]

2025-05-12 Thread via GitHub
linguini1 commented on issue #16305: URL: https://github.com/apache/nuttx/issues/16305#issuecomment-2874663905 This is the character I always see, across multiple boards, when using the `miniterm` Python module. I haven't seen this when using Minicom. ![Image](https://github.com/user

(nuttx-website) branch asf-site updated: Publishing web: 16e1777b863bd27e3a00b7b779baf0131af07df6 docs: 64a7049decb0671a76e7a6d1585eed8bece344df

2025-05-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 2d2bd7ad0 Publishing web: 16e1777

[PR] docs/rp2040: Remove documentation duplication of RP2040 boards. [nuttx]

2025-05-12 Thread via GitHub
linguini1 opened a new pull request, #16362: URL: https://github.com/apache/nuttx/pull/16362 ## Summary Installation instructions, license exceptions and supported features of the RP2040 common among all boards have been moved exclusively to the rp2040/index.rst file. Board documenta

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085174457 ## include/nuttx/fs/fs.h: ## @@ -466,6 +466,15 @@ struct file off_t f_pos; /* File position */ Review Comment: Yes I forgot to remove the option,

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
shtirlic commented on PR #16360: URL: https://github.com/apache/nuttx/pull/16360#issuecomment-2873550756 Are there any stats I can get for this, how much I got slow routines on running system? Like irqinfo stats. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085178083 ## fs/vfs/fs_dup.c: ## @@ -73,21 +73,28 @@ int file_dup(FAR struct file *filep, int minfd, int flags) ret = fs_getfilep(fd2, &filep2); #ifdef CONFIG_FDSAN - f_tag

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085174457 ## include/nuttx/fs/fs.h: ## @@ -466,6 +466,15 @@ struct file off_t f_pos; /* File position */ Review Comment: Yes I forgot to remove the option,

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085169044 ## net/local/local_sendmsg.c: ## @@ -125,7 +125,7 @@ static int local_sendctl(FAR struct local_conn_s *conn, goto fail; } - ret =

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085169015 ## fs/vfs/fs_dup3.c: ## @@ -1,5 +1,5 @@ / - * fs/vfs/fs_dup2.c + * fs/vfs/fs_dup3.c

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085168370 ## net/local/local_recvmsg.c: ## @@ -175,7 +175,7 @@ static void local_recvctl(FAR struct local_conn_s *conn, count = peer->lc_cfpcount; for (i = 0; i < count; i++

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085167937 ## include/nuttx/fs/fs.h: ## @@ -474,10 +483,6 @@ struct file uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init to 0 */ #endif -#if CONFIG_

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085165125 ## include/nuttx/fs/fs.h: ## @@ -959,7 +964,7 @@ int files_duplist(FAR struct filelist *plist, FAR struct filelist *clist, * ***

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085163075 ## include/nuttx/fs/fs.h: ## @@ -474,10 +483,6 @@ struct file uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init to 0 */ #endif -#if CONFIG_FS_BACKTR

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085160325 ## fs/vfs/fs_dup3.c: ## @@ -1,5 +1,5 @@ / - * fs/vfs/fs_dup2.c + * fs/vfs/fs_dup3.c Review

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085116249 ## net/local/local_recvmsg.c: ## @@ -175,7 +175,7 @@ static void local_recvctl(FAR struct local_conn_s *conn, count = peer->lc_cfpcount; for (i = 0; i < c

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
jlaitine commented on PR #16360: URL: https://github.com/apache/nuttx/pull/16360#issuecomment-2873396756 > Question: It tries to get sem only one time? Is possible to make it like 3 tries (for fast path) or configurable? I'd assume that it is so rare occasion that two cores try to inc

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
jlaitine commented on PR #16360: URL: https://github.com/apache/nuttx/pull/16360#issuecomment-2873385853 changed initialization of "new" to different place for nxsem_trywait for mips compiler thinking that it might be used uninitialized... -- This is an automated message from the Apache G

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
shtirlic commented on PR #16360: URL: https://github.com/apache/nuttx/pull/16360#issuecomment-2873372820 It's interesting, I also tried to this in my recent SMP experiments, but ditched due to lack of knowledge: ) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
jlaitine commented on code in PR #16360: URL: https://github.com/apache/nuttx/pull/16360#discussion_r2085117186 ## libs/libc/semaphore/sem_trywait.c: ## @@ -123,18 +126,64 @@ int nxsem_trywait(FAR sem_t *sem) #ifndef CONFIG_LIBC_ARCH_ATOMIC - if (NXSEM_IS_MUTEX(sem) + mut

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
jlaitine commented on code in PR #16360: URL: https://github.com/apache/nuttx/pull/16360#discussion_r2085117186 ## libs/libc/semaphore/sem_trywait.c: ## @@ -123,18 +126,64 @@ int nxsem_trywait(FAR sem_t *sem) #ifndef CONFIG_LIBC_ARCH_ATOMIC - if (NXSEM_IS_MUTEX(sem) + mut

Re: [I] [BUG] USBDEV CDC-NCM only works on first connect [nuttx]

2025-05-12 Thread via GitHub
TimJTi commented on issue #16345: URL: https://github.com/apache/nuttx/issues/16345#issuecomment-2873340121 > Hey if things behave a bit weird, ensure that the stacksizes are configured big enough. This is something you can easily confirm by enabling stack canaries and running 'ps' in nsh.

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2873324787 I am fine with either, but the rule require at least two member approve to merge your change. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [I] [BUG] USBDEV CDC-NCM only works on first connect [nuttx]

2025-05-12 Thread via GitHub
keever50 commented on issue #16345: URL: https://github.com/apache/nuttx/issues/16345#issuecomment-2873319044 Hey if things behave a bit weird, ensure that the stacksizes are configured big enough. This is something you can easily confirm by enabling stack canaries and running 'ps' in nsh.

Re: [I] [BUG] RP2040 Unstability, garbled NSH [nuttx]

2025-05-12 Thread via GitHub
keever50 commented on issue #16305: URL: https://github.com/apache/nuttx/issues/16305#issuecomment-2873266122 > I wonder also if there is anyone with a non-RP2040 board that has USB who can test the shell output for garbling. This would narrow it down to the RP2040 driver or a higher level

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-12 Thread via GitHub
sumpfralle commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2873226277 > why not fix the spell error file by file? I tried to explain it before. Sorry - I do not want to sound rude. And I do not want to the waste the boring labor of two long

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-12 Thread via GitHub
sumpfralle closed pull request #16318: Documentation: fix spelling URL: https://github.com/apache/nuttx/pull/16318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on PR #16361: URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2873177201 Reminder to self: remove the CONFIG_FS_REFCOUNT Kconfig option, it's blocking CI it seems. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2084978945 ## fs/vfs/fs_close.c: ## @@ -134,46 +143,84 @@ int file_close_without_clear(FAR struct file *filep) inode_release(inode); Review Comment: Can someone te

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2084978945 ## fs/vfs/fs_close.c: ## @@ -134,46 +143,84 @@ int file_close_without_clear(FAR struct file *filep) inode_release(inode); Review Comment: Can someone te

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on PR #16361: URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2872948730 I will do more testing tomorrow, but marking this as ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on PR #16361: URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2872946745 Added a new patch into this PR that fixes the inode refcnt leak for pseudofiles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Add GlobalPlatform API client library (libteec) and example app (optee_gp) [nuttx-apps]

2025-05-12 Thread via GitHub
cederom commented on PR #3074: URL: https://github.com/apache/nuttx-apps/pull/3074#issuecomment-2872942281 Thanks @gpoulios, lets keep the top level `optee/` then, okay? :-) I am not familiar with tee/optee thus my questions, `optee` is quicker to find any reference over `tee` :-)

Re: [PR] Add GlobalPlatform API client library (libteec) and example app (optee_gp) [nuttx-apps]

2025-05-12 Thread via GitHub
gpoulios commented on PR #3074: URL: https://github.com/apache/nuttx-apps/pull/3074#issuecomment-2872873812 > Is the name `tee/` correct, shouldn't it be `optee/`? The directory is named tee/ because there might be some other implementation in the future (e.g. libamdteec or whatever).

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084690257 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084690257 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084653304 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084653304 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] fs_vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw commented on PR #16361: URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2872530664 Marking as draft as this change has exposed a leak in inode refcount handling. It causes crashes when running test_nuttx_fs_dup201(). I'll find the root cause and fix this separately

[PR] fs_vfs: Separate file descriptors from file descriptions [nuttx]

2025-05-12 Thread via GitHub
pussuw opened a new pull request, #16361: URL: https://github.com/apache/nuttx/pull/16361 ## Summary This PR is a rework of the NuttX file descriptor implementation. The goal is two-fold: 1. Improve POSIX compliance. The old implementation tied file description to inode on

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084627419 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084618610 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083967437 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] libc/sched: Use TLS when available to cache the result of gettid syscall [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on PR #10572: URL: https://github.com/apache/nuttx/pull/10572#issuecomment-2872435224 the same feature is done by: https://github.com/apache/nuttx/pull/16134, let's close this pr. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] libc/sched: Use TLS when available to cache the result of gettid syscall [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 closed pull request #10572: libc/sched: Use TLS when available to cache the result of gettid syscall URL: https://github.com/apache/nuttx/pull/10572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on code in PR #16360: URL: https://github.com/apache/nuttx/pull/16360#discussion_r2084594418 ## libs/libc/semaphore/sem_post.c: ## @@ -119,6 +119,9 @@ int sem_post(FAR sem_t *sem) int nxsem_post(FAR sem_t *sem) { + bool mutex; + bool use_fastpath

Re: [PR] arch/sim/sim_oneshot: Calculate next oneshot time in ticks instead of… [nuttx]

2025-05-12 Thread via GitHub
jlaitine commented on code in PR #16358: URL: https://github.com/apache/nuttx/pull/16358#discussion_r2084596202 ## arch/sim/src/sim/sim_oneshot.c: ## @@ -317,7 +317,9 @@ static int sim_start(struct oneshot_lowerhalf_s *lower, flags = enter_critical_section(); sim_timer_c

[PR] libs/libc/semaphore: Enable semaphore fast wait/post paths for counting semaphores [nuttx]

2025-05-12 Thread via GitHub
jlaitine opened a new pull request, #16360: URL: https://github.com/apache/nuttx/pull/16360 ## Summary This PR completes the semaphore "fast path" in libc, by enabling the fast path also for counting semaphores, when they have the priority inheritance disabled. This is b

[PR] drivers/usbdev/Kconfig: fix COMPOSITE_VENDORSTR description [nuttx]

2025-05-12 Thread via GitHub
michallenc opened a new pull request, #16359: URL: https://github.com/apache/nuttx/pull/16359 ## Summary Option `COMPOSITE_VENDORSTR` should be described as composite vendor string, not vendor id. This is consistent with other USB devices. Also fixes a typo in `USBDEV_EPBUFFER_ALIG

(nuttx) 06/08: timer: pt_expected + 1 before set the timer.

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit c67ac63da3a100d9497457e1185c74214c0c6a00 Author: ouyangxiangzhen AuthorDate: Fri May 9 14:51:41 2025 +0800 timer:

(nuttx) 08/08: clock: Add clock_delay2abstick.

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 64a7049decb0671a76e7a6d1585eed8bece344df Author: ouyangxiangzhen AuthorDate: Fri May 9 20:07:58 2025 +0800 clock:

(nuttx) 04/08: sched: Correct word spelling mistakes.

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 3622e4830a8d38b93dfef008c946a3061fcbf5a7 Author: ouyangxiangzhen AuthorDate: Thu May 8 19:47:02 2025 +0800 sched:

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 merged PR #16343: URL: https://github.com/apache/nuttx/pull/16343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) 01/08: sched/wdog: Simplify nxsched_timer_process.

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit ba06ea6fd7a5161b367bcefae0168530c4068f4f Author: ouyangxiangzhen AuthorDate: Tue Mar 18 21:24:51 2025 +0800 sched

(nuttx) branch master updated (5d9a1aaf75 -> 64a7049dec)

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 5d9a1aaf75 armv7a/mmu: update from l1entry replace to TTBR0 update new ba06ea6fd7 sched/wdog: Simplify nxsched_

(nuttx) 05/08: clock: constants change to unsigned.

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 5e543421abbf64fafe9d5c2556b139aa941a1110 Author: ouyangxiangzhen AuthorDate: Fri May 9 09:36:58 2025 +0800 clock:

(nuttx) 02/08: sched: Remove unnecessary tick++ for absolute wdog timer.

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 8e653753655a91829190c524e49aac3766336dc6 Author: ouyangxiangzhen AuthorDate: Fri Mar 28 17:15:34 2025 +0800 sched

(nuttx) 03/08: sched/wdog: Add CONFIG_TIMER_ADJUST_USEC.

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit a255c99eb8a13197dc1a93b1910a4fd5d6268332 Author: ouyangxiangzhen AuthorDate: Tue Apr 1 20:09:40 2025 +0800 sched/

(nuttx) 07/08: clock: Fix timing error.

2025-05-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 2e8583f7590ce2f428856a12b74b27584e4881af Author: ouyangxiangzhen AuthorDate: Fri May 9 14:55:10 2025 +0800 clock:

Re: [I] [BUG] Random crashes in sim:citest cmocka_posix_timer test [nuttx]

2025-05-12 Thread via GitHub
anchao commented on issue #16341: URL: https://github.com/apache/nuttx/issues/16341#issuecomment-2872271185 > btw. [@anchao](https://github.com/anchao) this was closed wrongly, PR's [#16342](https://github.com/apache/nuttx/pull/16342) or [#16343](https://github.com/apache/nuttx/pull/16343)

Re: [I] [BUG] Random crashes in sim:citest cmocka_posix_timer test [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 commented on issue #16341: URL: https://github.com/apache/nuttx/issues/16341#issuecomment-2872239272 let's reopen it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] [BUG] System crashes after PR #16231 [nuttx]

2025-05-12 Thread via GitHub
jlaitine commented on issue #16341: URL: https://github.com/apache/nuttx/issues/16341#issuecomment-2872129154 btw. @anchao this was closed wrongly, PR's #16342 or #16343 won't fix this. #16358 will. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [I] [BUG] System crashes after PR #16231 [nuttx]

2025-05-12 Thread via GitHub
jlaitine commented on issue #16341: URL: https://github.com/apache/nuttx/issues/16341#issuecomment-2871942980 Unfortunately, the PR #16343 doesn't fix the bug. I tried to look it a bit further, and realized that "sim" target suffers from the same tick timer drift as what was fixed earlier f

[PR] arch/sim/sim_oneshot: Calculate next oneshot time in ticks instead of… [nuttx]

2025-05-12 Thread via GitHub
jlaitine opened a new pull request, #16358: URL: https://github.com/apache/nuttx/pull/16358 ## Summary This removes drift in tick start times, by aligning the tick start time to be even multiple of the tick time. ## Impact This fixes random failures in sim:citest (cm

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083967437 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

2025-05-12 Thread via GitHub
gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083967437 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

  1   2   >