Re: [PR] sched/signal: signal dispatch cleanups [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on PR #16333: URL: https://github.com/apache/nuttx/pull/16333#issuecomment-2861984535 I dropped the patches on an older commit to see if it now passes the CI; it looks to me that there is something wrong with the current master. -- This is an automated message from the

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on code in PR #16334: URL: https://github.com/apache/nuttx/pull/16334#discussion_r2079012684 ## libs/libc/signal/sig_raise.c: ## @@ -45,5 +45,5 @@ int raise(int signo) { - return tkill(_SCHED_GETTID(), signo); + return tgkill(_SCHED_GETPID(), _SCHED_GETT

Re: [I] [BUG] System crashes after https://github.com/apache/nuttx/pull/16231 [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on issue #16341: URL: https://github.com/apache/nuttx/issues/16341#issuecomment-2861866730 Specifically, I bisected the offending patch and it is 900b1c19ddfaece35df7306ad368db72c6a32a78 On the next patch, 9dbb9b49c65ed738948f3047d44d871c195cf3d2, the sim doesn't e

[I] [BUG] System crashes after https://github.com/apache/nuttx/pull/16231 [nuttx]

2025-05-07 Thread via GitHub
jlaitine opened a new issue, #16341: URL: https://github.com/apache/nuttx/issues/16341 ### Description / Steps to reproduce the issue To reproduce: ./tools/configure.sh sim:citest make ./nuttx nsh> cmocka ``` Output: [==] nuttx_mm_te

Re: [PR] sched/signal: signal dispatch cleanups [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on code in PR #16333: URL: https://github.com/apache/nuttx/pull/16333#discussion_r2078911248 ## sched/signal/sig_dispatch.c: ## @@ -374,6 +339,76 @@ static FAR sigpendq_t *nxsig_add_pendingsignal(FAR struct tcb_s *stcb, return sigpend; } +/*

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on code in PR #16334: URL: https://github.com/apache/nuttx/pull/16334#discussion_r2078910326 ## libs/libc/signal/sig_raise.c: ## @@ -45,5 +45,5 @@ int raise(int signo) { - return tkill(_SCHED_GETTID(), signo); + return tgkill(_SCHED_GETPID(), _SCHED_GETT

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on code in PR #16334: URL: https://github.com/apache/nuttx/pull/16334#discussion_r2078906467 ## libs/libc/signal/sig_raise.c: ## @@ -45,5 +45,5 @@ int raise(int signo) { - return tkill(_SCHED_GETTID(), signo); + return tgkill(_SCHED_GETPID(), _SCHED_GETT

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on code in PR #16334: URL: https://github.com/apache/nuttx/pull/16334#discussion_r2078906467 ## libs/libc/signal/sig_raise.c: ## @@ -45,5 +45,5 @@ int raise(int signo) { - return tkill(_SCHED_GETTID(), signo); + return tgkill(_SCHED_GETPID(), _SCHED_GETT

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on code in PR #16334: URL: https://github.com/apache/nuttx/pull/16334#discussion_r2078895532 ## libs/libc/signal/sig_raise.c: ## @@ -45,5 +45,5 @@ int raise(int signo) { - return tkill(_SCHED_GETTID(), signo); + return tgkill(_SCHED_GETPID(), _SCHED_GETT

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on code in PR #16334: URL: https://github.com/apache/nuttx/pull/16334#discussion_r2078895532 ## libs/libc/signal/sig_raise.c: ## @@ -45,5 +45,5 @@ int raise(int signo) { - return tkill(_SCHED_GETTID(), signo); + return tgkill(_SCHED_GETPID(), _SCHED_GETT

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
pussuw commented on code in PR #16334: URL: https://github.com/apache/nuttx/pull/16334#discussion_r2078865703 ## libs/libc/signal/sig_raise.c: ## @@ -45,5 +45,5 @@ int raise(int signo) { - return tkill(_SCHED_GETTID(), signo); + return tgkill(_SCHED_GETPID(), _SCHED_GETTID

Re: [I] [BUG] RP2040 Unstability, garbled NSH [nuttx]

2025-05-07 Thread via GitHub
linguini1 commented on issue #16305: URL: https://github.com/apache/nuttx/issues/16305#issuecomment-2861249756 I wonder also if there is anyone with a non-RP2040 board that has USB who can test the shell output for garbling. This would narrow it down to the RP2040 driver or a higher level (

Re: [I] [BUG] RP2040 Unstability, garbled NSH [nuttx]

2025-05-07 Thread via GitHub
linguini1 commented on issue #16305: URL: https://github.com/apache/nuttx/issues/16305#issuecomment-2861232988 I see that @YuuichiNakamura wrote the USB support for the RP2040 in `rp2040_usbdev.c`, maybe they can suggest some possible reasons for this issue to help us narrow down our search

Re: [PR] arch/arm/rp23xx: update USB PLL/VCO/FBDIV [nuttx]

2025-05-07 Thread via GitHub
cederom merged PR #16300: URL: https://github.com/apache/nuttx/pull/16300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated (9fca766bd4 -> 4245db2c47)

2025-05-07 Thread cederom
This is an automated email from the ASF dual-hosted git repository. cederom pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 9fca766bd4 arch/arm/stm32f0l0g0: Add STM32G0 Flash driver. add 4245db2c47 tools/ci/testlist/sim-01.dat: skip buil

Re: [PR] DOCUMENTATION: Migrate README.txt to RST format [nuttx]

2025-05-07 Thread via GitHub
cederom merged PR #16328: URL: https://github.com/apache/nuttx/pull/16328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated (e54d5fffd6 -> 468c9eacd8)

2025-05-07 Thread cederom
This is an automated email from the ASF dual-hosted git repository. cederom pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from e54d5fffd6 arch/arm/rp23xx: add missing fpu init for smp cores add 4a5b0f8e2d misco/lm32/boards/misoc: Migrate RE

Re: [PR] arch/arm/rp23xx: add missing fpu init for smp cores [nuttx]

2025-05-07 Thread via GitHub
acassis merged PR #16330: URL: https://github.com/apache/nuttx/pull/16330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated (7c203a96af -> e54d5fffd6)

2025-05-07 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 7c203a96af arch/arm/rp23xx: update USB PLL/VCO/FBDIV and usb setup add e54d5fffd6 arch/arm/rp23xx: add missing fp

(nuttx) branch master updated (4245db2c47 -> 7c203a96af)

2025-05-07 Thread cederom
This is an automated email from the ASF dual-hosted git repository. cederom pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 4245db2c47 tools/ci/testlist/sim-01.dat: skip build sim:can for macOS add 7c203a96af arch/arm/rp23xx: update USB

Re: [PR] sched: Fix typo on queue.h [nuttx]

2025-05-07 Thread via GitHub
acassis closed pull request #16340: sched: Fix typo on queue.h URL: https://github.com/apache/nuttx/pull/16340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] arch/arm/rp23xx: update USB PLL/VCO/FBDIV [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16300: URL: https://github.com/apache/nuttx/pull/16300#issuecomment-2861032670 Allright the PR processing is now fixed, merging :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] tools/ci/testlist/sim-01.dat: skip build sim:can for macOS [nuttx]

2025-05-07 Thread via GitHub
cederom merged PR #16335: URL: https://github.com/apache/nuttx/pull/16335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] sched: Fix typo on queue.h [nuttx]

2025-05-07 Thread via GitHub
acassis commented on PR #16340: URL: https://github.com/apache/nuttx/pull/16340#issuecomment-2861021208 @hujun260 could you please review? As Serg noticed the issue wasn't evident before because "prev" was defined in other context and used from there. But we don't know it side effect this t

Re: [PR] github: master branch protection tune. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2861008024 Thank you @Humbedooh for help! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] sched: Fix typo on queue.h [nuttx]

2025-05-07 Thread via GitHub
acassis opened a new pull request, #16340: URL: https://github.com/apache/nuttx/pull/16340 ## Summary This typo was in the dq_insert_mid() macro introduced in the https://github.com/apache/nuttx/pull/13616 This issue was found by Serg Podtynnyi ## Impact Fix

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-07 Thread via GitHub
acassis commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2860992196 Fixed! Please @xiaoxiang781216 @jerpelea @cederom @lupyuen review/approve again -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-07 Thread via GitHub
acassis commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2860966755 Aff, I did a mistake, I created a new commit and replaced the old commits. I will send them again -- This is an automated message from the Apache Git Service. To respond to the message,

(nuttx) branch master updated (11d444403e -> 9fca766bd4)

2025-05-07 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 11d03e github: master branch protection tune. add 9fca766bd4 arch/arm/stm32f0l0g0: Add STM32G0 Flash driver.

Re: [PR] arch/arm/stm32f0l0g0: Add STM32G0 Flash driver. [nuttx]

2025-05-07 Thread via GitHub
acassis merged PR #16338: URL: https://github.com/apache/nuttx/pull/16338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] DOCUMENTATION: Migrate READMEs [nuttx]

2025-05-07 Thread via GitHub
linguini1 commented on PR #16339: URL: https://github.com/apache/nuttx/pull/16339#issuecomment-2860923218 Sorry for the many pushes, it seems like the CI build catches more errors than I find when running a local build. Will have to investigate if I missing settings. -- This is an automa

(nuttx-website) branch asf-site updated: Publishing web: 16e1777b863bd27e3a00b7b779baf0131af07df6 docs: 11d444403eb5d16f57c232a23a41019e773623b5

2025-05-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 13ccfa1cd Publishing web: 16e1777

[PR] DOCUMENTATION: Migrate READMEs [nuttx]

2025-05-07 Thread via GitHub
linguini1 opened a new pull request, #16339: URL: https://github.com/apache/nuttx/pull/16339 ## Summary This PR migrates more of the READMEs mentioned in #11077 to RST format. ## Impact Removing legacy README documentation in favour of more readable RST format. Impacts o

(nuttx) branch master updated (358469e5bb -> 11d444403e)

2025-05-07 Thread humbedooh
This is an automated email from the ASF dual-hosted git repository. humbedooh pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 358469e5bb github: Setup protection for master branch. add 11d03e github: master branch protection tune. N

Re: [PR] github: master branch protection tune. [nuttx]

2025-05-07 Thread via GitHub
Humbedooh merged PR #16336: URL: https://github.com/apache/nuttx/pull/16336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.ap

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #16334: URL: https://github.com/apache/nuttx/pull/16334#discussion_r2078653224 ## libs/libc/signal/sig_raise.c: ## @@ -45,5 +45,5 @@ int raise(int signo) { - return tkill(_SCHED_GETTID(), signo); + return tgkill(_SCHED_GETPID(), _SCH

Re: [PR] github: master branch protection tune. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2860088035 Folks please approve this PR so it can be merged ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2860048911 @acassis yes its already updated in https://github.com/apache/nuttx/pull/16336 please approve the PR so it can be merged :-) -- This is an automated message from the Apache Git Service

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
pussuw commented on code in PR #16334: URL: https://github.com/apache/nuttx/pull/16334#discussion_r2078253692 ## libs/libc/signal/sig_raise.c: ## @@ -45,5 +45,5 @@ int raise(int signo) { - return tkill(_SCHED_GETTID(), signo); + return tgkill(_SCHED_GETPID(), _SCHED_GETTID

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
pussuw commented on code in PR #16334: URL: https://github.com/apache/nuttx/pull/16334#discussion_r2078253692 ## libs/libc/signal/sig_raise.c: ## @@ -45,5 +45,5 @@ int raise(int signo) { - return tkill(_SCHED_GETTID(), signo); + return tgkill(_SCHED_GETPID(), _SCHED_GETTID

Re: [PR] github: master branch protection tune. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2859804869 Yes @xiaoxiang781216, @Humbedooh is from Apache Infra Team.. please go ahead and merge this PR :-) As we can see here "contexts" block CI completion, thus we are commenting them ou

Re: [PR] arch/arm/rp23xx: update USB PLL/VCO/FBDIV [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16300: URL: https://github.com/apache/nuttx/pull/16300#issuecomment-2858395472 Sorry for the problems we are updating PR merge rules and in a short window of testing we will update all settings as needed :-) -- This is an automated message from the Apache Git Serv

Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]

2025-05-07 Thread via GitHub
acassis commented on code in PR #16332: URL: https://github.com/apache/nuttx/pull/16332#discussion_r2078196870 ## .codespellrc: ## @@ -47,3 +47,4 @@ ignore-words-list = tolen, UE, WRON, + infor, Review Comment: @tkaratapanis I think you missed the alphabetic order,

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-07 Thread via GitHub
acassis commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2859650450 @cederom maybe it is better to remove this rule after the PR was submitted. So, be in sync with the master (upstream) is important when opening the PR, after that the github will do the r

Re: [PR] github: master branch protection tune. [nuttx]

2025-05-07 Thread via GitHub
Humbedooh commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858927876 Am I correct in understanding that this is blocking your workflow right now and the project needs this PR force-merged? -- This is an automated message from the Apache Git Service. To

Re: [PR] sched/signal: signal dispatch cleanups [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #16333: URL: https://github.com/apache/nuttx/pull/16333#discussion_r2078092232 ## sched/signal/sig_dispatch.c: ## @@ -374,6 +339,76 @@ static FAR sigpendq_t *nxsig_add_pendingsignal(FAR struct tcb_s *stcb, return sigpend; } +/**

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #16323: URL: https://github.com/apache/nuttx/pull/16323#discussion_r2078090071 ## arch/avr/src/avr/Kconfig: ## @@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN endchoice # Toolchain +config AVR_LINUXGCC_TOOLCHAIN_IS_GCC + bool

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #16323: URL: https://github.com/apache/nuttx/pull/16323#discussion_r2078090721 ## arch/avr/src/avr/Kconfig: ## @@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN endchoice # Toolchain +config AVR_LINUXGCC_TOOLCHAIN_IS_GCC + bool

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #16334: URL: https://github.com/apache/nuttx/pull/16334#discussion_r2078074826 ## libs/libc/signal/sig_raise.c: ## @@ -45,5 +45,5 @@ int raise(int signo) { - return tkill(_SCHED_GETTID(), signo); + return tgkill(_SCHED_GETPID(), _SCH

Re: [PR] github: master branch protection tune. [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2859299882 > Am I correct in understanding that this is blocking your workflow right now and the project needs this PR force-merged? @Humbedooh yes, do you have right to merge this pr

Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #16332: URL: https://github.com/apache/nuttx/pull/16332#discussion_r2078063224 ## .codespellrc: ## @@ -47,3 +47,4 @@ ignore-words-list = tolen, UE, WRON, + infor, Review Comment: OK -- This is an automated message from th

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2078061212 ## drivers/misc/optee.c: ## @@ -55,21 +57,87 @@ /* Some GlobalPlatform error codes used in this driver */ #define TEE_SUCCESS0x

Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]

2025-05-07 Thread via GitHub
tkaratapanis commented on PR #16332: URL: https://github.com/apache/nuttx/pull/16332#issuecomment-2858567369 > Hi @tkaratapanis please fix the CMake format and typos: > > ``` > ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/cmake/Toolchain.c

Re: [PR] github: master branch protection tune. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2859113555 > @Humbedooh: Am I correct in understanding that this is blocking your workflow right now and the project needs this PR force-merged? Yes Sir! Unfortunately :-P -- This is an au

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-07 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2077933601 ## drivers/misc/optee.c: ## @@ -55,21 +57,87 @@ /* Some GlobalPlatform error codes used in this driver */ #define TEE_SUCCESS0x +#defin

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2077895877 ## drivers/misc/optee.c: ## @@ -55,21 +57,87 @@ /* Some GlobalPlatform error codes used in this driver */ #define TEE_SUCCESS0x

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-07 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2077908265 ## drivers/misc/optee.c: ## @@ -154,6 +202,245 @@ static bool optee_is_valid_range(FAR const void *va, size_t size) # define optee_is_valid_range(addr, size) (true)

Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #16332: URL: https://github.com/apache/nuttx/pull/16332#discussion_r2077905822 ## .codespellrc: ## @@ -47,3 +47,4 @@ ignore-words-list = tolen, UE, WRON, + infor, Review Comment: why the short isn't info, but infor? -- Th

Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]

2025-05-07 Thread via GitHub
tkaratapanis commented on code in PR #16332: URL: https://github.com/apache/nuttx/pull/16332#discussion_r2077908272 ## .codespellrc: ## @@ -47,3 +47,4 @@ ignore-words-list = tolen, UE, WRON, + infor, Review Comment: It is just to match the NXP reference manual for

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-07 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2077905466 ## drivers/misc/optee.c: ## @@ -55,21 +57,87 @@ /* Some GlobalPlatform error codes used in this driver */ #define TEE_SUCCESS0x +#defin

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2077901273 ## drivers/misc/optee.c: ## @@ -154,6 +202,245 @@ static bool optee_is_valid_range(FAR const void *va, size_t size) # define optee_is_valid_range(addr, size)

Re: [I] [BUG] System crashing when using IPERF after #16231 [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on issue #16337: URL: https://github.com/apache/nuttx/issues/16337#issuecomment-2858986166 @Fix-Point please look at this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] testing/ostest: add checking of signal deliver thread [nuttx-apps]

2025-05-07 Thread via GitHub
jlaitine commented on PR #3070: URL: https://github.com/apache/nuttx-apps/pull/3070#issuecomment-2858861608 I just realized that this may cause unwanted side effects since there was an existing bug in the test; it doesn't unregister the signal action handlers after the test is done.

Re: [PR] arch/arm/rp23xx: update USB PLL/VCO/FBDIV [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16300: URL: https://github.com/apache/nuttx/pull/16300#issuecomment-2858731271 > @acassis: @cederom what does it mean "Waiting for status to be reported" ? Sorry this is unrelated to this patch, comes from asf.yaml update we are fixing right now :-) -- This

Re: [PR] github: master branch protection tune. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858714562 Allright I commented out whole "contexts" section, as noted by @simbit18 it causes CI hangs, and @raiden00pl it may cause problems with nuttx and nuttx-apps updates. -- This is an auto

Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]

2025-05-07 Thread via GitHub
acassis commented on PR #16332: URL: https://github.com/apache/nuttx/pull/16332#issuecomment-2858707197 @tkaratapanis yes, the codespell will verify all issues existing in any life you modify. Same apply to code style. Case there is some life in the mainline that never passed by the nxstyle

Re: [I] Actions list to improve NuttX quality and reliability [nuttx]

2025-05-07 Thread via GitHub
acassis commented on issue #16278: URL: https://github.com/apache/nuttx/issues/16278#issuecomment-2858669971 Hi @Jasinsky thank you very much for that link! Yes the idea is similar to that one, but in their case the mainboard just come with connector that user could plug many MicroBUS

Re: [PR] arch/arm/rp23xx: update USB PLL/VCO/FBDIV [nuttx]

2025-05-07 Thread via GitHub
acassis commented on PR #16300: URL: https://github.com/apache/nuttx/pull/16300#issuecomment-2858575044 @cederom what does it mean "Waiting for status to be reported" ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[PR] arch/arm/stm32f0l0g0: Add STM32G0 Flash driver. [nuttx]

2025-05-07 Thread via GitHub
stbenn opened a new pull request, #16338: URL: https://github.com/apache/nuttx/pull/16338 Add arch files and Kconfig options to interface with the progmem driver on STM32G0 MCUs. ## Summary This PR adds the ability to program and erase blocks of flash memory using the progmem

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on PR #16334: URL: https://github.com/apache/nuttx/pull/16334#issuecomment-2858578108 Hm. I need to still work on this later, it is not ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] github: master branch protection tune. [nuttx]

2025-05-07 Thread via GitHub
simbit18 commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858573966 @cederom I am not very convinced about this check ``` protected_branches: master: required_status_checks: strict: false contexts: - Check

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on PR #16334: URL: https://github.com/apache/nuttx/pull/16334#issuecomment-2858527710 Rebased and pushed to start CI again... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] github: master branch protection tune. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858526938 > @shtirlic: It's also interesting that I have my commits GPG verified in my pull branch, but they appear as unverified after the merge. We are in short window of testing and tunin

Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]

2025-05-07 Thread via GitHub
acassis commented on PR #16332: URL: https://github.com/apache/nuttx/pull/16332#issuecomment-2858504952 Hi @tkaratapanis please fix the CMake format and typos: ``` ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/cmake/Toolchain.cmake c

Re: [PR] Support LLVM linked ELF RISC-V executable [nuttx]

2025-05-07 Thread via GitHub
acassis commented on PR #13197: URL: https://github.com/apache/nuttx/pull/13197#issuecomment-2858453119 Hi @metarutaiga, nice to see you working on it again. Please note that now all commits need to be signed (git commit -S) -- This is an automated message from the Apache Git Servic

Re: [PR] boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-07 Thread via GitHub
TimJTi commented on PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#issuecomment-2858273438 Found a couple message enum inconsistencies so I'm sorting those out and put back to draft while I do so -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-07 Thread via GitHub
acassis commented on code in PR #16323: URL: https://github.com/apache/nuttx/pull/16323#discussion_r2077566675 ## arch/avr/src/avr/Kconfig: ## @@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN endchoice # Toolchain +config AVR_LINUXGCC_TOOLCHAIN_IS_GCC + bool "Mark th

Re: [PR] Support LLVM linked ELF RISC-V executable [nuttx]

2025-05-07 Thread via GitHub
acassis commented on code in PR #13197: URL: https://github.com/apache/nuttx/pull/13197#discussion_r2077556351 ## libs/libc/machine/risc-v/arch_elf.c: ## @@ -104,6 +104,19 @@ static const char *_get_rname(int type) return "?"; } +/**

Re: [PR] github: master branch protection tune. [nuttx]

2025-05-07 Thread via GitHub
shtirlic commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858466914 It's also interesting that I have my commits GPG verified in my pull branch, but they appear as unverified after the merge. -- This is an automated message from the Apache Git Ser

[I] [BUG] System crashing when using IPERF after #16231 [nuttx]

2025-05-07 Thread via GitHub
fdcavalcanti opened a new issue, #16337: URL: https://github.com/apache/nuttx/issues/16337 ### Description / Steps to reproduce the issue Hi all, The performance tests using IPERF are failing after the PR #16231. This can be easily replicated using the `sta_softap` defconfig on

Re: [PR] testing/ostest: add checking of signal deliver thread [nuttx-apps]

2025-05-07 Thread via GitHub
jlaitine commented on PR #3070: URL: https://github.com/apache/nuttx-apps/pull/3070#issuecomment-2858460518 This fails on ostest, which is expected due to the bug that this change is supposed to expose. Need to re-trigger this after https://github.com/apache/nuttx/pull/16334 is prop

Re: [PR] sched/signal: signal dispatch cleanups [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on PR #16333: URL: https://github.com/apache/nuttx/pull/16333#issuecomment-2858444015 No changes, just rebase to master to trigger CI again, it failed to something not related to this PR -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] sched/signal: Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on PR #16334: URL: https://github.com/apache/nuttx/pull/16334#issuecomment-2858411760 Oops. Looks like, sig_tgkill doesn't handle sending to group/thread and also "raise" only sends to a single thread (using tkill). So now this didn't pass the sim:citest 's conformance te

Re: [PR] sched/queue: fix typo in dq_insert_mid macro [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16329: URL: https://github.com/apache/nuttx/pull/16329#issuecomment-2858389061 > @xiaoxiang781216: @cederom do you know why Build/Check run indefinitely now? Hmm, there are some build warnings: https://github.com/apache/nuttx/actions/runs/14874286379

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-07 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2077496878 ## drivers/misc/optee.c: ## @@ -154,6 +202,245 @@ static bool optee_is_valid_range(FAR const void *va, size_t size) # define optee_is_valid_range(addr, size) (true)

[PR] github: Turn off strict master branch protection. [nuttx]

2025-05-07 Thread via GitHub
cederom opened a new pull request, #16336: URL: https://github.com/apache/nuttx/pull/16336 ## Summary * Strict master branch protection requires all PR to be in sync with latest master even if changes are not related and there are no conflicts. * Because we have lots of daily merge

Re: [PR] testing/ostest: add checking of signal deliver thread [nuttx-apps]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #3070: URL: https://github.com/apache/nuttx-apps/pull/3070#discussion_r2077487365 ## testing/ostest/signest.c: ## @@ -52,6 +52,8 @@ * Private Data / +static

Re: [PR] DOCUMENTATION: Migrate README.txt to RST format [nuttx]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on PR #16328: URL: https://github.com/apache/nuttx/pull/16328#issuecomment-2858344512 > Thank you @linguini1 :-) @cederom do you know why the ci stuck? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] examples/posix_stdio: Adding posix stdio example for new joiners. [nuttx-apps]

2025-05-07 Thread via GitHub
xiaoxiang781216 merged PR #3065: URL: https://github.com/apache/nuttx-apps/pull/3065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(nuttx-apps) branch master updated: examples/posix_stdio: New example dedicated to posix stdio library.

2025-05-07 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 77b2e8dfe examples/posix_stdio: New examp

Re: [PR] github: Turn off strict master branch protection. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858281760 > @pussuw: Btw what is the motivation to enforce that commits are signed off ? I never understood this, can someone provide the answer (I never commit -s, but since you insist on it I mad

Re: [PR] github: Turn off strict master branch protection. [nuttx]

2025-05-07 Thread via GitHub
pussuw commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858266369 Btw what is the motivation to enforce that commits are signed off ? I never understood this, can someone provide the answer (I never commit -s, but since you insist on it I made a commit h

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2858252790 Another problem I can see is "Commits must have verified signatures.". Looks like we need to update `required_signatures: false` too as signature in github nomenclature means cryptograph

Re: [PR] testing/ostest: add checking of signal deliver thread [nuttx-apps]

2025-05-07 Thread via GitHub
jlaitine commented on PR #3070: URL: https://github.com/apache/nuttx-apps/pull/3070#issuecomment-2858122594 > please add a commit message Oops, thanks for reminding, done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] [HELP] Please explain the esp32 wlan driver working which cause the following issue on cpu0 [nuttx]

2025-05-07 Thread via GitHub
fdcavalcanti commented on issue #16269: URL: https://github.com/apache/nuttx/issues/16269#issuecomment-2858242907 Yes I understand it is the same chip, I tried your exact defconfig and could not replicate on mine. I noticed you are using USB Serial, did you change that when you sent the

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2858241271 You are right @raiden00pl with this `strict: true` all PR needs to be rebased each time master is updated that is a waste of focus and CI resources, sorry, the nomenclature is a bit misle

Re: [PR] tools/ci/testlist/sim-01.dat: skip build sim:can for macOS [nuttx]

2025-05-07 Thread via GitHub
simbit18 commented on PR #16335: URL: https://github.com/apache/nuttx/pull/16335#issuecomment-2858193244 Hi @cederom I opened an issue here https://github.com/apache/nuttx/issues/16317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] tools/ci/testlist/sim-01.dat: skip build sim:can for macOS [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16335: URL: https://github.com/apache/nuttx/pull/16335#issuecomment-2858173074 Thank you @simbit18 :-) Maybe the build scripts should return warning that sim:can does not work on macOS so users can see that too? :-) -- This is an automated message from the Apache

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2858163302 > @raiden00pl: dependency on `Build` seems bad to me. With this change it becomes impossible to merge changes where `nuttx` and `nuttx-apps` need to be changed at the same time. >

Re: [PR] Fix signal delivered to a wrong thread [nuttx]

2025-05-07 Thread via GitHub
jlaitine commented on PR #16334: URL: https://github.com/apache/nuttx/pull/16334#issuecomment-2857830517 Pushing again for spell checker complaints -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

  1   2   >