tkaratapanis commented on PR #16332: URL: https://github.com/apache/nuttx/pull/16332#issuecomment-2858567369
> Hi @tkaratapanis please fix the CMake format and typos: > > ``` > ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/cmake/Toolchain.cmake > > cmake-format check failed, run following command to update the style: > $ cmake-format <src> -o <dst> > > ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/cmake/Toolchain.cmake > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:67: implemet ==> implement > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:68: booloader ==> bootloader > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:842: mumber ==> number > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_ele.h:129: envents ==> events, invents > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_ele.h:146: envents ==> events, invents > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_romapi.c:78: infor ==> info, inform, in for > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_romapi.c:83: infor ==> info, inform, in for > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_romapi.c:84: infor ==> info, inform, in for > `` > ``` The spellchecker seems to check the whole file and not my changes. Additionally the imx9_romapi checks happen to the parameters i.e: `line 78: uint32_t imx9_romapi_query_boot_infor(uint32_t infor_type, uint32_t *infor)` I used the same convention as chosen by NXP:  The rest of the changes are not introduced by me: > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:67: implemet ==> implement > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:68: booloader ==> bootloader > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:842: mumber ==> number > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_ele.h:129: envents ==> events, invents > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_ele.h:146: envents ==> events, invents Should I create a new commit just for spellchecks to pass this PR? In general I don't like to mix my PR with unrelated spellchecks but if the workflow works like this, I will do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
