jlaitine commented on code in PR #16334:
URL: https://github.com/apache/nuttx/pull/16334#discussion_r2078895532


##########
libs/libc/signal/sig_raise.c:
##########
@@ -45,5 +45,5 @@
 
 int raise(int signo)
 {
-  return tkill(_SCHED_GETTID(), signo);
+  return tgkill(_SCHED_GETPID(), _SCHED_GETTID(), signo);

Review Comment:
   Or change the interface of tgkill, I don't see any use for PID in there. It 
should be enough to pass any TID and just a boolean of whether the signal is to 
be delivered to whole group or specifically to the TID.
   
   I don't even understand why the (linux) tkill and tgkill have been added to 
NuttX, this is completely redundant to sig_kill and nxsig_kill, only that 
sig_kill would have needed the group/thread information as well.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to