Re: [PR] wqueue: improve the robustness of the work [nuttx]

2025-05-02 Thread via GitHub
xiaoxiang781216 commented on PR #16283: URL: https://github.com/apache/nuttx/pull/16283#issuecomment-2848417920 But, this problem is fixed by https://github.com/apache/nuttx/pull/16231 too, so let's review and merge that patch instead. -- This is an automated message from the Apache Git S

Re: [PR] arch/x86_64: add debug interface [nuttx]

2025-05-02 Thread via GitHub
xiaoxiang781216 commented on PR #16287: URL: https://github.com/apache/nuttx/pull/16287#issuecomment-2848416358 > @acassis USB EHCI is archaic peripheral :) something similar is available on XHCI, but it's much more complicated than simple gdbstub over serial port. Maybe someday @yan

Re: [PR] CI: enable codespell [nuttx]

2025-05-02 Thread via GitHub
sumpfralle commented on code in PR #16302: URL: https://github.com/apache/nuttx/pull/16302#discussion_r2072313329 ## .github/workflows/check.yml: ## @@ -41,9 +41,11 @@ jobs: echo "::add-matcher::nuttx/.github/nxstyle.json" python3 -m venv .venv s

(nuttx) branch master updated (7ea8b59a59 -> 7e99c9582b)

2025-05-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 7ea8b59a59 boards/imx93-evk: kernel build for AHAB boot new 76e1b80076 arch/sim: add CAN support based on host

(nuttx) 02/02: boards/sim: add CAN support and configuration

2025-05-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 7e99c9582bc2ea7269348f1fee1f49f6ad48d1dc Author: p-szafonimateusz AuthorDate: Thu Mar 13 12:57:34 2025 +0100 boar

(nuttx) 01/02: arch/sim: add CAN support based on host SocketCAN

2025-05-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 76e1b8007612b38850fd6885766e76a3022e9f45 Author: p-szafonimateusz AuthorDate: Wed Mar 12 10:15:11 2025 +0100 arch

Re: [PR] add CAN interface support for arch/sim [nuttx]

2025-05-02 Thread via GitHub
xiaoxiang781216 merged PR #16285: URL: https://github.com/apache/nuttx/pull/16285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: boards/imx93-evk: kernel build for AHAB boot

2025-05-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 7ea8b59a59 boards/imx93-evk: kernel build for

Re: [PR] boards/imx93-evk: kernel build for AHAB boot [nuttx]

2025-05-02 Thread via GitHub
xiaoxiang781216 merged PR #16298: URL: https://github.com/apache/nuttx/pull/16298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] CI: enable codespell [nuttx]

2025-05-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #16302: URL: https://github.com/apache/nuttx/pull/16302#discussion_r2072302545 ## .github/workflows/check.yml: ## @@ -41,9 +41,11 @@ jobs: echo "::add-matcher::nuttx/.github/nxstyle.json" python3 -m venv .venv

(nuttx) branch master updated (eeb4a0de83 -> 464c0831ce)

2025-05-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from eeb4a0de83 setlogmask: fix setlogmask behavior according to POSIX standard add 464c0831ce arch/arm/rp23xx: fix

Re: [PR] arch/arm/rp23xx: fix not restart after TX error [nuttx]

2025-05-02 Thread via GitHub
xiaoxiang781216 merged PR #16304: URL: https://github.com/apache/nuttx/pull/16304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] SAMA5 Add code to report the reset reason [nuttx]

2025-05-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #16303: URL: https://github.com/apache/nuttx/pull/16303#discussion_r2072301214 ## arch/arm/src/sama5/sam_systemreset.c: ## @@ -35,13 +35,63 @@ #include "arm_internal.h" #include "hardware/sam_rstc.h" +#include "sam_systemreset.h" #i

(nuttx-apps) branch master updated: testing/ostest/signest: Replace kill with pthread_kill to fix running in SMP

2025-05-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new a011cad58 testing/ostest/signest: Replace

Re: [PR] testing/ostest/signest: Replace kill with pthread_kill to fix running in SMP [nuttx-apps]

2025-05-02 Thread via GitHub
xiaoxiang781216 merged PR #3067: URL: https://github.com/apache/nuttx-apps/pull/3067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [I] [BUG] esp32: cannot create fatfs on /dev/mtdblock0 [nuttx]

2025-05-02 Thread via GitHub
xiaoxiang781216 commented on issue #16245: URL: https://github.com/apache/nuttx/issues/16245#issuecomment-2848390976 If you really want to use fatfs on mtd, you need enable https://github.com/apache/nuttx/blob/master/drivers/mtd/dhara.c. -- This is an automated message from the Apache Git

(nuttx-website) branch asf-site updated: Publishing web: 16e1777b863bd27e3a00b7b779baf0131af07df6 docs: eeb4a0de83951719b1f67df6e2c631d759869716

2025-05-02 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new c12f4658d Publishing web: 16e1777

Re: [I] [BUG] esp32: cannot create fatfs on /dev/mtdblock0 [nuttx]

2025-05-02 Thread via GitHub
Laczen commented on issue #16245: URL: https://github.com/apache/nuttx/issues/16245#issuecomment-2847735635 @abisop thanks for the reply. While I understand that it is not ideal to use fatfs as a read/write FS on MTD flash there are situations where it is advantageous to use it. It is

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
keever50 commented on PR #16301: URL: https://github.com/apache/nuttx/pull/16301#issuecomment-2847583112 ostest passed for me on STM32H743 based board with custom configuration. Shows that the RP23xx is really looking bad right now. -- This is an automated message from the Apache Gi

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on PR #16301: URL: https://github.com/apache/nuttx/pull/16301#issuecomment-2847558507 Ok, thanks. I have no Idea; I need to gather more data from other platforms, but I have acess to more HW next time on Monday. If this PR broke things more, and it is urgent to fix,

[I] [BUG] RP2040 Unstability, garbled NSH [nuttx]

2025-05-02 Thread via GitHub
keever50 opened a new issue, #16305: URL: https://github.com/apache/nuttx/issues/16305 ### Description / Steps to reproduce the issue This is a corrected continuation of https://github.com/apache/nuttx/issues/16139 And also happening on the nuttx-app side https://github.com/apache

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
shtirlic commented on PR #16301: URL: https://github.com/apache/nuttx/pull/16301#issuecomment-2847504189 @jlaitine checked with https://github.com/apache/nuttx-apps/pull/3067 for apps, still usage fault -- This is an automated message from the Apache Git Service. To respond to the message

Re: [I] [BUG] `nsh_catfile` is writing too fast to the nsh console (garbled output) [nuttx-apps]

2025-05-02 Thread via GitHub
keever50 commented on issue #3063: URL: https://github.com/apache/nuttx-apps/issues/3063#issuecomment-2847478451 Hey, this looks like a common nuttx RP2040 problem that is still on-going. I have the same issues even when running 'help'. If you hold enter, does it sometimes print 'K' or '[

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on PR #16301: URL: https://github.com/apache/nuttx/pull/16301#issuecomment-2847445970 *sigh*. Does the PR for apps make any difference? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Adding a single example for new joiners [nuttx-apps]

2025-05-02 Thread via GitHub
vrmay23 commented on PR #3065: URL: https://github.com/apache/nuttx-apps/pull/3065#issuecomment-2847418849 @cederom alright. I'll do it right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
keever50 commented on PR #16301: URL: https://github.com/apache/nuttx/pull/16301#issuecomment-2847373559 > [ 113.52] [ ALERT] ostest: dump_task: 5 5 100 RR Task - Waiting Signal 0x20015d08 2016 1956 97.0%! 0.0% nsh Loo

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
shtirlic commented on PR #16301: URL: https://github.com/apache/nuttx/pull/16301#issuecomment-2847357863 @jlaitine oops, without SMP on rp2350 ``` user_main: signal handler test sighand_test: Initializing semaphore to 0 sighand_test: Unmasking SIGCHLD sighand_test: Register

(nuttx) branch master updated: setlogmask: fix setlogmask behavior according to POSIX standard

2025-05-02 Thread cederom
This is an automated email from the ASF dual-hosted git repository. cederom pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new eeb4a0de83 setlogmask: fix setlogmask behavior a

Re: [PR] [BREAKING] setlogmask: fix setlogmask behavior according to POSIX standard [nuttx]

2025-05-02 Thread via GitHub
cederom merged PR #16280: URL: https://github.com/apache/nuttx/pull/16280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] apps/boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-02 Thread via GitHub
nuttxpr commented on PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#issuecomment-2847343712 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR description is a good start but could be imp

[PR] apps/boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-02 Thread via GitHub
TimJTi opened a new pull request, #3068: URL: https://github.com/apache/nuttx-apps/pull/3068 ## Summary This PR has been drafted after email-list discussions mainly with with @Cynerd and @michallenc I will leave it as a draft awaiting any initial observations from interested p

[PR] arch/arm/rp23xx: fix not restart after TX error [nuttx]

2025-05-02 Thread via GitHub
shtirlic opened a new pull request, #16304: URL: https://github.com/apache/nuttx/pull/16304 ## Summary Fix a bug that I2C driver can not transfer after TX abort error. It caused by remaining NO_STOP flag status. same as done in commit 0df0a10 for cxd56xx ## Impact Wor

Re: [I] [BUG] esp32: cannot create fatfs on /dev/mtdblock0 [nuttx]

2025-05-02 Thread via GitHub
abisop commented on issue #16245: URL: https://github.com/apache/nuttx/issues/16245#issuecomment-2847269775 @Laczen FAT FS is not supposed to be used with mtd flash. you should go with SmartFS, SPIFFS,... -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] boards/stm32f0l0g0: Add Nucleo G0B1RE support. [nuttx]

2025-05-02 Thread via GitHub
stbenn commented on PR #16293: URL: https://github.com/apache/nuttx/pull/16293#issuecomment-2847263236 Log from ostest run on d26d8f9 [ostest_log2.log](https://github.com/user-attachments/files/20013697/ostest_log2.log) -- This is an automated message from the Apache Git Service. To r

Re: [PR] boards/stm32f0l0g0: Add Nucleo G0B1RE support. [nuttx]

2025-05-02 Thread via GitHub
stbenn commented on code in PR #16293: URL: https://github.com/apache/nuttx/pull/16293#discussion_r2071640761 ## Documentation/platforms/arm/stm32g0/boards/nucleo-g0b1re/index.rst: ## @@ -0,0 +1,5 @@ + +ST Nucleo G0B1RE + + +The Nucleo G0B1RE is a

Re: [PR] boards/stm32f0l0g0: Add Nucleo G0B1RE support. [nuttx]

2025-05-02 Thread via GitHub
stbenn commented on code in PR #16293: URL: https://github.com/apache/nuttx/pull/16293#discussion_r2071639028 ## arch/arm/src/stm32f0l0g0/stm32_crypto.c: ## @@ -79,7 +79,7 @@ static int stm32_newsession(uint32_t *sid, struct cryptoini *cri) *sid = g_stm32_sesnum++;

Re: [PR] boards/stm32f0l0g0: Add Nucleo G0B1RE support. [nuttx]

2025-05-02 Thread via GitHub
stbenn commented on code in PR #16293: URL: https://github.com/apache/nuttx/pull/16293#discussion_r2071638737 ## boards/Kconfig: ## @@ -3552,6 +3562,7 @@ config ARCH_BOARD default "stm32g071b-disco" if ARCH_BOARD_STM32G071B_DISCO default "nucleo-g070rb"

Re: [PR] SAMA5 Add code to report the reset reason [nuttx]

2025-05-02 Thread via GitHub
nuttxpr commented on PR #16303: URL: https://github.com/apache/nuttx/pull/16303#issuecomment-2847202403 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the basic NuttX requiremen

Re: [PR] RP2040: Allow simultaneous selection of multiple interrupt modes [nuttx]

2025-05-02 Thread via GitHub
keever50 commented on PR #16281: URL: https://github.com/apache/nuttx/pull/16281#issuecomment-2847198409 > > is it possible that the GPIO driver is a requirement and the RP2040 GPIO interrupts are depended on that? Because I dont get dependency warnings > > No, the GPIO functions (rp2

Re: [I] [FEATURE] STM32H5 DMA Driver [nuttx]

2025-05-02 Thread via GitHub
stbenn commented on issue #16248: URL: https://github.com/apache/nuttx/issues/16248#issuecomment-2847183457 @raiden00pl and @acassis, I have made some decent progress and will _hopefully_ be creating a PR for this in the next week. In the meantime, I have a question regarding the PR.

[PR] SAMA5 Add code to report the reset reason [nuttx]

2025-05-02 Thread via GitHub
TimJTi opened a new pull request, #16303: URL: https://github.com/apache/nuttx/pull/16303 ## Summary This adds the necessary code and function to allow a board to determine the reason for a reset. This is useful in NXboot, for example. ## Impact This function has not exi

Re: [PR] RP2040: Allow simultaneous selection of multiple interrupt modes [nuttx]

2025-05-02 Thread via GitHub
linguini1 commented on PR #16281: URL: https://github.com/apache/nuttx/pull/16281#issuecomment-2847171477 > is it possible that the GPIO driver is a requirement and the RP2040 GPIO interrupts are depended on that? Because I dont get dependency warnings No, the GPIO functions (rp2040_*

(nuttx) branch master updated (9e8197ad49 -> c84f7c630f)

2025-05-02 Thread raiden00
This is an automated email from the ASF dual-hosted git repository. raiden00 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 9e8197ad49 boards/risc-v: add MPU60x0 bringup support to ESP32C6 add c84f7c630f arch/stm32f0l0g0: Add support fo

Re: [PR] arch/stm32f0l0g0: Add support for STM32G0B1xx [nuttx]

2025-05-02 Thread via GitHub
raiden00pl merged PR #16296: URL: https://github.com/apache/nuttx/pull/16296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] arch/stm32f0l0g0: Add support for STM32G0B1xx [nuttx]

2025-05-02 Thread via GitHub
raiden00pl commented on PR #16296: URL: https://github.com/apache/nuttx/pull/16296#issuecomment-2847150196 @stbenn it doesn't matter. This PR is ready to be merged, so let's merge it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] arch/stm32f0l0g0: Add support for STM32G0B1xx [nuttx]

2025-05-02 Thread via GitHub
stbenn commented on PR #16296: URL: https://github.com/apache/nuttx/pull/16296#issuecomment-2847141549 @raiden00pl, would you prefer I close this PR and update #16293 with two commits or keep this one open and just learn for the future? -- This is an automated message from the Apache Git

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2847119201 > > > > since the current code base never add const to the local integer variables even they doesn't change after initialization. > > > > > > > > > Why not? I'll change this if

(nuttx) branch master updated: boards/risc-v: add MPU60x0 bringup support to ESP32C6

2025-05-02 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9e8197ad49 boards/risc-v: add MPU60x0 bringup su

Re: [PR] boards/risc-v: add MPU60x0 bringup support to ESP32C6 [nuttx]

2025-05-02 Thread via GitHub
acassis merged PR #16294: URL: https://github.com/apache/nuttx/pull/16294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) 02/02: boards/arm: refresh defconfig for common board

2025-05-02 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 3c5580e693f7ece1033440e281b33d262cfbf66c Author: Serg Podtynnyi AuthorDate: Wed Apr 30 16:28:19 2025 +0700 boards/a

(nuttx) 01/02: tools: Update Unix.mk and savedefconfig.cmake for CONFIG_ARCH_BOARD_COMMON

2025-05-02 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 4c52f2dbeb425509c2b80a804523455c0da2ff60 Author: Serg Podtynnyi AuthorDate: Wed Apr 30 16:22:05 2025 +0700 tools: U

(nuttx) branch master updated (cfab00817a -> 3c5580e693)

2025-05-02 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from cfab00817a fs/procfs: Improve subdirectory recognition new 4c52f2dbeb tools: Update Unix.mk and savedefconfig.cma

Re: [PR] tools: Update Unix.mk for CONFIG_ARCH_BOARD_COMMON [nuttx]

2025-05-02 Thread via GitHub
acassis merged PR #16241: URL: https://github.com/apache/nuttx/pull/16241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated (43b29a0547 -> cfab00817a)

2025-05-02 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 43b29a0547 Fixed empty line handling process_config.sh add cfab00817a fs/procfs: Improve subdirectory recognition

Re: [I] [BUG] procfs: "cd /proc/n" succeeds [nuttx]

2025-05-02 Thread via GitHub
acassis closed issue #16237: [BUG] procfs: "cd /proc/n" succeeds URL: https://github.com/apache/nuttx/issues/16237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] fs/procfs: Improve subdirectory recognition [nuttx]

2025-05-02 Thread via GitHub
acassis merged PR #16295: URL: https://github.com/apache/nuttx/pull/16295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated (2b513af2c3 -> 43b29a0547)

2025-05-02 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 2b513af2c3 sched/signal/sig_dispatch: Fix race conditions between nxsig_tcbdispatch and nxsig_deliver add 43b29a

Re: [PR] Fixed empty line handling process_config.sh [nuttx]

2025-05-02 Thread via GitHub
acassis merged PR #16297: URL: https://github.com/apache/nuttx/pull/16297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] CI: enable codespell [nuttx]

2025-05-02 Thread via GitHub
nuttxpr commented on PR #16302: URL: https://github.com/apache/nuttx/pull/16302#issuecomment-2847082440 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
acassis merged PR #16301: URL: https://github.com/apache/nuttx/pull/16301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated: sched/signal/sig_dispatch: Fix race conditions between nxsig_tcbdispatch and nxsig_deliver

2025-05-02 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2b513af2c3 sched/signal/sig_dispatch: Fix race c

[PR] CI: enable codespell [nuttx]

2025-05-02 Thread via GitHub
sumpfralle opened a new pull request, #16302: URL: https://github.com/apache/nuttx/pull/16302 ## Summary These commits add a `.codespellrc` configuration file with suitable defaults and comments for all relevant use-cases in nuttx. Additionally the github workflow "check" is ex

Re: [PR] tools: Update Unix.mk for CONFIG_ARCH_BOARD_COMMON [nuttx]

2025-05-02 Thread via GitHub
jerpelea commented on PR #16241: URL: https://github.com/apache/nuttx/pull/16241#issuecomment-2846990525 > @shtirlic The error displayed in the Linux job (arm-13) appears to be resolved. > > ``` >

Re: [PR] Fixed empty line handling process_config.sh [nuttx]

2025-05-02 Thread via GitHub
jerpelea commented on PR #16297: URL: https://github.com/apache/nuttx/pull/16297#issuecomment-2846988396 > @acassis @lupyuen @xiaoxiang781216 @cederom Can you restart the msys2 job ? restarted -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on PR #16301: URL: https://github.com/apache/nuttx/pull/16301#issuecomment-2846964976 Forgot to mention; another race condition which I encountered, and is fixed by this same is the management of task_state; Signal dispatching thread t1, thread to which signal is di

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
keever50 commented on PR #16301: URL: https://github.com/apache/nuttx/pull/16301#issuecomment-2846955378 nice! _Might_ be related to https://github.com/apache/nuttx/issues/16139 and https://github.com/apache/nuttx/issues/16133 (more likely) as well. I hope this will fix so

Re: [PR] Fixed empty line handling process_config.sh [nuttx]

2025-05-02 Thread via GitHub
simbit18 commented on PR #16297: URL: https://github.com/apache/nuttx/pull/16297#issuecomment-2846886997 @acassis @lupyuen @xiaoxiang781216 Can you restart the msys2 job ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] tools: Update Unix.mk for CONFIG_ARCH_BOARD_COMMON [nuttx]

2025-05-02 Thread via GitHub
simbit18 commented on PR #16241: URL: https://github.com/apache/nuttx/pull/16241#issuecomment-2846882131 @shtirlic The error displayed in the Linux job (arm-13) appears to be resolved. ``` Conf

Re: [PR] RP2040: Allow simultaneous selection of multiple interrupt modes [nuttx]

2025-05-02 Thread via GitHub
keever50 commented on PR #16281: URL: https://github.com/apache/nuttx/pull/16281#issuecomment-2846851420 is it possible that the GPIO driver is a requirement and the RP2040 GPIO interrupts are depended on that? Because I dont get dependency warnings -- This is an automated message from th

Re: [PR] arch/arm/rp23xx: update USB PLL/VCO/FBDIV [nuttx]

2025-05-02 Thread via GitHub
shtirlic commented on PR #16300: URL: https://github.com/apache/nuttx/pull/16300#issuecomment-2846824506 @keever50 I am in the process of reviewing all peripherals code for rp2350 and found some of them are broken from the start due to some changes, see my pwm and watchdog current pull -

Re: [PR] arch/arm/rp23xx: update USB PLL/VCO/FBDIV [nuttx]

2025-05-02 Thread via GitHub
shtirlic commented on PR #16300: URL: https://github.com/apache/nuttx/pull/16300#issuecomment-2846818052 @keever50 in pico-sdk they use the same config for USB pll for rp2040 and 2350, so you could try to change it, even set it higher for tests. -- This is an automated message from the A

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on PR #16301: URL: https://github.com/apache/nuttx/pull/16301#issuecomment-2846813093 Made a small change in commit text and re-pushed, it looked like CI just failed to some random cause -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] arch/arm/rp23xx: update USB PLL/VCO/FBDIV [nuttx]

2025-05-02 Thread via GitHub
keever50 commented on PR #16300: URL: https://github.com/apache/nuttx/pull/16300#issuecomment-2846748617 @shtirlic Interesting! Good catch. Ill look into this later. Have you confirmed this yourself as well? Do you think instability can cause USB to drop out or system hangs? Yest

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2846715665 Fixed one style review comment which I missed before ( change of dq_peek() != NULL -> !dq_empty() ) -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2071315661 ## sched/semaphore/sem_wait.c: ## @@ -86,19 +89,62 @@ int nxsem_wait_slow(FAR sem_t *sem) /* Check if the lock is available */ - if (atomic_fetch_sub(NXSEM_COU

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2071315094 ## sched/semaphore/sem_reset.c: ## @@ -76,38 +81,65 @@ int nxsem_reset(FAR sem_t *sem, int16_t count) flags = enter_critical_section(); - /* A negative count i

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2071312619 ## sched/semaphore/sem_wait.c: ## @@ -86,19 +89,62 @@ int nxsem_wait_slow(FAR sem_t *sem) /* Check if the lock is available */ - if (atomic_fetch_sub(NXSEM_COU

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2071312619 ## sched/semaphore/sem_wait.c: ## @@ -86,19 +89,62 @@ int nxsem_wait_slow(FAR sem_t *sem) /* Check if the lock is available */ - if (atomic_fetch_sub(NXSEM_COU

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2071307167 ## sched/semaphore/sem_trywait.c: ## @@ -74,29 +77,57 @@ int nxsem_trywait_slow(FAR sem_t *sem) /* If the semaphore is available, give it to the requesting task *

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2071307942 ## sched/semaphore/sem_wait.c: ## @@ -71,9 +71,12 @@ int nxsem_wait_slow(FAR sem_t *sem) { - FAR struct tcb_s *rtcb; + FAR struct tcb_s *rtcb = this_task(); i

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2071291015 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_I

Re: [I] [BUG] esp32-devkitc:smp fails on ostest after #16030 [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on issue #16193: URL: https://github.com/apache/nuttx/issues/16193#issuecomment-2846647943 Hi, trying to get around the race conditions between signal dispatching and delivery in smp in https://github.com/apache/nuttx/pull/16301 Could you check, if the PR works on y

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
jlaitine commented on PR #16301: URL: https://github.com/apache/nuttx/pull/16301#issuecomment-2846643620 Might be related to https://github.com/apache/nuttx/issues/16193 as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] testing/ostest/signest: Replace kill with pthread_kill to fix running in SMP [nuttx-apps]

2025-05-02 Thread via GitHub
jlaitine commented on PR #3067: URL: https://github.com/apache/nuttx-apps/pull/3067#issuecomment-2846641042 Related issue: https://github.com/apache/nuttx/issues/15059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
nuttxpr commented on PR #16301: URL: https://github.com/apache/nuttx/pull/16301#issuecomment-2846642476 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] sched/signal/sig_dispatch: Fix a race condition between nxsig_tcbdispatch and nxsig_deliver [nuttx]

2025-05-02 Thread via GitHub
jlaitine opened a new pull request, #16301: URL: https://github.com/apache/nuttx/pull/16301 ## Summary A race in managing tcb->sigprocmask may cause signal not being delivered at all. The mechanism is as follows: 1. cpu 1: nxsig_deliver adds the signal to the sigprocmask fo

Re: [PR] testing/ostest/signest: Replace kill with pthread_kill to fix running in SMP [nuttx-apps]

2025-05-02 Thread via GitHub
nuttxpr commented on PR #3067: URL: https://github.com/apache/nuttx-apps/pull/3067#issuecomment-2846628744 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements.

[PR] testing/ostest/signest: Replace kill with pthread_kill to fix running in SMP [nuttx-apps]

2025-05-02 Thread via GitHub
jlaitine opened a new pull request, #3067: URL: https://github.com/apache/nuttx-apps/pull/3067 ## Summary "kill" sends the signal to all the the threads in the group. The intention of the test is to send signals only to the "waiter" thread. I believe this test has been brok

Re: [PR] arch/arm/rp23xx: update USB PLL/VCO/FBDIV [nuttx]

2025-05-02 Thread via GitHub
shtirlic commented on PR #16300: URL: https://github.com/apache/nuttx/pull/16300#issuecomment-2846543490 @keever50 if I am not mistaken you had some USB issues, could you test this changes to see any improvements. -- This is an automated message from the Apache Git Service. To respond to