stbenn commented on issue #16248: URL: https://github.com/apache/nuttx/issues/16248#issuecomment-2847183457
@raiden00pl and @acassis, I have made some decent progress and will _hopefully_ be creating a PR for this in the next week. In the meantime, I have a question regarding the PR. The best way I could find to test the DMA driver is to also implement DMA support for the H5 ADC driver. I have kept the ADC and DMA development in separate branches, with the ADC branch rebasing/merging in changes made to the DMA branch (i.e. the ADC branch is the DMA branch + ADC specific development). Should these be separate PRs or one with multiple commits (one for DMA and one for ADC)? It is my understanding that typically they would be separate PRs, but in this case the ADC update is needed to test the DMA driver. If you have any suggestions for testing the DMA driver that you think would be better, please let me know! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
