Re: [PR] fs/vfs/fs_poll: Add noinstrument_function to poll_notify function [nuttx]

2025-03-18 Thread via GitHub
tmedicci commented on PR #15971: URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2732548756 > > Thanks for submitting. It helps booting the device, but still gives wrong results. I attached two logs, one with the content of this PR and the other with building #15997 . [trace_v

[PR] Revert "arch/xtensa: set PS.EXCM initial value to 1 while new thread … [nuttx]

2025-03-18 Thread via GitHub
sdc-g opened a new pull request, #16013: URL: https://github.com/apache/nuttx/pull/16013 ## Summary This reverts commit 3194ef0e7cb98e2d737eb6fbfcdfcd63959b1c5f. since level-2 and above interrupt, PS.EXCM is still 1. window rotation related instruction is undefined behavior.

Re: [I] [BUG] PR #15931 breaks ttyACM [nuttx]

2025-03-18 Thread via GitHub
yangsong8-a1 commented on issue #16004: URL: https://github.com/apache/nuttx/issues/16004#issuecomment-2735147890 @acassis ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-18 Thread via GitHub
lupyuen commented on code in PR #16016: URL: https://github.com/apache/nuttx/pull/16016#discussion_r2002240228 ## arch/xtensa/src/esp32/hardware/esp32_sha.h: ## @@ -0,0 +1,136 @@ +/ + * arch/xtensa/src/e

Re: [PR] Add fbcon example [nuttx-apps]

2025-03-18 Thread via GitHub
cederom commented on PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2735107180 Thanks @TimJTi amazing work!! :-) Please remember to update git commit: * examples/fbcon: Add video framebuffer console (or something like that). * some description. * g

Re: [PR] xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-18 Thread via GitHub
lupyuen commented on code in PR #16016: URL: https://github.com/apache/nuttx/pull/16016#discussion_r2002239506 ## arch/xtensa/src/esp32/esp32_sha.h: ## @@ -0,0 +1,219 @@ +/ + * arch/xtensa/src/esp32/esp3

Re: [PR] xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-18 Thread via GitHub
lupyuen commented on code in PR #16016: URL: https://github.com/apache/nuttx/pull/16016#discussion_r2002239344 ## arch/xtensa/src/esp32/esp32_sha.h: ## @@ -0,0 +1,219 @@ +/ + * arch/xtensa/src/esp32/esp3

Re: [PR] boards/arm64/a527/avaota-a1: Add support for PINE64 Yuzuki Avaota-A1 SBC (Allwinner A527 SoC) [nuttx]

2025-03-18 Thread via GitHub
lupyuen commented on PR #16001: URL: https://github.com/apache/nuttx/pull/16001#issuecomment-2735069199 Sorry @cederom: I need your help to review my PR, so that we can roll out PR Test Bot for Arm64. Thanks :-) -- This is an automated message from the Apache Git Service. To respond to th

[I] [BUG] Menuconfig option System type > ITM SYSLOG support fails on build for STM32F3Discovery [nuttx]

2025-03-18 Thread via GitHub
rentzboy opened a new issue, #16017: URL: https://github.com/apache/nuttx/issues/16017 ### Description / Steps to reproduce the issue From make menuconfig check System type > ITM SYSLOG support Build with make ERROR: stm32_start.c:174:3: error: implicit declaration of function '

[PR] xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-18 Thread via GitHub
PruteanuVlad opened a new pull request, #16016: URL: https://github.com/apache/nuttx/pull/16016 ## Summary This enables the use of the cryptographic accelerator within the ESP32. The support algorithms are: SHA1, SHA256, SHA384 and SHA512. The existing support for hardware accelerated

Re: [PR] xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-18 Thread via GitHub
nuttxpr commented on PR #16016: URL: https://github.com/apache/nuttx/pull/16016#issuecomment-2734908725 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

Re: [PR] games/snake: Add snake game [nuttx-apps]

2025-03-18 Thread via GitHub
acassis commented on PR #3028: URL: https://github.com/apache/nuttx-apps/pull/3028#issuecomment-2734609930 @eren-terzioglu some improvements suggestion (for other PR, of course) - Add option to use normal LCD (like in the Brick Match) - Add INPUT_DJOYSTICK to use direction keys (lik

Re: [PR] games/snake: Add snake game [nuttx-apps]

2025-03-18 Thread via GitHub
acassis merged PR #3028: URL: https://github.com/apache/nuttx-apps/pull/3028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] Add fbcon example [nuttx-apps]

2025-03-18 Thread via GitHub
TimJTi commented on PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2734372129 Just spotted there's a left over folder and CMakeLists.txt from when I called it something else. Will remove that with any future commits here, and before I make it ready for review aft

Re: [PR] Add fbcon example [nuttx-apps]

2025-03-18 Thread via GitHub
nuttxpr commented on PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2734296172 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit wi

[PR] Add fbcon example [nuttx-apps]

2025-03-18 Thread via GitHub
TimJTi opened a new pull request, #3029: URL: https://github.com/apache/nuttx-apps/pull/3029 ## Summary This adds a new "Example App" that allows a framebuffer character device to be used for STDOUT and/or STDIN text rendering. ## Impact It is a standalone app so has no impact o

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2025-03-18 Thread via GitHub
ppisa commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-2732055201 As for https://github.com/apache/nuttx/issues/6082 problem, I would like to provide generic solution, but it would require change in all RISC-V BSPs and probably even others and my re

Re: [PR] arch/risc-v: Fix wrong source name in make script [nuttx]

2025-03-18 Thread via GitHub
filippofontana commented on PR #16014: URL: https://github.com/apache/nuttx/pull/16014#issuecomment-2734139496 @inochisa sorry for the late reply, missed the notification. Yes this was also what I did locally and I can confirm it works. Thanks for the quick fix! -- This is an automated me

Re: [PR] arch/xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-18 Thread via GitHub
sdc-g commented on PR #15985: URL: https://github.com/apache/nuttx/pull/15985#issuecomment-2732368852 Hi @tmedicci please wait a moment... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] arch/risc-v: introduce AIA support [nuttx]

2025-03-18 Thread via GitHub
inochisa commented on code in PR #12804: URL: https://github.com/apache/nuttx/pull/12804#discussion_r2000906916 ## arch/risc-v/src/common/Make.defs: ## @@ -91,6 +91,10 @@ ifeq ($(CONFIG_ARCH_RV_ISA_A),y) CMN_ASRCS += riscv_testset.S endif +ifeq ($(CONFIG_ARCH_RV_HAVE_APLIC),

Re: [I] [BUG] PR #15931 breaks ttyACM [nuttx]

2025-03-18 Thread via GitHub
acassis commented on issue #16004: URL: https://github.com/apache/nuttx/issues/16004#issuecomment-2733494561 @yangsong8-a1 please take a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] examples/xmlrpc: Fix calls buffers size. [nuttx-apps]

2025-03-18 Thread via GitHub
acassis commented on PR #3027: URL: https://github.com/apache/nuttx-apps/pull/3027#issuecomment-2733480912 @cederom suggestion: lastCommand -> lastcmd; curState -> curstate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] tools/checkpatch: Use gmake on BSD, make otherwise. [nuttx]

2025-03-18 Thread via GitHub
simbit18 commented on PR #16015: URL: https://github.com/apache/nuttx/pull/16015#issuecomment-273331 > Hi @simbit18: Will this affect CI Builds on Linux / macOS / Windows? Thanks :-) @lupyuen yes it is ok! It's just a change for BSD. -- This is an automated message from the

Re: [PR] tools/bdf-converter: Fix loop termination condition. [nuttx]

2025-03-18 Thread via GitHub
acassis merged PR #16000: URL: https://github.com/apache/nuttx/pull/16000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] games/snake: Add snake game [nuttx-apps]

2025-03-18 Thread via GitHub
eren-terzioglu commented on PR #3028: URL: https://github.com/apache/nuttx-apps/pull/3028#issuecomment-2732926088 > Thanks @eren-terzioglu :-) Very cool :-) I would call this game ledsnake as it is targeted mostly towards led displays :-) Maybe not only led screens soon :) -- This

(nuttx) branch master updated: tools/bdf-converter: Fix loop termination condition.

2025-03-18 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3eddfe51fa tools/bdf-converter: Fix loop termina

Re: [PR] games/snake: Add snake game [nuttx-apps]

2025-03-18 Thread via GitHub
cederom commented on PR #3028: URL: https://github.com/apache/nuttx-apps/pull/3028#issuecomment-2733081896 Very cool, thanks, I hope for ncurses terminal version too! :-P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] [BUG] PR #15462 breaks the heap on MPFS targets [nuttx]

2025-03-18 Thread via GitHub
jlaitine closed issue #16005: [BUG] PR #15462 breaks the heap on MPFS targets URL: https://github.com/apache/nuttx/issues/16005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] arch/risc-v: Fix wrong source name in make script [nuttx]

2025-03-18 Thread via GitHub
inochisa commented on PR #16014: URL: https://github.com/apache/nuttx/pull/16014#issuecomment-2733035779 @filippofontana Could you check this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] arch/risc-v: Fix wrong source name in make script [nuttx]

2025-03-18 Thread via GitHub
inochisa opened a new pull request, #16014: URL: https://github.com/apache/nuttx/pull/16014 ## Summary AIA releted source files in the Make.defs are not right. Replace them with the right source. Fixes: #12804 ## Impact This should have no impact. -- This i

Re: [PR] Revert "arch/xtensa: set PS.EXCM initial value to 1 while new thread … [nuttx]

2025-03-18 Thread via GitHub
chirping78 commented on PR #16013: URL: https://github.com/apache/nuttx/pull/16013#issuecomment-2733023441 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] arch/risc-v: introduce AIA support [nuttx]

2025-03-18 Thread via GitHub
filippofontana commented on code in PR #12804: URL: https://github.com/apache/nuttx/pull/12804#discussion_r2000885540 ## arch/risc-v/src/common/Make.defs: ## @@ -91,6 +91,10 @@ ifeq ($(CONFIG_ARCH_RV_ISA_A),y) CMN_ASRCS += riscv_testset.S endif +ifeq ($(CONFIG_ARCH_RV_HAVE_A

Re: [PR] arch/xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-18 Thread via GitHub
sdc-g commented on PR #15985: URL: https://github.com/apache/nuttx/pull/15985#issuecomment-2732740063 Hi @chirping78 @tmedicci Please review: https://github.com/apache/nuttx/pull/16013 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] [BUG] PR #15462 breaks the heap on MPFS targets [nuttx]

2025-03-18 Thread via GitHub
jlaitine commented on issue #16005: URL: https://github.com/apache/nuttx/issues/16005#issuecomment-2732679191 After reverting the ttyACM PR, mentioned in https://github.com/apache/nuttx/issues/16004, I haven't been able to re-produce this issue. So it is possible that this was just due to t

Re: [PR] arch/xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-18 Thread via GitHub
sdc-g commented on PR #15985: URL: https://github.com/apache/nuttx/pull/15985#issuecomment-2732667748 Hi @chirping78 Thanks so much always. I can understand instruction undefined behavior while PS.EXCM=1. Let me revert this commit. -- This is an automated message from the Apa

Re: [I] [BUG] PR #15931 breaks ttyACM [nuttx]

2025-03-18 Thread via GitHub
jlaitine commented on issue #16004: URL: https://github.com/apache/nuttx/issues/16004#issuecomment-2732363911 I have re-produced the problem now also on i.MX93 target. I wrote a test program to show the issues specifically: 1) serial IOCTL:s are broken (I used FIONREAD in the te

Re: [PR] Docs/snake game update [nuttx]

2025-03-18 Thread via GitHub
eren-terzioglu commented on PR #16006: URL: https://github.com/apache/nuttx/pull/16006#issuecomment-2732098084 > Thanks @eren-terzioglu, I assume this CI Error will go away after we merge [apache/nuttx-apps#3028](https://github.com/apache/nuttx-apps/pull/3028) > > https://github.com/

Re: [PR] arch/xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-18 Thread via GitHub
tmedicci commented on PR #15985: URL: https://github.com/apache/nuttx/pull/15985#issuecomment-2732366586 Thanks for the ongoing conversation @chirping78 and @sdc-g ! Should we revert it then? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2025-03-18 Thread via GitHub
nakajimayoshi commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-2732211545 > I think that NuttX should be considered as a operating system and standard library base. That's great! Don't know how it relates to this conversation though 😄 .

Re: [PR] Add esp32s3 lcd ev v1.5 support [nuttx]

2025-03-18 Thread via GitHub
nuttxpr commented on PR #16012: URL: https://github.com/apache/nuttx/pull/16012#issuecomment-2732286424 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR mostly meets the NuttX requirements but needs so

[PR] Add esp32s3 lcd ev v1.5 support [nuttx]

2025-03-18 Thread via GitHub
eren-terzioglu opened a new pull request, #16012: URL: https://github.com/apache/nuttx/pull/16012 ## Summary * arch/xtensa/esp32s3: Change default pins for esp32s3-lcd-ev-board v1.5 Change default pins for esp32s3-lcd-ev-board to prevent pin changes between boards

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2025-03-18 Thread via GitHub
ppisa commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-2732254373 > > I think that NuttX should be considered as a operating system and standard library base. > > That's great! Don't know how it relates to this conversation though 😄 . Th

Re: [PR] arch/xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-18 Thread via GitHub
chirping78 commented on PR #15985: URL: https://github.com/apache/nuttx/pull/15985#issuecomment-2732248819 @sdc-g I have found a way to reproduce. Here it is: 1. With latest master code, change `apps/examples/hello/hello_main.c`, replace it with the progrom in your PR summary 2. change

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2025-03-18 Thread via GitHub
lupyuen commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-2732132856 Hi @nakajimayoshi: `cargo` is now supported for Rust Apps on NuttX, thanks to the implementation of Rust Standard Library by @no1wudi. I wrote about it here: https://lupyuen.org/arti

Re: [PR] arch/xtensa: set PS.EXCM initial value to 1 while new thread created [nuttx]

2025-03-18 Thread via GitHub
chirping78 commented on PR #15985: URL: https://github.com/apache/nuttx/pull/15985#issuecomment-2732052485 > So current system only level-1 interrupt and syscall, both can re-set PS.EXCM to 0 by rfe, right? yes > > I'm still wonder what happens while high level interrupt ha

Re: [I] [BUG] PR #15931 breaks ttyACM [nuttx]

2025-03-18 Thread via GitHub
michallenc commented on issue #16004: URL: https://github.com/apache/nuttx/issues/16004#issuecomment-2732004468 Hi, I also had some issues with CDC ACM after the patch, but only for our custom [Silicon Heaven protocol](https://silicon-heaven.github.io/shv-doc/), wasn't able to reproduce it

Re: [I] [Discussion] Rust integration in Nuttx [nuttx]

2025-03-18 Thread via GitHub
ppisa commented on issue #11907: URL: https://github.com/apache/nuttx/issues/11907#issuecomment-2731993935 @nakajimayoshi I think that NuttX should be considered as a operating system and standard library base. In this case build by make/Cmake etc. is right way. It should be configured and