nuttxpr commented on PR #16016: URL: https://github.com/apache/nuttx/pull/16016#issuecomment-2734908725
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, although the testing section could be improved. While it mentions the test inspiration and platform, it lacks concrete "before" and "after" logs demonstrating the change in functionality. Simply stating "all tests passed" is insufficient. Include specific examples of test commands and their output, showcasing the difference between software and hardware-accelerated SHA performance or output. This provides reviewers with tangible evidence of the PR's effectiveness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
