nuttxpr commented on PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#issuecomment-2705750538
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues)
Build and Test Successful (milkv_duos:nsh)
https://gitlab.co
lupyuen commented on PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#issuecomment-2705740024
@nuttxpr test milkv_duos:nsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
jlaitine commented on PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#issuecomment-2705730405
Re tested the latest patch.
Ostest passes for mpfs (flat build, smp w. 4 harts), rv-virt:nsh and
rv-virt:nsh64, also verified that the tick timer doesn't have the previous
errors
SPRESENSE opened a new pull request, #15951:
URL: https://github.com/apache/nuttx/pull/15951
## Summary
Fix build error with the following condition.
- CONFIG_BOARD_CRASHDUMP_CUSTOM=y
- CONFIG_COREDUMP=n
The condition for calling `coredump_initialize()` is incorrect.
CONFIG
jlaitine commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1984500335
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -211,19 +210,20 @@ static int riscv_mtimer_max_delay(struct
oneshot_lowerhalf_s *lower,
static int riscv_mtimer_sta
cederom opened a new pull request, #15950:
URL: https://github.com/apache/nuttx/pull/15950
* This comes from vast mailing list discussions on breaking changes, code
quality, long term self-compatibility and maintenance, etc.
* Rules are based on mailing list discussion and votes.
* I t
nuttxpr commented on PR #15950:
URL: https://github.com/apache/nuttx/pull/15950#issuecomment-2705576427
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
This PR template provides a good starting point for ens
xiaoxiang781216 commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1984406661
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -222,8 +221,11 @@ static int riscv_mtimer_start(struct oneshot_lowerhalf_s
*lower,
flags = up_irq_save();
xiaoxiang781216 commented on code in PR #15938:
URL: https://github.com/apache/nuttx/pull/15938#discussion_r1984406298
##
arch/arm64/src/common/arm64_arch_timer.c:
##
@@ -265,34 +269,20 @@ static int arm64_tick_start(struct oneshot_lowerhalf_s
*lower,
{
struct arm64_oneshot
xiaoxiang781216 commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1984389085
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -211,19 +210,20 @@ static int riscv_mtimer_max_delay(struct
oneshot_lowerhalf_s *lower,
static int riscv_mti
xiaoxiang781216 commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2705329541
> @cederom basically all the requested changes were fixed. But I agree this
PR could have high risk to break existing system and the author didn't test on
real hardware.
no
linguini1 commented on issue #15856:
URL: https://github.com/apache/nuttx/issues/15856#issuecomment-2705122977
> @linguini1
> Merged the new things. I'm looking which added IOCTLs of you can stay or
move.
>
> - WLIOC_SETBITRATE, is this for GFSK? Then lets move that under GFSK tag
keever50 commented on issue #15856:
URL: https://github.com/apache/nuttx/issues/15856#issuecomment-2704934310
@linguini1
Merged the new things. I'm looking which added IOCTLs of you can stay or
move.
- WLIOC_SETBITRATE, is this for GFSK? Then lets move that under GFSK tag
- WLI
jlaitine commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1983873683
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -211,19 +210,20 @@ static int riscv_mtimer_max_delay(struct
oneshot_lowerhalf_s *lower,
static int riscv_mtimer_sta
acassis commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2704774615
@cederom basically all the requested changes were fixed. But I agree this PR
could have high risk to break existing system and the author didn't test on
real hardware.
--
This is an au
tmedicci commented on issue #15790:
URL: https://github.com/apache/nuttx/issues/15790#issuecomment-2703890132
Closed with https://github.com/apache/nuttx/pull/15851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
cederom commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2704648981
@acassis this is second time recently you have merged PR despite unresolved
discussions and potentially breaking changes :-(
--
This is an automated message from the Apache Git Service.
jlaitine commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1983875580
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -211,19 +210,20 @@ static int riscv_mtimer_max_delay(struct
oneshot_lowerhalf_s *lower,
static int riscv_mtimer_sta
keever50 commented on issue #15856:
URL: https://github.com/apache/nuttx/issues/15856#issuecomment-2704447738
> > About the rx_hdr, thats interesting! i was more thinking of .payload
pointing to an internal driver buffer.
> > But this is also an option, the buffer being the user's respons
jlaitine commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1983204204
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -211,19 +210,20 @@ static int riscv_mtimer_max_delay(struct
oneshot_lowerhalf_s *lower,
static int riscv_mtimer_sta
xiaoxiang781216 commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1983529417
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -211,19 +210,20 @@ static int riscv_mtimer_max_delay(struct
oneshot_lowerhalf_s *lower,
static int riscv_mti
xiaoxiang781216 commented on PR #15931:
URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2704103928
I prefer all related change in one patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
acassis commented on code in PR #15945:
URL: https://github.com/apache/nuttx/pull/15945#discussion_r1983500657
##
fs/littlefs/lfs_vfs.c:
##
@@ -1121,14 +1121,7 @@ static int littlefs_rewinddir(FAR struct inode *mountpt,
}
/
jlaitine commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1983354499
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -211,19 +210,20 @@ static int riscv_mtimer_max_delay(struct
oneshot_lowerhalf_s *lower,
static int riscv_mtimer_sta
tmedicci closed issue #15790: [DOC] esp32s3-lcd-ev is missing proper
Documentation/ entry with picture and proper description
URL: https://github.com/apache/nuttx/issues/15790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
xiaoxiang781216 commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1983303339
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -211,19 +210,20 @@ static int riscv_mtimer_max_delay(struct
oneshot_lowerhalf_s *lower,
static int riscv_mti
jlaitine commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1983204204
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -211,19 +210,20 @@ static int riscv_mtimer_max_delay(struct
oneshot_lowerhalf_s *lower,
static int riscv_mtimer_sta
jlaitine commented on PR #15938:
URL: https://github.com/apache/nuttx/pull/15938#issuecomment-2703630963
> Regarding the problem you described, the original implementation of
aligning the tick scale also has this problem. Let's take an example. Assume
that the frequency is `6250`, `
Fix-Point commented on PR #15938:
URL: https://github.com/apache/nuttx/pull/15938#issuecomment-2703593592
> Adding one example with real numbers how the timer drift causes the tick
timer & watchdog timers to fail:
>
> Example:
>
> Counter frequency 2400 (24MHz) Tick frequen
xiaoxiang781216 commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1983175072
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -211,19 +210,20 @@ static int riscv_mtimer_max_delay(struct
oneshot_lowerhalf_s *lower,
static int riscv_mti
xiaoxiang781216 commented on code in PR #15929:
URL: https://github.com/apache/nuttx/pull/15929#discussion_r1983175072
##
arch/risc-v/src/common/riscv_mtimer.c:
##
@@ -211,19 +210,20 @@ static int riscv_mtimer_max_delay(struct
oneshot_lowerhalf_s *lower,
static int riscv_mti
jerpelea commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2703303557
> @jerpelea
>
> > * SPDX-License-Identifier: Apache-2.0
>
> Where should this go? In every file?
every file that had a license
ex:
https://github.com/apache
jerpelea commented on PR #15947:
URL: https://github.com/apache/nuttx/pull/15947#issuecomment-2703260956
@acassis PR merged without proper PR and commit title !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
acassis merged PR #15947:
URL: https://github.com/apache/nuttx/pull/15947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
raiden00pl merged PR #15939:
URL: https://github.com/apache/nuttx/pull/15939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.a
raiden00pl commented on issue #15737:
URL: https://github.com/apache/nuttx/issues/15737#issuecomment-2703168899
I added https://github.com/apache/nuttx/pull/15765 to the list.
@cederom I also modified the top post so that PRs ready to merge and issues
to solve have separate lists.
-
raiden00pl merged PR #3016:
URL: https://github.com/apache/nuttx-apps/pull/3016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
This is an automated email from the ASF dual-hosted git repository.
raiden00 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 9a02572e8e arch/arm/samv7/spi: fix ifdelay setu
raiden00pl merged PR #15900:
URL: https://github.com/apache/nuttx/pull/15900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.a
39 matches
Mail list logo
