Re: [PR] Documentation: Add XIAO nRF52840 Board [nuttx]

2025-02-18 Thread via GitHub
meilily commented on PR #15803: URL: https://github.com/apache/nuttx/pull/15803#issuecomment-2667756758 @acassis May I know when we could expect to see the doc live on [NuttX's Docs](https://nuttx.apache.org/docs/latest/platforms/index.html)? Didn't see it live yet. Thanks! -- This is an

[PR] Add a selection for SPI after selecting RPMSG_PORT_SPI [nuttx]

2025-02-18 Thread via GitHub
sszllxos opened a new pull request, #15869: URL: https://github.com/apache/nuttx/pull/15869 ## Summary If you do not configure SPI after configuring RPMSG_PORT_SPI, the following warning will be generated during compilation: [109/1450] Building C object drivers/CMakeFiles/

[PR] libs/libnx: do not generate resource if CONFIG_NX is not enabled [nuttx]

2025-02-18 Thread via GitHub
anchao opened a new pull request, #15868: URL: https://github.com/apache/nuttx/pull/15868 ## Summary libs/libnx: do not generate resource if CONFIG_NX is not enabled To avoid generate resource if CONFIG_NX is disabled: ``` | $ make -j12 | Create version.h | CPP: nxf

(nuttx) branch master updated (c9a8f96aac -> 32bc95182a)

2025-02-18 Thread jiuzhudong
This is an automated email from the ASF dual-hosted git repository. jiuzhudong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from c9a8f96aac xtensa/esp32: set cpuint to initial value after deallocate add 746db1968d esp32s3-devkit/fastboot:

Re: [PR] boards/esp32s3-devkit: Initializing configuration for Fastboot [nuttx]

2025-02-18 Thread via GitHub
Donny9 merged PR #15836: URL: https://github.com/apache/nuttx/pull/15836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [PR] arch/esp32_partition: add some partition operation interfaces for esp32 [nuttx]

2025-02-18 Thread via GitHub
lupyuen commented on PR #15866: URL: https://github.com/apache/nuttx/pull/15866#issuecomment-2667558351 Thanks! Could you also add the signature? `git commit -s` FYI we just added the new guidelines :-) https://lists.apache.org/thread/mo4ncnczts12mz02f0y21wgbngpjvr1q -- This is an

[PR] Add ARCH_CHIP_ESP32S3WROOM1N16R8 configuration for ESP32-S3 DevKit [nuttx]

2025-02-18 Thread via GitHub
sszllxos opened a new pull request, #15867: URL: https://github.com/apache/nuttx/pull/15867 ## Summary boards/Kconfig: Add ARCH_CHIP_ESP32S3WROOM1N16R8 configuration item for Espressif ESP32-S3 DevKit ## Impact Add new configuration for support N16R8 ## Testin

Re: [PR] arch/esp32_partition: add some partition operation interfaces for esp32 [nuttx]

2025-02-18 Thread via GitHub
nuttxs commented on PR #15866: URL: https://github.com/apache/nuttx/pull/15866#issuecomment-2667540895 > Please remember to fill in the Commit Description. Just copy the PR Summary above into the Commit Description. Thanks :-) > > * [571c319](https://github.com/apache/nuttx/commit/57

Re: [PR] arch/esp32_partition: add some partition operation interfaces for esp32 [nuttx]

2025-02-18 Thread via GitHub
lupyuen commented on PR #15866: URL: https://github.com/apache/nuttx/pull/15866#issuecomment-2667466230 Please remember to fill in the Commit Description. Just copy the PR Summary above into the Commit Description. Thanks :-) - https://github.com/apache/nuttx/pull/15866/commits/571c319c3

[PR] arch/esp32_partition: add some partition operation interfaces for esp32 [nuttx]

2025-02-18 Thread via GitHub
nuttxs opened a new pull request, #15866: URL: https://github.com/apache/nuttx/pull/15866 ## Summary arch/esp32_partition: - Relocate the enum ota_img_ctrl_e and ota_img_bootseq_e to a directory visible to the application. - Inspect if the MTD partition (factory/ota_0/ota_1) is

Re: [PR] arm64: Initialize sctrl_el1 when running fork [nuttx]

2025-02-18 Thread via GitHub
W-M-R commented on PR #15857: URL: https://github.com/apache/nuttx/pull/15857#issuecomment-2667422251 > @W-M-R Please remember to: > > * Fill in the Commit Description: [3742be9](https://github.com/apache/nuttx/commit/3742be91c3f0c98001f311700f0aca89a53075f3) > * Remove this from t

Re: [PR] board/arm/rp2040: support config st7789 reset gpio pin [nuttx]

2025-02-18 Thread via GitHub
lupyuen commented on PR #15863: URL: https://github.com/apache/nuttx/pull/15863#issuecomment-2667394184 Could you copy the PR Summary above into the Commit Description: - https://github.com/apache/nuttx/pull/15863/commits/31d956959e6664b8eff3cc158ee413c8a37d7eb5 And please remove t

Re: [PR] Pico restouch lcd 2.8 [nuttx]

2025-02-18 Thread via GitHub
lupyuen commented on PR #15864: URL: https://github.com/apache/nuttx/pull/15864#issuecomment-2667390819 Could you fill in the Commit Description? Just copy the PR Summary above into the Commit Description, so it's easier for others to understand the commit: - https://github.com/apache/nu

Re: [PR] libc/libcxx: fix failures with GCC 14 [nuttx]

2025-02-18 Thread via GitHub
nuttxpr commented on PR #15865: URL: https://github.com/apache/nuttx/pull/15865#issuecomment-2667382305 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] libc/libcxx: fix failures with GCC 14 [nuttx]

2025-02-18 Thread via GitHub
anchao opened a new pull request, #15865: URL: https://github.com/apache/nuttx/pull/15865 ## Summary libc/libcxx: fix failures with GCC 14 ``` CXX: libcxx/libcxx/src/random.cpp In file included from nuttx/include/libcxx/__filesystem/filesystem_error.h:15,

Re: [PR] feat(arch/xensa): add CONFIG_SPIRAM_MEMTEST from ESP-IDF [nuttx]

2025-02-18 Thread via GitHub
tim-sony commented on PR #15855: URL: https://github.com/apache/nuttx/pull/15855#issuecomment-2667373132 > Please run a sanity check on S2. If you don't have one available I can trigger internal CI so we can be sure. Thanks for your comment, @fdcavalcanti! Since we don't have an S2 b

Re: [PR] Pico restouch lcd 2.8 [nuttx]

2025-02-18 Thread via GitHub
nuttxpr commented on PR #15864: URL: https://github.com/apache/nuttx/pull/15864#issuecomment-2667368072 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX r

[PR] Pico restouch lcd 2.8 [nuttx]

2025-02-18 Thread via GitHub
ZhuZhongjie opened a new pull request, #15864: URL: https://github.com/apache/nuttx/pull/15864 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary add a new pico lcd module Pico restouch lcd 2.8 this com

[PR] board/arm/rp2040: support config st7789 reset gpio pin [nuttx]

2025-02-18 Thread via GitHub
ZhuZhongjie opened a new pull request, #15863: URL: https://github.com/apache/nuttx/pull/15863 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary support config st7789 reset gpio pin ## Impact

Re: [PR] sched/spin_lock: continue work to rename raw_spin* to spin_*_notrace [nuttx]

2025-02-18 Thread via GitHub
nuttxpr commented on PR #15862: URL: https://github.com/apache/nuttx/pull/15862#issuecomment-2667321613 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

[PR] sched/spin_lock: continue work to rename raw_spin* to spin_*_notrace [nuttx]

2025-02-18 Thread via GitHub
anchao opened a new pull request, #15862: URL: https://github.com/apache/nuttx/pull/15862 ## Summary sched/spin_lock: continue work to rename raw_spin* to spin_*_notrace Some improvements are made to the following commits: https://github.com/apache/nuttx/pull/15767 ```

Re: [PR] tools/espressif: Improve version checking by subprocess [nuttx]

2025-02-18 Thread via GitHub
no1wudi commented on PR #15854: URL: https://github.com/apache/nuttx/pull/15854#issuecomment-2667260026 > Does it solve an issue? Are you having problems with pipx? Yes, each app installed by pipx like tools is in a isolated venv, pkg_resources can't fetch the info if not switch to it

Re: [PR] arm/stm32f401rc-rs485: Add support to GPIO Subsystem [nuttx]

2025-02-18 Thread via GitHub
lupyuen commented on PR #15861: URL: https://github.com/apache/nuttx/pull/15861#issuecomment-2667241042 Please remember to fill in the Commit Description. (Just copy from PR Summary) Thanks :-) - https://github.com/apache/nuttx/pull/15861/commits/6dcfae8b8606c88577c90409224a7d6e07e8af19

Re: [PR] arm/stm32f401rc-rs485: Add support to GPIO Subsystem [nuttx]

2025-02-18 Thread via GitHub
nuttxpr commented on PR #15861: URL: https://github.com/apache/nuttx/pull/15861#issuecomment-2667227193 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The provided information is a good start but is missing

[PR] arm/stm32f401rc-rs485: Add support to GPIO Subsystem [nuttx]

2025-02-18 Thread via GitHub
rcsim opened a new pull request, #15861: URL: https://github.com/apache/nuttx/pull/15861 ## Summary This PR adds support to GPIO Subsystem for STM32F401RC RS485 board. ## Impact Users will be able to use GPIO subsystem, including adding GPIO as Output, Input and Input with Inter

[PR] drivers/sensors/lsm6dso32: fixed byte read command to include start condition [nuttx]

2025-02-18 Thread via GitHub
linguini1 opened a new pull request, #15860: URL: https://github.com/apache/nuttx/pull/15860 ## Summary This issue was noticed while testing the LSM6DSO32 driver on the STM32H743 MCU, as part of issue #15826. This is required to meet the communication requirements as per the LS

Re: [I] [BUG] Floating point issues on STM32H743 [nuttx]

2025-02-18 Thread via GitHub
linguini1 commented on issue #15826: URL: https://github.com/apache/nuttx/issues/15826#issuecomment-2666846725 > [@linguini1](https://github.com/linguini1) what about MS56XX stack size ? I don't see CONFIG_MS56XX_THREAD_STACKSIZE in your config, and the default 1024 may be not enough.

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
keever50 commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1960526016 ## drivers/wireless/lpwan/rn2xx3/rn2xx3.c: ## @@ -0,0 +1,1612 @@ +/ + * drivers/wireless/lp

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
keever50 commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1960524795 ## include/nuttx/wireless/ioctl.h: ## @@ -60,13 +60,31 @@ /* output power (in dBm) */ #define WLIOC_GETTXPOWER_WLCIO

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-18 Thread via GitHub
keever50 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2666823650 I will post do more testing this driver and put a test report here this week. Also go over the code for a cleanup. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
keever50 commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1960124619 ## drivers/wireless/lpwan/rn2xx3/rn2xx3.c: ## @@ -0,0 +1,1612 @@ +/ + * drivers/wireless/lp

Re: [I] [FEATURE] Common interface for LORA chips [nuttx]

2025-02-18 Thread via GitHub
linguini1 commented on issue #15856: URL: https://github.com/apache/nuttx/issues/15856#issuecomment-2666771195 I suppose this common interface would also still involve having `read` and `write` as rx/tx? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
linguini1 commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1960407016 ## include/nuttx/wireless/ioctl.h: ## @@ -60,13 +60,31 @@ /* output power (in dBm) */ #define WLIOC_GETTXPOWER_WLCI

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
linguini1 commented on PR #15828: URL: https://github.com/apache/nuttx/pull/15828#issuecomment-291444 > I think we should put some effort into the common API for LORA chips. Here is another PR with LORA chip https://github.com/apache/nuttx/pull/15795 and it would be good if all LORA chi

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
linguini1 commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1960392323 ## drivers/wireless/lpwan/rn2xx3/rn2xx3.c: ## @@ -0,0 +1,1612 @@ +/ + * drivers/wireless/l

Re: [PR] tools/espressif: Improve version checking by subprocess [nuttx]

2025-02-18 Thread via GitHub
fdcavalcanti commented on PR #15854: URL: https://github.com/apache/nuttx/pull/15854#issuecomment-2666305395 Please provide test with `esptool < 4.8.0`. If possible, also test with older Python i.e.` < 3.8` -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] tools/espressif: Improve version checking by subprocess [nuttx]

2025-02-18 Thread via GitHub
fdcavalcanti commented on code in PR #15854: URL: https://github.com/apache/nuttx/pull/15854#discussion_r1960134390 ## tools/espressif/check_esptool.py: ## @@ -92,4 +78,4 @@ def check_version(min_esptool_version: str) -> int: if __name__ == "__main__": parser = parser.pa

Re: [PR] tools/espressif: Improve version checking by subprocess [nuttx]

2025-02-18 Thread via GitHub
fdcavalcanti commented on PR #15854: URL: https://github.com/apache/nuttx/pull/15854#issuecomment-2666277174 Does it solve an issue? Are you having problems with pipx? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
keever50 commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1960124619 ## drivers/wireless/lpwan/rn2xx3/rn2xx3.c: ## @@ -0,0 +1,1612 @@ +/ + * drivers/wireless/lp

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
keever50 commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1960121229 ## drivers/wireless/lpwan/rn2xx3/rn2xx3.c: ## @@ -0,0 +1,1612 @@ +/ + * drivers/wireless/lp

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
raiden00pl commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1960088627 ## drivers/wireless/lpwan/rn2xx3/rn2xx3.c: ## @@ -0,0 +1,1612 @@ +/ + * drivers/wireless/

Re: [PR] tools/espressif: Improve version checking by subprocess [nuttx]

2025-02-18 Thread via GitHub
LuchianMihai commented on code in PR #15854: URL: https://github.com/apache/nuttx/pull/15854#discussion_r1959996001 ## tools/espressif/check_esptool.py: ## @@ -56,28 +46,24 @@ def parse_version(version_string) -> list: def check_version(min_esptool_version: str) -> int: Re

Re: [PR] tools/espressif: Improve version checking by subprocess [nuttx]

2025-02-18 Thread via GitHub
LuchianMihai commented on code in PR #15854: URL: https://github.com/apache/nuttx/pull/15854#discussion_r1959996001 ## tools/espressif/check_esptool.py: ## @@ -56,28 +46,24 @@ def parse_version(version_string) -> list: def check_version(min_esptool_version: str) -> int: Re

Re: [PR] I2S Support for RISC-V Based Espressif Devices [nuttx]

2025-02-18 Thread via GitHub
eren-terzioglu commented on PR #15852: URL: https://github.com/apache/nuttx/pull/15852#issuecomment-2665976671 Thanks @acassis, updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] xtensa/esp32: set cpuint to initial value after deallocate [nuttx]

2025-02-18 Thread via GitHub
acassis merged PR #15829: URL: https://github.com/apache/nuttx/pull/15829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated: xtensa/esp32: set cpuint to initial value after deallocate

2025-02-18 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new c9a8f96aac xtensa/esp32: set cpuint to initial v

Re: [PR] nxgdb/irq: add irqinfo command [nuttx]

2025-02-18 Thread via GitHub
acassis merged PR #15743: URL: https://github.com/apache/nuttx/pull/15743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated (27d5a1b4b7 -> 05e1cb736c)

2025-02-18 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 27d5a1b4b7 arm/memory_barrier: fix build warning on GCC14 add 06c7e2a02e nxgdb/utils: add has_field and fix Array

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
acassis commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1959822627 ## drivers/wireless/lpwan/rn2xx3/rn2xx3.c: ## @@ -0,0 +1,1612 @@ +/ + * drivers/wireless/lpw

Re: [PR] Espressif Documentation Update [nuttx]

2025-02-18 Thread via GitHub
hartmannathan commented on PR #15851: URL: https://github.com/apache/nuttx/pull/15851#issuecomment-2665826131 Thanks for improving Documentation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-18 Thread via GitHub
hartmannathan commented on code in PR #15848: URL: https://github.com/apache/nuttx/pull/15848#discussion_r1959813403 ## arch/arm/include/spinlock.h: ## @@ -42,33 +42,13 @@ #define SP_UNLOCKED 0 /* The Un-locked state */ #define SP_LOCKED 1 /* The Locked state */ -/* Memo

(nuttx) branch master updated (954081cdd8 -> 27d5a1b4b7)

2025-02-18 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 954081cdd8 xtensa/esp32s3: use common Espressif wireless source add 5a64967ce7 nuttx/compiler: fix build wa

Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-18 Thread via GitHub
hartmannathan merged PR #15848: URL: https://github.com/apache/nuttx/pull/15848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[PR] samv7/pwm: fix incorrect write of CMRx register [nuttx]

2025-02-18 Thread via GitHub
michallenc opened a new pull request, #15859: URL: https://github.com/apache/nuttx/pull/15859 ## Summary DTE (dead time enable) is the 17th bit in CMRx (channel mode) register. Function `pwm_set_polarity` did however read and write this register as 16 bit large, therefore dead time gener

Re: [I] [BUG] ESP32C6 - UsbConsole feature not working [nuttx]

2025-02-18 Thread via GitHub
eren-terzioglu commented on issue #15656: URL: https://github.com/apache/nuttx/issues/15656#issuecomment-2665702034 > Hello [@tmedicci](https://github.com/tmedicci), [@eren-terzioglu](https://github.com/eren-terzioglu), > > After some analysis, I discovered that the esp_txint function

Re: [PR] boards/esp32s3-devkit: Initializing configuration for Fastboot [nuttx]

2025-02-18 Thread via GitHub
tmedicci commented on code in PR #15836: URL: https://github.com/apache/nuttx/pull/15836#discussion_r1959711746 ## boards/xtensa/esp32s3/esp32s3-devkit/configs/fastboot/defconfig: ## Review Comment: Alright, if it's being used by other defconfigs and doesn't trigger any is

Re: [PR] tools/espressif: Improve version checking by subprocess [nuttx]

2025-02-18 Thread via GitHub
tmedicci commented on PR #15854: URL: https://github.com/apache/nuttx/pull/15854#issuecomment-2665647703 @eren-terzioglu and @fdcavalcanti , can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] [FEATURE] Should we extend fastboot oem to support executing custom commands? [nuttx-apps]

2025-02-18 Thread via GitHub
JianyuWang0623 commented on issue #2991: URL: https://github.com/apache/nuttx-apps/issues/2991#issuecomment-2665603577 Related: [boards/esp32s3-devkit: Initializing configuration for Fastboot by JianyuWang0623 · Pull Request #15836 · apache/nuttx · GitHub](https://github.com/apache/nuttx/pu

Re: [PR] boards/esp32s3-devkit: Initializing configuration for Fastboot [nuttx]

2025-02-18 Thread via GitHub
JianyuWang0623 commented on code in PR #15836: URL: https://github.com/apache/nuttx/pull/15836#discussion_r1959661107 ## boards/xtensa/esp32s3/esp32s3-devkit/configs/fastboot/defconfig: ## Review Comment: @tmedicci It`s an extension of [configure.sh](https://github.com/ap

Re: [PR] fs/drivers: Avoid causing a busy loop due to context switching induced by sem_post. [nuttx]

2025-02-18 Thread via GitHub
Donny9 commented on PR #15842: URL: https://github.com/apache/nuttx/pull/15842#issuecomment-2665565804 > maybe this comment is a bit off-topic. > > i feel it's better for us to provide a native CV implementation. it's tricky to implement condvar semantics correctly with semaphores. it

Re: [PR] arm64: Initialize sctrl_el1 when running fork [nuttx]

2025-02-18 Thread via GitHub
lupyuen commented on PR #15857: URL: https://github.com/apache/nuttx/pull/15857#issuecomment-2665550212 @W-M-R Please remember to: - Fill in the Commit Description: https://github.com/apache/nuttx/pull/15857/commits/3742be91c3f0c98001f311700f0aca89a53075f3 - Remove this from the PR Des

Re: [PR] arm64: Initialize sctrl_el1 when running fork [nuttx]

2025-02-18 Thread via GitHub
nuttxpr commented on PR #15857: URL: https://github.com/apache/nuttx/pull/15857#issuecomment-2665548954 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test Successful (qemu-armv8a:netnsh) https://gitla

Re: [PR] arm64: Initialize sctrl_el1 when running fork [nuttx]

2025-02-18 Thread via GitHub
lupyuen commented on PR #15857: URL: https://github.com/apache/nuttx/pull/15857#issuecomment-2665533412 @nuttxpr test qemu-armv8a:netnsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] boards/esp32s3-devkit: Initializing configuration for Fastboot [nuttx]

2025-02-18 Thread via GitHub
JianyuWang0623 commented on PR #15836: URL: https://github.com/apache/nuttx/pull/15836#issuecomment-2665524119 > @JianyuWang0623 it should be nice if there are a complete board example demonstrating how to support and use fastboot. The documentation explains the commands: https://nuttx.apa

Re: [PR] feat(arch/xensa): add CONFIG_SPIRAM_MEMTEST from ESP-IDF [nuttx]

2025-02-18 Thread via GitHub
fdcavalcanti commented on PR #15855: URL: https://github.com/apache/nuttx/pull/15855#issuecomment-2665492304 Looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] xtensa/esp32: use common Espressif wireless source [nuttx]

2025-02-18 Thread via GitHub
fdcavalcanti commented on code in PR #15853: URL: https://github.com/apache/nuttx/pull/15853#discussion_r1959599259 ## arch/xtensa/src/common/espressif/Kconfig: ## @@ -720,6 +724,13 @@ config ESPRESSIF_WIFI_LISTEN_INTERVAL For example, if beacon interval is 100 m

Re: [I] [FEATURE] Common interface for LORA chips [nuttx]

2025-02-18 Thread via GitHub
raiden00pl commented on issue #15856: URL: https://github.com/apache/nuttx/issues/15856#issuecomment-2665451341 @keever50 it's a good idea to introduce 3 levels of ioctl: 1. common RF commands, 2. modulation specific commands, 3. chips specific commands. However, the last type of commands s

Re: [PR] interpreters/quickjs/CMakeLists.txt: Sync of build Cmake with build Make [nuttx-apps]

2025-02-18 Thread via GitHub
simbit18 commented on PR #3001: URL: https://github.com/apache/nuttx-apps/pull/3001#issuecomment-2665344523 @lupyuen This does not depend on this PR :) https://github.com/apache/nuttx-apps/actions/runs/13389234727/job/37393046429?pr=3001#logs Run docker/login-action@v3 Logging i

Re: [PR] interpreters/quickjs/CMakeLists.txt: Sync of build Cmake with build Make [nuttx-apps]

2025-02-18 Thread via GitHub
lupyuen commented on PR #3001: URL: https://github.com/apache/nuttx-apps/pull/3001#issuecomment-2665365280 Yep I restarted the CI Jobs, GitHub CI got wonky talking to its own Docker Hub :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] mpfs_irq.c: Interrupt claim must be cleared before disabling the source [nuttx]

2025-02-18 Thread via GitHub
nuttxpr commented on PR #15858: URL: https://github.com/apache/nuttx/pull/15858#issuecomment-2665301955 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] interpreters/quickjs/CMakeLists.txt: Sync of build Cmake with build Make [nuttx-apps]

2025-02-18 Thread via GitHub
simbit18 opened a new pull request, #3001: URL: https://github.com/apache/nuttx-apps/pull/3001 ## Summary Setting the right version 2024-02-14 To avoid future breakage, used the URL with last commit ID PR ## Impact Impact on user: NO. Impact on build: YES

[PR] arm64: Initialize sctrl_el1 when running fork [nuttx]

2025-02-18 Thread via GitHub
W-M-R opened a new pull request, #15857: URL: https://github.com/apache/nuttx/pull/15857 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary arm64: Initialize sctrl_el1 when running fork ## Impact

Re: [I] [FEATURE] Common interface for LORA chips [nuttx]

2025-02-18 Thread via GitHub
keever50 commented on issue #15856: URL: https://github.com/apache/nuttx/issues/15856#issuecomment-2665140713 my idea was to use the current WLIOC, but extend it with the modulation. ex: WLIOC_LORA, WLIOC_GFSK, WLIOC_OOK, WLIOC_QPSK etc. LoRa devices often can use multiple modulation techni

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-18 Thread via GitHub
keever50 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2665085991 @raiden00pl good points. What do we imagine the ioctl commands would look like? Currently in that PR i see that WLIOC is used to implement specific LoRa features. Personally

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-18 Thread via GitHub
raiden00pl commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2665058726 https://github.com/apache/nuttx/pull/15828 here is another PR with LORA chip support. Shared ioctl will be beneficial for this driver as well -- This is an automated message from the

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-18 Thread via GitHub
raiden00pl commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2665054625 I think that a portable API is more important than breaking the code for a few users. Breaking changes will be easy to detect and fix (compiler errors), most likely it will be some nam

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
keever50 commented on PR #15828: URL: https://github.com/apache/nuttx/pull/15828#issuecomment-2665047033 I support this idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-18 Thread via GitHub
keever50 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2665040167 There are quite some things in common between these devices. For pretty much all LoRa devices(SF, BW). Maybe it would be nice to have ioctls for common lora devices. Let me know what you

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-18 Thread via GitHub
keever50 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2665032215 @raiden00pl yes! i was thinking about trying to do this... are we sure we want to break the API? Maybe we can add wrapper macros that point to SX12XX ioctls. That way old apps dont need

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
raiden00pl commented on PR #15828: URL: https://github.com/apache/nuttx/pull/15828#issuecomment-2665028009 I think we should put some effort into the common API for LORA chips. Here is another PR with LORA chip https://github.com/apache/nuttx/pull/15795 and it would be good if all LORA chip

Re: [PR] Initial standalone sx126x driver [WIP] [nuttx]

2025-02-18 Thread via GitHub
raiden00pl commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2665013877 hi, can we make this driver interface compatible with sx127x ? It would be ideally if this driver can work with `sx127x_demo` example. this will probably require breaking changes in th

Re: [PR] feat(arch/xensa): add CONFIG_SPIRAM_MEMTEST from ESP-IDF [nuttx]

2025-02-18 Thread via GitHub
tim-sony commented on code in PR #15855: URL: https://github.com/apache/nuttx/pull/15855#discussion_r1959306469 ## arch/xtensa/src/esp32s2/esp32s2_start.c: ## @@ -404,7 +404,13 @@ static void noreturn_function IRAM_ATTR __esp32s2_start(void) else { esp_spiram_ini

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
raiden00pl commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1959330075 ## include/nuttx/wireless/ioctl.h: ## @@ -60,13 +60,31 @@ /* output power (in dBm) */ #define WLIOC_GETTXPOWER_WLC

Re: [PR] drivers/wireless: Add support for the RN903 and RN2483 LoRa modules [nuttx]

2025-02-18 Thread via GitHub
raiden00pl commented on code in PR #15828: URL: https://github.com/apache/nuttx/pull/15828#discussion_r1959316787 ## drivers/wireless/lpwan/rn2xx3/rn2xx3.c: ## @@ -0,0 +1,1612 @@ +/ + * drivers/wireless/

Re: [PR] feat(arch/xensa): add CONFIG_SPIRAM_MEMTEST from ESP-IDF [nuttx]

2025-02-18 Thread via GitHub
tim-sony commented on code in PR #15855: URL: https://github.com/apache/nuttx/pull/15855#discussion_r1959306469 ## arch/xtensa/src/esp32s2/esp32s2_start.c: ## @@ -404,7 +404,13 @@ static void noreturn_function IRAM_ATTR __esp32s2_start(void) else { esp_spiram_ini

Re: [PR] nuttx/compiler: fix build warning on GCC14 [nuttx]

2025-02-18 Thread via GitHub
anchao commented on code in PR #15848: URL: https://github.com/apache/nuttx/pull/15848#discussion_r1959260122 ## arch/arm/include/spinlock.h: ## @@ -42,33 +42,13 @@ #define SP_UNLOCKED 0 /* The Un-locked state */ #define SP_LOCKED 1 /* The Locked state */ -/* Memory barr

Re: [PR] xtensa/esp32: set cpuint to initial value after deallocate [nuttx]

2025-02-18 Thread via GitHub
royfengsss commented on PR #15829: URL: https://github.com/apache/nuttx/pull/15829#issuecomment-2664879142 @acassis , The commit message has been updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] xtensa/esp32: set cpuint to initial value after deallocate [nuttx]

2025-02-18 Thread via GitHub
royfengsss commented on PR #15829: URL: https://github.com/apache/nuttx/pull/15829#issuecomment-2664875845 Sorry for late. @tmedicci , the test is also similar to https://github.com/apache/nuttx/pull/15433, I just list as below ``` static int WDTExceptionTest1(void) { /