keever50 commented on PR #15795: URL: https://github.com/apache/nuttx/pull/15795#issuecomment-2665085991
@raiden00pl good points. What do we imagine the ioctl commands would look like? Currently in that PR i see that WLIOC is used to implement specific LoRa features. Personally i think it would be logical to say WLIOC_LORA_xxx instead putting it all on WLIOC that might be shared with other modulations, such as GFSK, OOK etc. This might make it easier to spot incompatible parameters. This allows WLIOC_GFSK, WLIOC_OOK etc in the future as well. I know the sx126x and 127x can benefit from these modulation specifics. They both can do GFSK. 127x can even do OOK. That solves that problem of awkwardly hiding them away between all the other names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
