Re: [PR] libs/libc: Set `errno` when `lib_get_tempbuffer()` fails [nuttx]

2025-01-15 Thread via GitHub
JianyuWang0623 commented on code in PR #15578: URL: https://github.com/apache/nuttx/pull/15578#discussion_r1917904996 ## libs/libc/misc/lib_tempbuffer.c: ## @@ -114,6 +114,7 @@ FAR char *lib_get_tempbuffer(size_t nbytes) #ifdef CONFIG_LIBC_TEMPBUFFER_MALLOC return lib_malloc

Re: [PR] libs/libc: Set `errno` when `lib_get_tempbuffer()` fails [nuttx]

2025-01-15 Thread via GitHub
JianyuWang0623 commented on code in PR #15578: URL: https://github.com/apache/nuttx/pull/15578#discussion_r1917900603 ## libs/libc/misc/lib_tempbuffer.c: ## @@ -114,6 +114,7 @@ FAR char *lib_get_tempbuffer(size_t nbytes) #ifdef CONFIG_LIBC_TEMPBUFFER_MALLOC return lib_malloc

[PR] libc/gnssutils: remove C99 standard flag from Make.defs [nuttx]

2025-01-15 Thread via GitHub
no1wudi opened a new pull request, #15581: URL: https://github.com/apache/nuttx/pull/15581 ## Summary - Removed explicit -std=c99 flag from Make.defs - The project-wide C standard is already set at a higher level - Keeps build configuration consistent across the codebase ## Im

Re: [PR] libs/libc: Set `errno` when `lib_get_tempbuffer()` fails [nuttx]

2025-01-15 Thread via GitHub
anchao commented on code in PR #15578: URL: https://github.com/apache/nuttx/pull/15578#discussion_r1917852662 ## libs/libc/misc/lib_tempbuffer.c: ## @@ -114,6 +114,7 @@ FAR char *lib_get_tempbuffer(size_t nbytes) #ifdef CONFIG_LIBC_TEMPBUFFER_MALLOC return lib_malloc(nbytes)

[PR] risc-v: replace fence.i with __ISB for instruction sync [nuttx]

2025-01-15 Thread via GitHub
no1wudi opened a new pull request, #15580: URL: https://github.com/apache/nuttx/pull/15580 ## Summary - Replace direct use of `fence.i` instruction with `__ISB()` macro for instruction synchronization - This change improves portability while maintaining the same functionality ##

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-15 Thread via GitHub
yamt commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2594640225 i have a question: is python acceptable for this kind of tools these days? honestly speaking, i'm not inclined to write this in C. -- This is an automated message from the Apache Git

Re: [PR] libs/libc: Set `errno` when `lib_get_tempbuffer()` fails [nuttx]

2025-01-15 Thread via GitHub
yamt commented on code in PR #15578: URL: https://github.com/apache/nuttx/pull/15578#discussion_r1917834189 ## libs/libc/misc/lib_tempbuffer.c: ## @@ -114,6 +114,7 @@ FAR char *lib_get_tempbuffer(size_t nbytes) #ifdef CONFIG_LIBC_TEMPBUFFER_MALLOC return lib_malloc(nbytes);

Re: [PR] hostfs_open:return errno from host [nuttx]

2025-01-15 Thread via GitHub
yamt commented on PR #15535: URL: https://github.com/apache/nuttx/pull/15535#issuecomment-2594606524 > Ok, let @crafcat7 provide a full mapping for macOS. i'm working on that direction. https://github.com/apache/nuttx/pull/15579 -- This is an automated message from the Apache Git Se

Re: [PR] generate errno definitions from CSV [nuttx]

2025-01-15 Thread via GitHub
nuttxpr commented on PR #15579: URL: https://github.com/apache/nuttx/pull/15579#issuecomment-2594587114 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

[PR] generate errno definitions from CSV [nuttx]

2025-01-15 Thread via GitHub
yamt opened a new pull request, #15579: URL: https://github.com/apache/nuttx/pull/15579 ## Summary generate errno definitions from a CSV file for flexibility. i plan to use this CSV file for other things like host <-> nuttx errno conversion logic. ## Impact ## Tes

[PR] libs/libc: Set `errno` when `lib_get_tempbuffer()` fails [nuttx]

2025-01-15 Thread via GitHub
JianyuWang0623 opened a new pull request, #15578: URL: https://github.com/apache/nuttx/pull/15578 ## Summary libs/libc: Set `errno` when `lib_get_tempbuffer()` fails ## Impact lib_get_tempbuffer() ## Testing CI -- This is an automated message from the Apache

Re: [PR] Update cmocka --skip test command [nuttx]

2025-01-15 Thread via GitHub
Zhangshoukui closed pull request #15574: Update cmocka --skip test command URL: https://github.com/apache/nuttx/pull/15574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Update cmocka --skip test command [nuttx]

2025-01-15 Thread via GitHub
Zhangshoukui commented on PR #15574: URL: https://github.com/apache/nuttx/pull/15574#issuecomment-2594562099 close this PR, I will now fix test_case_posix_timer test_case_oneshot write_default|read_default|burst_test gpiotest01 on the sim. Resubmit after fixed -- This is an automated m

Re: [PR] Driver test issue fix [nuttx-apps]

2025-01-15 Thread via GitHub
Zhangshoukui closed pull request #2947: Driver test issue fix URL: https://github.com/apache/nuttx-apps/pull/2947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Driver test issue fix [nuttx-apps]

2025-01-15 Thread via GitHub
Zhangshoukui commented on PR #2947: URL: https://github.com/apache/nuttx-apps/pull/2947#issuecomment-2594561502 close this PR, I will now fix test_case_posix_timer test_case_oneshot write_default|read_default|burst_test gpiotest01 on the sim. Resubmit after fixed -- This is an automate

Re: [PR] Driver test issue fix [nuttx-apps]

2025-01-15 Thread via GitHub
Zhangshoukui commented on PR #2947: URL: https://github.com/apache/nuttx-apps/pull/2947#issuecomment-2594561141 > but we should fix the ci error instead disalbing driver_test. cmocka --skip test_case_posix_timer|test_case_oneshot|write_default|read_default|burst_test|gpiotest01 clo

Re: [PR] sched/timer: remove critical section [nuttx]

2025-01-15 Thread via GitHub
yamt commented on code in PR #15561: URL: https://github.com/apache/nuttx/pull/15561#discussion_r1917702723 ## sched/timer/timer_initialize.c: ## @@ -39,6 +39,12 @@ #ifndef CONFIG_DISABLE_POSIX_TIMERS +/***

Re: [PR] apps/nshlib: Save result and return ERROR if `lib_get_tempbuffer()` fails [nuttx-apps]

2025-01-15 Thread via GitHub
nuttxpr commented on PR #2950: URL: https://github.com/apache/nuttx-apps/pull/2950#issuecomment-2594508445 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requiremen

[PR] apps/nshlib: Save result and return ERROR if `lib_get_tempbuffer()` fails [nuttx-apps]

2025-01-15 Thread via GitHub
JianyuWang0623 opened a new pull request, #2950: URL: https://github.com/apache/nuttx-apps/pull/2950 ## Summary apps/nshlib: Save result and return ERROR if `lib_get_tempbuffer()` fails, missing goto ;-( ## Impact apps/nshlib: background ## Testing CI -- This is an

Re: [PR] avoid variable length arrays [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #15577: URL: https://github.com/apache/nuttx/pull/15577#discussion_r1917703775 ## net/usrsock/usrsock_sendmsg.c: ## @@ -142,9 +143,18 @@ static int do_sendto_request(FAR struct usrsock_conn_s *conn, { }; - struct iovec bufs[2 + m

Re: [PR] avoid variable length arrays [nuttx]

2025-01-15 Thread via GitHub
nuttxpr commented on PR #15577: URL: https://github.com/apache/nuttx/pull/15577#issuecomment-2594468015 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

Re: [PR] Driver test issue fix [nuttx-apps]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on PR #2947: URL: https://github.com/apache/nuttx-apps/pull/2947#issuecomment-2594441148 but we should fix the ci error instead disalbing driver_test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Support for the mouse ioctl interface [nuttx]

2025-01-15 Thread via GitHub
HongChao6 commented on PR #15205: URL: https://github.com/apache/nuttx/pull/15205#issuecomment-2594439558 > Please fix the commit title: nuxxt -> nuttx done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] irq: Add 0 address access panic configuration [nuttx]

2025-01-15 Thread via GitHub
W-M-R commented on code in PR #15562: URL: https://github.com/apache/nuttx/pull/15562#discussion_r1917623199 ## sched/irq/irq_initialize.c: ## @@ -87,5 +96,11 @@ void irq_initialize(void) #endif up_irqinitialize(); + +#ifdef CONFIG_ARCH_PROTECT_ZERO_ADDRESS + up_debugpoin

Re: [PR] irq: Add 0 address access panic configuration [nuttx]

2025-01-15 Thread via GitHub
W-M-R commented on code in PR #15562: URL: https://github.com/apache/nuttx/pull/15562#discussion_r1917623199 ## sched/irq/irq_initialize.c: ## @@ -87,5 +96,11 @@ void irq_initialize(void) #endif up_irqinitialize(); + +#ifdef CONFIG_ARCH_PROTECT_ZERO_ADDRESS + up_debugpoin

Re: [PR] irq: Add 0 address access panic configuration [nuttx]

2025-01-15 Thread via GitHub
W-M-R commented on code in PR #15562: URL: https://github.com/apache/nuttx/pull/15562#discussion_r1917623199 ## sched/irq/irq_initialize.c: ## @@ -87,5 +96,11 @@ void irq_initialize(void) #endif up_irqinitialize(); + +#ifdef CONFIG_ARCH_PROTECT_ZERO_ADDRESS + up_debugpoin

Re: [PR] Use lib_get_tempbuffer Saving stack [nuttx-apps]

2025-01-15 Thread via GitHub
cederom commented on code in PR #2946: URL: https://github.com/apache/nuttx-apps/pull/2946#discussion_r1917617896 ## system/nxrecorder/nxrecorder_main.c: ## @@ -531,7 +531,7 @@ static int nxrecorder_cmd_help(FAR struct nxrecorder_s *precorder, int main(int argc, FAR char *ar

Re: [PR] irq: Add 0 address access panic configuration [nuttx]

2025-01-15 Thread via GitHub
W-M-R commented on code in PR #15562: URL: https://github.com/apache/nuttx/pull/15562#discussion_r1917611099 ## arch/Kconfig: ## @@ -538,6 +538,14 @@ config ARCH_PERF_EVENTS Enable hardware performance counter support for perf events. If disabled,

Re: [PR] Fix CRC and test on Raspberry Pi Pico [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #15570: URL: https://github.com/apache/nuttx/pull/15570#discussion_r1917600126 ## include/nuttx/sensors/ms_crc4.h: ## @@ -44,41 +44,40 @@ static uint8_t ms_crc4(FAR uint16_t *src, uint16_t crcmask) {

Re: [PR] Update cmocka --skip test command [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #15574: URL: https://github.com/apache/nuttx/pull/15574#discussion_r1917599125 ## tools/ci/testrun/script/test_framework/test_cmocka.py: ## @@ -49,7 +49,7 @@ def test_cmocka(p): p.sendCommand(f"echo {cmocka_test_start}") ret = p.

Re: [PR] hostfs_open:return errno from host [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on PR #15535: URL: https://github.com/apache/nuttx/pull/15535#issuecomment-2594372313 Ok, let @crafcat7 provide a full mapping for macOS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Use lib_get_tempbuffer Saving stack [nuttx-apps]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #2946: URL: https://github.com/apache/nuttx-apps/pull/2946#discussion_r1917588376 ## system/nxrecorder/nxrecorder_main.c: ## @@ -531,7 +531,7 @@ static int nxrecorder_cmd_help(FAR struct nxrecorder_s *precorder, int main(int argc, FAR

[PR] lp503x_main: Minor fix [nuttx-apps]

2025-01-15 Thread via GitHub
Zhangshoukui opened a new pull request, #2949: URL: https://github.com/apache/nuttx-apps/pull/2949 ## Summary lp503x_main: Minor fix ## Impact NONE ## Testing local test -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] pthread_cond_wait: Add mutex to protect the waiter count [nuttx]

2025-01-15 Thread via GitHub
yamt commented on code in PR #15566: URL: https://github.com/apache/nuttx/pull/15566#discussion_r1917569176 ## libs/libc/pthread/pthread_condinit.c: ## @@ -75,6 +77,7 @@ int pthread_cond_init(FAR pthread_cond_t *cond, { cond->clockid = attr ? attr->clockid : CLOCK_RE

Re: [PR] sched/wdog: remove wd_cancel_irq() implement [nuttx]

2025-01-15 Thread via GitHub
nuttxpr commented on PR #15576: URL: https://github.com/apache/nuttx/pull/15576#issuecomment-2594335533 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

Re: [PR] Use lib_get_tempbuffer Saving stack [nuttx-apps]

2025-01-15 Thread via GitHub
Zhangshoukui commented on code in PR #2946: URL: https://github.com/apache/nuttx-apps/pull/2946#discussion_r1917571579 ## nshlib/nsh_timcmds.c: ## @@ -552,7 +553,7 @@ int cmd_timedatectl(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv) #ifndef CONFIG_NSH_DISABLE_WATCH

[PR] sched/wdog: remove wd_cancel_irq() implement [nuttx]

2025-01-15 Thread via GitHub
anchao opened a new pull request, #15576: URL: https://github.com/apache/nuttx/pull/15576 ## Summary sched/wdog: remove wd_cancel_irq() implement we do not need this implement after change the lock from csec to spin_lock Signed-off-by: chao an ## Impact

Re: [PR] sched/timer: remove critical section [nuttx]

2025-01-15 Thread via GitHub
hujun260 commented on code in PR #15561: URL: https://github.com/apache/nuttx/pull/15561#discussion_r1917568740 ## sched/timer/timer_setitimer.c: ## @@ -103,14 +108,14 @@ int setitimer(int which, FAR const struct itimerval *value, rtcb = this_task(); - flags = enter_cri

Re: [PR] sched/timer: remove critical section [nuttx]

2025-01-15 Thread via GitHub
hujun260 commented on code in PR #15561: URL: https://github.com/apache/nuttx/pull/15561#discussion_r1917568338 ## sched/timer/timer_initialize.c: ## @@ -136,19 +136,21 @@ void timer_deleteall(pid_t pid) FAR struct posix_timer_s *next; irqstate_t flags; - flags = enter_

[PR] sched/wqueue: fix potential deadlock [nuttx]

2025-01-15 Thread via GitHub
anchao opened a new pull request, #15575: URL: https://github.com/apache/nuttx/pull/15575 ## Summary sched/wqueue: fix potential deadlock sched_unlock() should called after spin_unlock Signed-off-by: chao an ## Impact N/A ## Testing ci-che

Re: [PR] Driver test issue fix [nuttx-apps]

2025-01-15 Thread via GitHub
Zhangshoukui commented on PR #2947: URL: https://github.com/apache/nuttx-apps/pull/2947#issuecomment-2594310066 > ret = p.sendCommand( "cmocka --skip test_case_posix_timer|test_case_oneshot|write_default|read_default|burst_test|gpiotest01|" "test_playback._|test_interaction._|test_stress._|

[PR] Update cmocka --skip test command [nuttx]

2025-01-15 Thread via GitHub
Zhangshoukui opened a new pull request, #15574: URL: https://github.com/apache/nuttx/pull/15574 Update cmocka --skip test command ## Summary for this https://github.com/apache/nuttx-apps/pull/2947 I am prepared to submit the plan two times: 1. skip drivertest*

Re: [PR] sensors/sht4x: Converted SHT4X driver to UORB framework. [nuttx]

2025-01-15 Thread via GitHub
linguini1 commented on PR #15573: URL: https://github.com/apache/nuttx/pull/15573#issuecomment-2594299960 @raiden00pl @Donny9 This is my attempt at dipping my toes in UORB with a sensor driver I've already written and which fits into the existing UORB framework before I try to add thermocou

[PR] sensors/sht4x: Converted SHT4X driver to UORB framework. [nuttx]

2025-01-15 Thread via GitHub
linguini1 opened a new pull request, #15573: URL: https://github.com/apache/nuttx/pull/15573 ## Summary This PR converts the SHT4X driver to the UORB framework. ## Impact The impact is that one more sensor is part of the UORB framework, which unifies the way that sensors

Re: [PR] The placement of cases under testing is a bit messy, and cases of the same type need to be merged [nuttx-apps]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on PR #2931: URL: https://github.com/apache/nuttx-apps/pull/2931#issuecomment-2594294207 > if we decide to separate testing utilities and test scenarios, then this PR doesn't make much sense. The problem is how to split these applications, `testing`, `tests` and `t

Re: [PR] hostfs_open:return errno from host [nuttx]

2025-01-15 Thread via GitHub
yamt commented on PR #15535: URL: https://github.com/apache/nuttx/pull/15535#issuecomment-2594294205 > > > > > @yamt the conversion of errno will provide in a new pr soon, so let's merge this patch first. > > > > > > > > > > > > sorry, i'm against it. your reasoning sounds like "m

Re: [PR] hostfs_open:return errno from host [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on PR #15535: URL: https://github.com/apache/nuttx/pull/15535#issuecomment-2594288220 > > > > @yamt the conversion of errno will provide in a new pr soon, so let's merge this patch first. > > > > > > > > > sorry, i'm against it. your reasoning sounds like

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-15 Thread via GitHub
anchao commented on PR #15551: URL: https://github.com/apache/nuttx/pull/15551#issuecomment-2594283714 > i feel sched is a more natural place for them than libc. if you are unhappy with sched, how about fs/Kconfig? Sure, except for the sched directory, libc/fs is more reasonable.

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-15 Thread via GitHub
yamt commented on code in PR #15551: URL: https://github.com/apache/nuttx/pull/15551#discussion_r1917538858 ## boards/arm/nrf53/nrf5340-dk/configs/qspi_cpuapp/#defconfig#: ## @@ -21,14 +21,14 @@ CONFIG_BOARD_LOOPSPERMSEC=5500 CONFIG_EXPERIMENTAL=y CONFIG_FS_LITTLEFS=y CONFIG_

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-15 Thread via GitHub
yamt commented on PR #15551: URL: https://github.com/apache/nuttx/pull/15551#issuecomment-2594270835 > > > > > > > > why not? they are kernel characteristics as far as i know. > > > > > > > > > > > > > > > > > > > > > Let me clarify further, should be"define", not "use" > > > >

Re: [PR] Fix CRC and test on Raspberry Pi Pico [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #15570: URL: https://github.com/apache/nuttx/pull/15570#discussion_r1917537226 ## include/nuttx/sensors/ms_crc4.h: ## @@ -43,42 +43,41 @@ static uint8_t ms_crc4(FAR uint16_t *src, uint8_t crcndx,

Re: [PR] hostfs_open:return errno from host [nuttx]

2025-01-15 Thread via GitHub
yamt commented on PR #15535: URL: https://github.com/apache/nuttx/pull/15535#issuecomment-2594256041 > > > @yamt the conversion of errno will provide in a new pr soon, so let's merge this patch first. > > > > > > sorry, i'm against it. your reasoning sounds like "merge changes whi

[I] [BUG] msg_iovlen == 1 assumptions in sendmsg/recvmsg [nuttx]

2025-01-15 Thread via GitHub
yamt opened a new issue, #15571: URL: https://github.com/apache/nuttx/issues/15571 ### Description / Steps to reproduce the issue * inet_sendmsg handles msg_iovlen != 1 cases by copying to a temporary buffer. it isn't ideal. * otherwise, in most of places, msg_iovlen != 1 for sendm

Re: [PR] armv7a/r: fix regression from https://github.com/apache/nuttx/pull/14596 [nuttx]

2025-01-15 Thread via GitHub
yf13 commented on PR #15550: URL: https://github.com/apache/nuttx/pull/15550#issuecomment-2594206971 > @yf13 This pr fix the issue you mentioned in kernel mode thanks, now the `qemu-armv7a:knsh` can pass ostest. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] sim_hostfs:add host_errno_convert API for convert result [nuttx]

2025-01-15 Thread via GitHub
yamt commented on PR #15552: URL: https://github.com/apache/nuttx/pull/15552#issuecomment-2594184662 > > * i suspect the "generic" error number used for the case where conversion is not available might need to be per-operation. > > it's better to apply the complex approach util we hit

Re: [PR] pthread_cond_wait: Add mutex to protect the waiter count [nuttx]

2025-01-15 Thread via GitHub
hujun260 commented on PR #15566: URL: https://github.com/apache/nuttx/pull/15566#issuecomment-2594171650 > atomic_load use atomic_read -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] armv7a/r: fix regression from https://github.com/apache/nuttx/pull/14596 [nuttx]

2025-01-15 Thread via GitHub
hujun260 commented on PR #15550: URL: https://github.com/apache/nuttx/pull/15550#issuecomment-2594168631 @yf13 This pr fix the issue you mentioned in kernel mode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] pthread_cond_wait: Add mutex to protect the waiter count [nuttx]

2025-01-15 Thread via GitHub
hujun260 commented on code in PR #15566: URL: https://github.com/apache/nuttx/pull/15566#discussion_r1917481997 ## sched/pthread/pthread_condsignal.c: ## @@ -68,12 +66,16 @@ int pthread_cond_signal(FAR pthread_cond_t *cond) } else { - if (cond->wait_count > 0)

Re: [PR] armv7a/r: fix regression from https://github.com/apache/nuttx/pull/14596 [nuttx]

2025-01-15 Thread via GitHub
hujun260 commented on PR #15550: URL: https://github.com/apache/nuttx/pull/15550#issuecomment-2594150158 > @hujun260 please review other similar places to ensure all same problems get fixed. ok -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Fix CRC and test on Raspberry Pi Pico [nuttx]

2025-01-15 Thread via GitHub
nuttxpr commented on PR #15570: URL: https://github.com/apache/nuttx/pull/15570#issuecomment-2593778904 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

[PR] Fix CRC and test on Raspberry Pi Pico [nuttx]

2025-01-15 Thread via GitHub
linguini1 opened a new pull request, #15570: URL: https://github.com/apache/nuttx/pull/15570 ## Summary This PR comes from InSpace. For some reason, the CRC check in its current state fails for the MS5611 sensors that InSpace has. We've tested on four different sensors to confi

Re: [PR] irq: Add 0 address access panic configuration [nuttx]

2025-01-15 Thread via GitHub
anchao commented on code in PR #15562: URL: https://github.com/apache/nuttx/pull/15562#discussion_r1917036700 ## sched/irq/irq_initialize.c: ## @@ -87,5 +96,11 @@ void irq_initialize(void) #endif up_irqinitialize(); + +#ifdef CONFIG_ARCH_PROTECT_ZERO_ADDRESS + up_debugpoi

Re: [PR] irq: Add 0 address access panic configuration [nuttx]

2025-01-15 Thread via GitHub
anchao commented on code in PR #15562: URL: https://github.com/apache/nuttx/pull/15562#discussion_r1917021796 ## sched/irq/irq_initialize.c: ## @@ -87,5 +96,11 @@ void irq_initialize(void) #endif up_irqinitialize(); + +#ifdef CONFIG_ARCH_PROTECT_ZERO_ADDRESS + up_debugpoi

Re: [PR] irq: Add 0 address access panic configuration [nuttx]

2025-01-15 Thread via GitHub
anchao commented on code in PR #15562: URL: https://github.com/apache/nuttx/pull/15562#discussion_r1917018648 ## sched/irq/irq_initialize.c: ## @@ -87,5 +96,11 @@ void irq_initialize(void) #endif up_irqinitialize(); + +#ifdef CONFIG_ARCH_PROTECT_ZERO_ADDRESS + up_debugpoi

Re: [PR] The placement of cases under testing is a bit messy, and cases of the same type need to be merged [nuttx-apps]

2025-01-15 Thread via GitHub
cederom commented on PR #2931: URL: https://github.com/apache/nuttx-apps/pull/2931#issuecomment-2593427770 > @raiden00pl: if we decide to separate testing utilities and test scenarios, then this PR doesn't make much sense. The problem is how to split these applications, `testing`, `tests`

Re: [PR] armv7a/r: fix regression from https://github.com/apache/nuttx/pull/14596 [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on PR #15550: URL: https://github.com/apache/nuttx/pull/15550#issuecomment-2593350156 @hujun260 please review other similar places to ensure all same problems get fixed. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Documentation: update uorb and sensor driver doc [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on PR #15557: URL: https://github.com/apache/nuttx/pull/15557#issuecomment-2593348403 @Donny9 there a trick to download the picture without watermark, let's talk offline. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Release/12.5 [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 closed pull request #15568: Release/12.5 URL: https://github.com/apache/nuttx/pull/15568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Release/12.7 [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on PR #15569: URL: https://github.com/apache/nuttx/pull/15569#issuecomment-2593340550 let's close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Release/12.7 [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 closed pull request #15569: Release/12.7 URL: https://github.com/apache/nuttx/pull/15569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] hostfs_open:return errno from host [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on PR #15535: URL: https://github.com/apache/nuttx/pull/15535#issuecomment-2593335289 > > @yamt the conversion of errno will provide in a new pr soon, so let's merge this patch first. > > sorry, i'm against it. your reasoning sounds like "merge changes which

Re: [PR] Release/12.7 [nuttx]

2025-01-15 Thread via GitHub
ykurt52 commented on PR #15569: URL: https://github.com/apache/nuttx/pull/15569#issuecomment-2593323807 Sorry for the confusion, I don't know why cause I didn't push. I was doing something with AI and the same problem happened in my other repos. Sorry again. 15 Oca 2025 Çar 18:21

Re: [I] Proposed improvements to the sensor framwork [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on issue #10644: URL: https://github.com/apache/nuttx/issues/10644#issuecomment-2593312419 Yes, this is an acceptable approach to handle no-FPU case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Use lib_get_tempbuffer Saving stack [nuttx-apps]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #2946: URL: https://github.com/apache/nuttx-apps/pull/2946#discussion_r1916913561 ## nshlib/nsh_timcmds.c: ## @@ -552,7 +553,7 @@ int cmd_timedatectl(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv) #ifndef CONFIG_NSH_DISABLE_WATC

(nuttx) branch master updated (0c97296f39 -> 027a57071a)

2025-01-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 0c97296f39 syslog_intbuffer:fix build warning add 027a57071a boards/xtensa: disable DEV_CONSOLE on usbnsh defco

Re: [PR] irq: Add 0 address access panic configuration [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #15562: URL: https://github.com/apache/nuttx/pull/15562#discussion_r1916860050 ## sched/irq/irq_initialize.c: ## @@ -87,5 +96,11 @@ void irq_initialize(void) #endif up_irqinitialize(); + +#ifdef CONFIG_ARCH_PROTECT_ZERO_ADDRESS + up

(nuttx) branch master updated (027a57071a -> 118f827103)

2025-01-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 027a57071a boards/xtensa: disable DEV_CONSOLE on usbnsh defconfig add 118f827103 sim_hostfs:add host_errno_conv

Re: [PR] sim_hostfs:add host_errno_convert API for convert result [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 merged PR #15552: URL: https://github.com/apache/nuttx/pull/15552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] boards/xtensa: disable DEV_CONSOLE on usbnsh defconfig [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 merged PR #15524: URL: https://github.com/apache/nuttx/pull/15524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] boards/xtensa: disable DEV_CONSOLE on usbnsh defconfig [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on PR #15524: URL: https://github.com/apache/nuttx/pull/15524#issuecomment-2593229083 let's merge this simple chagne to unlock the user, and develop the better solution later. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] irq: Add 0 address access panic configuration [nuttx]

2025-01-15 Thread via GitHub
acassis commented on code in PR #15562: URL: https://github.com/apache/nuttx/pull/15562#discussion_r1916864994 ## arch/Kconfig: ## @@ -538,6 +538,14 @@ config ARCH_PERF_EVENTS Enable hardware performance counter support for perf events. If disable

(nuttx) 02/02: syslog_intbuffer:fix build warning

2025-01-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 0c97296f397384cd8d6f50f4941a7e8ac49d0bcf Author: chenrun1 AuthorDate: Wed Jan 15 16:34:00 2025 +0800 syslog_intbu

Re: [PR] syslog_intbuffer.c:Fixed recursive spinlock during assert [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 merged PR #15560: URL: https://github.com/apache/nuttx/pull/15560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (ad7198069d -> 0c97296f39)

2025-01-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from ad7198069d arm/qemu: select PSCI at processor level new 3b6f463ce2 syslog_inbuffer:Fixed the lock reentry issue

(nuttx) 01/02: syslog_inbuffer:Fixed the lock reentry issue in single core + spinlock scenario

2025-01-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 3b6f463ce2b54d1934e4357b4ea1d81635161c95 Author: chenrun1 AuthorDate: Tue Dec 31 14:31:46 2024 +0800 syslog_inbuf

Re: [PR] irq: Add 0 address access panic configuration [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #15562: URL: https://github.com/apache/nuttx/pull/15562#discussion_r1916858023 ## arch/Kconfig: ## @@ -538,6 +538,14 @@ config ARCH_PERF_EVENTS Enable hardware performance counter support for perf events. If

(nuttx) branch master updated (46c3f354b3 -> dedb57cb2d)

2025-01-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 46c3f354b3 drivers/can: ctucanfd the first round of fixes - mainly for char dev add 71a37b4f2d Documentation:

Re: [PR] irq: Add 0 address access panic configuration [nuttx]

2025-01-15 Thread via GitHub
acassis commented on code in PR #15562: URL: https://github.com/apache/nuttx/pull/15562#discussion_r1916853313 ## arch/Kconfig: ## @@ -538,6 +538,14 @@ config ARCH_PERF_EVENTS Enable hardware performance counter support for perf events. If disable

(nuttx) branch master updated (dedb57cb2d -> ad7198069d)

2025-01-15 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from dedb57cb2d libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd add ad7198069d arm/qemu: select PSCI at

Re: [PR] arm/qemu: select PSCI at processor level [nuttx]

2025-01-15 Thread via GitHub
acassis merged PR #15565: URL: https://github.com/apache/nuttx/pull/15565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] Release/12.7 [nuttx]

2025-01-15 Thread via GitHub
acassis commented on PR #15569: URL: https://github.com/apache/nuttx/pull/15569#issuecomment-2593175240 > @ykurt52 why do you push the released branch to master again? Probably some mistake, same happening in the previous PR -- This is an automated message from the Apache Git Servic

Re: [PR] Release/12.5 [nuttx]

2025-01-15 Thread via GitHub
acassis commented on PR #15568: URL: https://github.com/apache/nuttx/pull/15568#issuecomment-2593170052 Hi @ykurt52 I think there is something wrong with this PR, what was your goal, which feature are you trying to submit? -- This is an automated message from the Apache Git Service. To re

Re: [PR] apps/nshlib: Remove the deprecated config `NSH_LINELEN` [nuttx-apps]

2025-01-15 Thread via GitHub
JianyuWang0623 commented on PR #2945: URL: https://github.com/apache/nuttx-apps/pull/2945#issuecomment-2593167872 > Maybe a short mention in the git commit message would be helpful for anyone in the future to understand why it was removed? > > NSH_LINELEN is replaced by POSIX standard

Re: [PR] Release/12.5 [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on PR #15568: URL: https://github.com/apache/nuttx/pull/15568#issuecomment-2593165351 @ykurt52 why push an already plublsh moentian -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] libc/unistd: move NAME_MAX/LINE_MAX/PATH_MAX define to unistd [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 merged PR #15551: URL: https://github.com/apache/nuttx/pull/15551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Release/12.7 [nuttx]

2025-01-15 Thread via GitHub
xiaoxiang781216 commented on PR #15569: URL: https://github.com/apache/nuttx/pull/15569#issuecomment-2593089562 @ykurt52 why do you push the released branch to master again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Release/12.5 [nuttx]

2025-01-15 Thread via GitHub
nuttxpr commented on PR #15568: URL: https://github.com/apache/nuttx/pull/15568#issuecomment-2592941002 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

Re: [PR] Release/12.7 [nuttx]

2025-01-15 Thread via GitHub
nuttxpr commented on PR #15569: URL: https://github.com/apache/nuttx/pull/15569#issuecomment-2592938193 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR template itself meets the NuttX requirements by

[PR] Release/12.7 [nuttx]

2025-01-15 Thread via GitHub
ykurt52 opened a new pull request, #15569: URL: https://github.com/apache/nuttx/pull/15569 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary *Update this section with information on why change is necessar

Re: [PR] Release/12.7 [nuttx-apps]

2025-01-15 Thread via GitHub
ykurt52 closed pull request #2948: Release/12.7 URL: https://github.com/apache/nuttx-apps/pull/2948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

  1   2   >