xiaoxiang781216 commented on code in PR #2946:
URL: https://github.com/apache/nuttx-apps/pull/2946#discussion_r1916913561
##########
nshlib/nsh_timcmds.c:
##########
@@ -552,7 +553,7 @@ int cmd_timedatectl(FAR struct nsh_vtbl_s *vtbl, int argc,
FAR char **argv)
#ifndef CONFIG_NSH_DISABLE_WATCH
int cmd_watch(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv)
{
- char buffer[LINE_MAX];
Review Comment:
do we have other places in nshlib which reserve big buffer on the stack
##########
system/taskset/taskset.c:
##########
@@ -82,14 +82,20 @@ static bool get_cpuset(const char *arg, cpu_set_t *cpu_set)
int main(int argc, FAR char *argv[])
{
- char command[LINE_MAX];
Review Comment:
the buffer(200~) allocated in main isn't a big issue, we could ignore it.
##########
examples/lp503x/lp503x_main.c:
##########
@@ -625,20 +625,26 @@ static int lp503x_cmd_help(FAR char *parg)
int main(int argc, FAR char *argv[])
{
+ FAR char *buffer;
+ FAR char *cmd;
+ FAR char *arg;
bool running;
- char buffer[LINE_MAX];
Review Comment:
but the loop at line 651 may run a long time, which make other program fail
to get temp buffer more easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
