Re: [PR] cmake:bugfix kconfig menu in cmake cannot be generated recursively [nuttx]

2024-11-17 Thread via GitHub
xuxin930 commented on PR #14756: URL: https://github.com/apache/nuttx/pull/14756#issuecomment-2482177921 > Will this pull request cause Kconfig to be generated for all directories containing CMakeLists.txt/Makefile? In fact, makefile base does not support nested recursion. If multiple level

Re: [PR] drivers/syslog: remove implement of syslog_putc() [nuttx]

2024-11-17 Thread via GitHub
yamt commented on code in PR #14810: URL: https://github.com/apache/nuttx/pull/14810#discussion_r1846033438 ## arch/arm/src/efm32/efm32_start.c: ## @@ -84,7 +84,7 @@ const uintptr_t g_idle_topstack = HEAP_BASE; #ifdef CONFIG_DEBUG_FEATURES # if defined(CONFIG_ARMV7M_ITMSYSL

Re: [I] GPIO issues on BL602 + suggestions for RISC-V, maybe more. [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 closed issue #5810: GPIO issues on BL602 + suggestions for RISC-V, maybe more. URL: https://github.com/apache/nuttx/issues/5810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] usbtrace causes crash [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on issue #12181: URL: https://github.com/apache/nuttx/issues/12181#issuecomment-2482162190 let's close this issue and focus on #1138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] a few comment fixes [nuttx]

2024-11-17 Thread via GitHub
nuttxpr commented on PR #14834: URL: https://github.com/apache/nuttx/pull/14834#issuecomment-2482150520 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

[PR] a few comment fixes [nuttx]

2024-11-17 Thread via GitHub
yamt opened a new pull request, #14834: URL: https://github.com/apache/nuttx/pull/14834 ## Summary a few comment fixes. ## Impact no functional changes are expected. ## Testing build tested. -- This is an automated message from the Apache Git Service. To

Re: [PR] spinlock+sched_lock [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on PR #14578: URL: https://github.com/apache/nuttx/pull/14578#issuecomment-2482145105 @patacongo please review this patch which fix the long issue about sched lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] arch_atomic: nx only use atomic_long_xxx function [nuttx]

2024-11-17 Thread via GitHub
yamt commented on PR #14827: URL: https://github.com/apache/nuttx/pull/14827#issuecomment-2482139319 > > * it seems a bit wasteful to mechanically replace short with long to me. especially where structure fields are arranged for a short. > > * why long? i suspect it's simpler to use a fix

Re: [PR] spinlock+sched_lock [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #14578: URL: https://github.com/apache/nuttx/pull/14578#discussion_r1845964106 ## sched/sched/sched.h: ## @@ -37,6 +37,7 @@ #include #include #include +#include Review Comment: why add ## sched/sched/sched.h:

(nuttx) 02/02: SYSLOG_DEFAULT: avoid using critical section in certain cases

2024-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 637a0f5af2309a2a51574e078fddfc38fecf5d4e Author: YAMAMOTO Takashi AuthorDate: Thu Nov 14 16:45:41 2024 +0900 SYSL

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2482037422 > @xiaoxiang781216 I was thinking this was CMUX support for NuttX, but seems like it has other purpose, probably to run on Linux side. Could you please explain the idea of this to

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2482038344 > Please could you add a brief explanation what is cmux and what it is for in the PR description and commit log? Thanks. Update, you can learn the concept and spec from:

(nuttx) 01/02: Reapply "SYSLOG_DEFAULT: wrap up_putc/up_nputs calls with critical section"

2024-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit b990b25b8ecd2e73548ae54742637c451f2f0589 Author: YAMAMOTO Takashi AuthorDate: Wed Nov 13 18:33:58 2024 +0900 Reap

(nuttx) branch master updated (0c2ee8b492 -> 637a0f5af2)

2024-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 0c2ee8b492 fix: remove duplicated statistics of upd.drop new b990b25b8e Reapply "SYSLOG_DEFAULT: wrap up_putc/u

Re: [PR] Reapply "SYSLOG_DEFAULT: wrap up_putc/up_nputs calls with critical section" with a fix [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 merged PR #14761: URL: https://github.com/apache/nuttx/pull/14761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx-apps) branch master updated: cmake(build):add missing basic and nxlooper cmake script

2024-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new fee82bd3d cmake(build):add missing basic

Re: [PR] cmake(build):add missing basic and nxlooper cmake script [nuttx-apps]

2024-11-17 Thread via GitHub
xiaoxiang781216 merged PR #2857: URL: https://github.com/apache/nuttx-apps/pull/2857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] Revert "romfs:extend romfs to enable write" [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on PR #14833: URL: https://github.com/apache/nuttx/pull/14833#issuecomment-2482012270 > Seems all functionality is controlled by `FS_ROMFS_WRITEABLE`. Could we keep this feature? The feature will migrate to a new file system type to avoid influencing romfs.

Re: [PR] Revert "romfs:extend romfs to enable write" [nuttx]

2024-11-17 Thread via GitHub
anchao commented on PR #14833: URL: https://github.com/apache/nuttx/pull/14833#issuecomment-2481960889 Seems all functionality is controlled by `FS_ROMFS_WRITEABLE`. Could we keep this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please

(nuttx) branch master updated: fix: remove duplicated statistics of upd.drop

2024-11-17 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0c2ee8b492 fix: remove duplicated statistics of u

Re: [PR] mm/iob: remove csection [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #14764: URL: https://github.com/apache/nuttx/pull/14764#discussion_r1845720916 ## mm/iob/iob_alloc.c: ## @@ -97,10 +97,82 @@ static FAR struct iob_s *iob_alloc_committed(void) iob->io_pktlen = 0;/* Total length of the packet */

Re: [PR] arch/esp32s3: lcd add fb pandisplay [nuttx]

2024-11-17 Thread via GitHub
FASTSHIFT commented on code in PR #14701: URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845815662 ## arch/xtensa/src/esp32s3/esp32s3_lcd.c: ## @@ -545,10 +569,59 @@ static int esp32s3_lcd_base_getplaneinfo(struct fb_vtable_s *vtable, static int esp32s3_lcd_base_

Re: [PR] Revert "Add support fchstat and chstat function for littlefs" [nuttx]

2024-11-17 Thread via GitHub
yamt commented on PR #14479: URL: https://github.com/apache/nuttx/pull/14479#issuecomment-2481784380 > > > @xiaoxiang781216 i'm not sure which changes you are talking about. can you explain a bit? > > > anyway, i guess the original PR should not have contained unrelated changes together.

Re: [PR] gdbserver.py optimization [nuttx]

2024-11-17 Thread via GitHub
XuNeo commented on code in PR #14315: URL: https://github.com/apache/nuttx/pull/14315#discussion_r1845813109 ## tools/gdbserver.py: ## @@ -310,26 +314,27 @@ def parse(self): if segment.header.p_flags & 1 and not self.__text: self.__text = segment.he

Re: [PR] Reapply "SYSLOG_DEFAULT: wrap up_putc/up_nputs calls with critical section" with a fix [nuttx]

2024-11-17 Thread via GitHub
yamt commented on code in PR #14761: URL: https://github.com/apache/nuttx/pull/14761#discussion_r1845794265 ## drivers/syslog/syslog_channel.c: ## @@ -222,6 +218,32 @@ g_syslog_channel[CONFIG_SYSLOG_MAX_CHANNELS] = * Private Functions

(nuttx) branch master updated: esp32s3-devkit doc: Update the procedure after simple boot

2024-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 7d73bc6861 esp32s3-devkit doc: Update the proc

Re: [PR] esp32s3-devkit doc: Update the procedure after simple boot [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 merged PR #14832: URL: https://github.com/apache/nuttx/pull/14832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Reapply "SYSLOG_DEFAULT: wrap up_putc/up_nputs calls with critical section" with a fix [nuttx]

2024-11-17 Thread via GitHub
yamt commented on code in PR #14761: URL: https://github.com/apache/nuttx/pull/14761#discussion_r1845749858 ## drivers/syslog/syslog_channel.c: ## @@ -222,6 +218,32 @@ g_syslog_channel[CONFIG_SYSLOG_MAX_CHANNELS] = * Private Functions

Re: [PR] arch_atomic: nx only use atomic_long_xxx function [nuttx]

2024-11-17 Thread via GitHub
yamt commented on PR #14827: URL: https://github.com/apache/nuttx/pull/14827#issuecomment-2481754028 * it seems a bit wasteful to mechanically replace short with long to me. especially where structure fields are arranged for a short. * why long? i suspect it's simpler to use a fixed sized

Re: [PR] Revert "romfs:extend romfs to enable write" [nuttx]

2024-11-17 Thread via GitHub
nuttxpr commented on PR #14833: URL: https://github.com/apache/nuttx/pull/14833#issuecomment-2481821314 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does *not* fully meet the NuttX requirements. W

[PR] cmake(build):add missing basic and nxlooper cmake script [nuttx-apps]

2024-11-17 Thread via GitHub
xuxin930 opened a new pull request, #2857: URL: https://github.com/apache/nuttx-apps/pull/2857 ## Summary add interpreter basic and nxlooper missing CMake build ## Impact fix ci fail in https://github.com/apache/nuttx/actions/runs/11880169863/job/33103008538?pr=14756

Re: [PR] cmake(build):add missing basic and nxlooper cmake script [nuttx-apps]

2024-11-17 Thread via GitHub
nuttxpr commented on PR #2857: URL: https://github.com/apache/nuttx-apps/pull/2857#issuecomment-2481813946 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the Nutt

[PR] Revert "romfs:extend romfs to enable write" [nuttx]

2024-11-17 Thread via GitHub
guohao15 opened a new pull request, #14833: URL: https://github.com/apache/nuttx/pull/14833 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary This reverts commit ac6fff747a7a6122e61de373350148331a94692f.

Re: [PR] Reapply "SYSLOG_DEFAULT: wrap up_putc/up_nputs calls with critical section" with a fix [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #14761: URL: https://github.com/apache/nuttx/pull/14761#discussion_r1845734309 ## drivers/syslog/syslog_channel.c: ## @@ -222,6 +218,32 @@ g_syslog_channel[CONFIG_SYSLOG_MAX_CHANNELS] = * Private Functions *

Re: [PR] arch_atomic: nx only use atomic_long_xxx function [nuttx]

2024-11-17 Thread via GitHub
zyfeier commented on PR #14827: URL: https://github.com/apache/nuttx/pull/14827#issuecomment-2481801100 > * it seems a bit wasteful to mechanically replace short with long to me. especially where structure fields are arranged for a short. > * why long? i suspect it's simpler to use a fixe

Re: [PR] sched/mqueue: choose either mqueue or sysv at one time [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #14830: URL: https://github.com/apache/nuttx/pull/14830#discussion_r1845736519 ## sched/mqueue/mq_initialize.c: ## @@ -49,12 +49,11 @@ struct msgpool_s { -#ifndef CONFIG_DISABLE_MQUEUE +#ifdef CONFIG_DISABLE_MQUEUE_SYSV Review Comment

Re: [PR] Reapply "SYSLOG_DEFAULT: wrap up_putc/up_nputs calls with critical section" with a fix [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #14761: URL: https://github.com/apache/nuttx/pull/14761#discussion_r1845750361 ## drivers/syslog/syslog_channel.c: ## @@ -222,6 +218,32 @@ g_syslog_channel[CONFIG_SYSLOG_MAX_CHANNELS] = * Private Functions *

Re: [PR] Revert "Add support fchstat and chstat function for littlefs" [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on PR #14479: URL: https://github.com/apache/nuttx/pull/14479#issuecomment-2481789522 > > > > @xiaoxiang781216 i'm not sure which changes you are talking about. can you explain a bit? > > > > anyway, i guess the original PR should not have contained unrelated ch

[PR] esp32s3-devkit doc: Update the procedure after simple boot [nuttx]

2024-11-17 Thread via GitHub
yamt opened a new pull request, #14832: URL: https://github.com/apache/nuttx/pull/14832 ## Summary esp32s3-devkit doc: Update the procedure after simple boot ## Impact doc only ## Testing tested on esp32s3 devkitc -- This is an automated message from

Re: [PR] sched/mqueue: choose either mqueue or sysv at one time [nuttx]

2024-11-17 Thread via GitHub
zyfeier commented on code in PR #14830: URL: https://github.com/apache/nuttx/pull/14830#discussion_r1845741312 ## sched/mqueue/mq_initialize.c: ## @@ -49,12 +49,11 @@ struct msgpool_s { -#ifndef CONFIG_DISABLE_MQUEUE +#ifdef CONFIG_DISABLE_MQUEUE_SYSV Review Comment: ifn

Re: [PR] arch/esp32s3: lcd add fb pandisplay [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #14701: URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845716570 ## arch/xtensa/src/esp32s3/esp32s3_lcd.c: ## @@ -603,10 +677,43 @@ static int IRAM_ATTR lcd_interrupt(int irq, void *context, void *arg)

(nuttx-website) branch asf-site updated: Publishing web: b0df2aeab6e41e7f7f2ff29ca7dee29d2f62f031 docs: a88652fe531fc79c922c26e7f96ce602317c661d

2024-11-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new d58de7f22 Publishing web: b0df2ae

Re: [PR] Raspberry Pico 2 porting [nuttx]

2024-11-17 Thread via GitHub
hartmannathan commented on code in PR #14831: URL: https://github.com/apache/nuttx/pull/14831#discussion_r1845593556 ## Documentation/platforms/arm/rp23xx/index.rst: ## @@ -0,0 +1,207 @@ +== +RaspberryPi rp2350 +== + +The rp2350 is a dual core chi

Re: [PR] Raspberry Pico 2 porting [nuttx]

2024-11-17 Thread via GitHub
hartmannathan commented on PR #14831: URL: https://github.com/apache/nuttx/pull/14831#issuecomment-2481466066 > The PSRAM part is removed for now since I don't have a Pimoroni board at hand to test. Calling for help :) @PeterBee97 you could try writing to the mailing list and asking i

Re: [PR] arch/esp32s3: lcd add fb pandisplay [nuttx]

2024-11-17 Thread via GitHub
liamHowatt commented on code in PR #14701: URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845487682 ## arch/xtensa/src/esp32s3/esp32s3_lcd.c: ## @@ -300,13 +310,16 @@ static const struct fb_videoinfo_s g_base_videoinfo = /* This structure provides the base layer

Re: [PR] arch/esp32s3: lcd add fb pandisplay [nuttx]

2024-11-17 Thread via GitHub
liamHowatt commented on code in PR #14701: URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845487848 ## arch/xtensa/src/esp32s3/esp32s3_lcd.c: ## @@ -623,6 +663,8 @@ static int IRAM_ATTR lcd_interrupt(int irq, void *context, void *arg) regval = esp32s3_lcd_

[PR] sched/mqueue: choose either mqueue or sysv at one time [nuttx]

2024-11-17 Thread via GitHub
zyfeier opened a new pull request, #14830: URL: https://github.com/apache/nuttx/pull/14830 ## Summary Only one initialization is needed for mqueue and sysv. ## Impact mqueue ## Testing ./tools/configure.sh sim:citest pass -- This is an automated message f

Re: [PR] arch/esp32s3: lcd add fb pandisplay [nuttx]

2024-11-17 Thread via GitHub
liamHowatt commented on PR #14701: URL: https://github.com/apache/nuttx/pull/14701#issuecomment-2481313508 I've updated and validated it. It's much more correct now, despite the previous iteration technically working. > can be enabled/disabled by the user (default to `y`, I think).

Re: [PR] arch/esp32s3: lcd add fb pandisplay [nuttx]

2024-11-17 Thread via GitHub
liamHowatt commented on code in PR #14701: URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845488537 ## arch/xtensa/src/esp32s3/esp32s3_lcd.c: ## @@ -548,7 +564,31 @@ static int esp32s3_lcd_base_updatearea(struct fb_vtable_s *vtable, struct esp32s3_lcd_s *priv =

Re: [PR] arch/esp32s3: lcd add fb pandisplay [nuttx]

2024-11-17 Thread via GitHub
liamHowatt commented on code in PR #14701: URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845487977 ## arch/xtensa/src/esp32s3/esp32s3_lcd.c: ## @@ -548,7 +564,31 @@ static int esp32s3_lcd_base_updatearea(struct fb_vtable_s *vtable, struct esp32s3_lcd_s *priv =

Re: [PR] arch/esp32s3: lcd add fb pandisplay [nuttx]

2024-11-17 Thread via GitHub
liamHowatt commented on code in PR #14701: URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845487848 ## arch/xtensa/src/esp32s3/esp32s3_lcd.c: ## @@ -623,6 +663,8 @@ static int IRAM_ATTR lcd_interrupt(int irq, void *context, void *arg) regval = esp32s3_lcd_

(nuttx) 06/08: drivers/reset/core.c: fix gcc14 error

2024-11-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 1b303c2888580f0d41aaef0f846984e94a475d23 Author: p-szafonimateusz AuthorDate: Thu Oct 10 11:28:58 2024 +0200 driver

Re: [PR] Raspberry Pico 2 porting [nuttx]

2024-11-17 Thread via GitHub
github-actions[bot] commented on PR #14831: URL: https://github.com/apache/nuttx/pull/14831#issuecomment-2481265720 This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. --

Re: [PR] Raspberry Pico 2 porting [nuttx]

2024-11-17 Thread via GitHub
github-actions[bot] commented on PR #14831: URL: https://github.com/apache/nuttx/pull/14831#issuecomment-2481267694 This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. --

Re: [PR] Raspberry Pico 2 porting [nuttx]

2024-11-17 Thread via GitHub
PeterBee97 commented on PR #14831: URL: https://github.com/apache/nuttx/pull/14831#issuecomment-2481267762 The PSRAM part is removed for now since I don't have a Pimoroni board at hand to test. Calling for help :) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] WIP: Raspberry Pi Pico 2 RP2350 [nuttx]

2024-11-17 Thread via GitHub
PeterBee97 commented on PR #13305: URL: https://github.com/apache/nuttx/pull/13305#issuecomment-2481266141 Hi all, I'm continuing this PR's work in #14831. Let's giving this new berry a NuttX welcome together! :) -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] add spinlock_type.h [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on PR #14801: URL: https://github.com/apache/nuttx/pull/14801#issuecomment-2481262693 > add spinlock_type.h reason: Due to incomplete handling of spinlock_t in arch/spinlock.h, it should not be used directly by external code. Furthermore, because pthread.h and nutt

(nuttx-apps) branch master updated: cmake(build):add benchmarks osperf CMakeLists.txt

2024-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 4d301988a cmake(build):add benchmarks osp

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2481261198 > @xiaoxiang781216 I think this application depends on CMUX support in the NuttX kernel, is there a CMUX driver coming to NuttX kernel? Yes, it will come in the

Re: [PR] mm/iob: add ostest test [nuttx-apps]

2024-11-17 Thread via GitHub
xiaoxiang781216 merged PR #2849: URL: https://github.com/apache/nuttx-apps/pull/2849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(nuttx-apps) branch master updated: testing: add iob test

2024-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new d9d851813 testing: add iob test d9d851813

Re: [PR] cmake(build):add benchmarks osperf CMakeLists.txt [nuttx-apps]

2024-11-17 Thread via GitHub
xiaoxiang781216 merged PR #2856: URL: https://github.com/apache/nuttx-apps/pull/2856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(nuttx) 08/08: sched: add some DEBUGASSERT when nxsched_release_tcb()

2024-11-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit dfa24a056e7218bf7fd312ffb40451ceb38a9a7b Author: ligd AuthorDate: Wed Nov 13 12:03:23 2024 +0800 sched: add some DE

Re: [PR] arch_atomic: nx only use atomic_long_xxx function [nuttx]

2024-11-17 Thread via GitHub
zyfeier commented on code in PR #14827: URL: https://github.com/apache/nuttx/pull/14827#discussion_r1845421767 ## include/nuttx/atomic.h: ## @@ -86,11 +86,6 @@ extern "C++" #ifndef ATOMIC_VAR_INIT # define ATOMIC_VAR_INIT(value) (value) #endif Review Comment:

(nuttx) 05/08: .github/linters: Ignore E704 warning

2024-11-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 2d1ca32295284e8a14b4a8593aadf5a4fc9231d9 Author: Xiang Xiao AuthorDate: Sat Nov 16 23:08:31 2024 +0800 .github/lint

Re: [PR] sched/mqueue: choose either mqueue or sysv at one time [nuttx]

2024-11-17 Thread via GitHub
nuttxpr commented on PR #14830: URL: https://github.com/apache/nuttx/pull/14830#issuecomment-2481241785 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

(nuttx) 04/08: sim/win: Replace nuttx_mode_t with int

2024-11-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit b41d96ea67357ae3a627d8dfae5a5b75d87780f0 Author: Xiang Xiao AuthorDate: Sat Nov 16 23:06:50 2024 +0800 sim/win: Rep

(nuttx) branch master updated: arm64: fix compile failed 'tpidr_el1' undeclared

2024-11-17 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new a88652fe53 arm64: fix compile failed 'tpidr_el1'

Re: [PR] arm64: fix compile failed 'tpidr_el1' undeclared [nuttx]

2024-11-17 Thread via GitHub
anchao merged PR #14829: URL: https://github.com/apache/nuttx/pull/14829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [PR] arch_atomic: nx only use atomic_long_xxx function [nuttx]

2024-11-17 Thread via GitHub
zyfeier commented on code in PR #14827: URL: https://github.com/apache/nuttx/pull/14827#discussion_r1845421728 ## arch/sim/src/sim/sim_heap.c: ## @@ -30,7 +30,7 @@ #include #include -#include +#include Review Comment: done ## include/nuttx/lib/atomic_long.

(nuttx) 01/08: sched/misc: Remove the dup inclusion of nuttx/irq.h in assert.c

2024-11-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 1b77fd1df6b83ee4fd99a1fb1784d2864a9a0369 Author: Xiang Xiao AuthorDate: Sat Nov 16 23:03:17 2024 +0800 sched/misc:

(nuttx) 03/08: note/noteram_driver: Remove the unused variable j

2024-11-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 50de39acd5481838c17fb13df3d8c2559f153900 Author: Xiang Xiao AuthorDate: Sat Nov 16 23:04:40 2024 +0800 note/noteram

(nuttx) 07/08: add dir ignored since we changed libxx layout

2024-11-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 8c4e88fd4b0a19c136897147c350afad1936d266 Author: haopengxiang AuthorDate: Thu Nov 14 20:49:47 2024 +0800 add dir ig

(nuttx) 02/08: sensors/bmi160_uorb.c: Fix the typo error

2024-11-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 72fbbbdbf391bc01bbee12396ee9427dd1b41f34 Author: Xiang Xiao AuthorDate: Sat Nov 16 23:04:08 2024 +0800 sensors/bmi1

(nuttx) branch master updated (2d7b19b359 -> dfa24a056e)

2024-11-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 2d7b19b359 ghs: add thumb mode detection support for ghs compiler new 1b77fd1df6 sched/misc: Remove the dup inclu

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-17 Thread via GitHub
acassis commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2481192725 @xiaoxiang781216 I think this application depends on CMUX support in the NuttX kernel, is there a CMUX driver coming to NuttX kernel? -- This is an automated message from the Apache Gi

Re: [PR] cmake(build):add benchmarks osperf CMakeLists.txt [nuttx-apps]

2024-11-17 Thread via GitHub
nuttxpr commented on PR #2856: URL: https://github.com/apache/nuttx-apps/pull/2856#issuecomment-2481152735 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the Nutt

[PR] cmake(build):add benchmarks osperf CMakeLists.txt [nuttx-apps]

2024-11-17 Thread via GitHub
xuxin930 opened a new pull request, #2856: URL: https://github.com/apache/nuttx-apps/pull/2856 ## Summary add benchmarks osperf miss CMake build ## Impact fix ci fail in https://github.com/apache/nuttx/pull/14756 ## Testing ``` cmake -B build -DBOARD_CONF

(nuttx) branch master updated: Revert "sim/m64:Fix ld error with .rodata can not be used when making a PIE o…"

2024-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new f03da09122 Revert "sim/m64:Fix ld error with .

(nuttx) branch master updated: ghs: add thumb mode detection support for ghs compiler

2024-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2d7b19b359 ghs: add thumb mode detection suppo

Re: [PR] Revert "sim/m64:Fix ld error." [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 merged PR #14826: URL: https://github.com/apache/nuttx/pull/14826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] GreenHills support: add thumb mode detection support for ghs compiler [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 merged PR #14825: URL: https://github.com/apache/nuttx/pull/14825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] arm64: fix compile failed 'tpidr_el1' undeclared [nuttx]

2024-11-17 Thread via GitHub
nuttxpr commented on PR #14829: URL: https://github.com/apache/nuttx/pull/14829#issuecomment-2481009920 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements

Re: [PR] mm/iob: add ostest test [nuttx-apps]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #2849: URL: https://github.com/apache/nuttx-apps/pull/2849#discussion_r1845323572 ## testing/iob/Kconfig: ## @@ -0,0 +1,30 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the Nut