xiaoxiang781216 commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845716570
##########
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##########
@@ -603,10 +677,43 @@ static int IRAM_ATTR lcd_interrupt(int irq, void
*context, void *arg)
true);
#endif
+#ifdef CONFIG_ESP32S3_LCD_DOUBLE_BUFFERED
+ /* Pan the display to a new buffer offset if one was queued */
+
+ if (fb_paninfo_count(&g_base_vtable, FB_NO_OVERLAY) > 1)
+ {
+ fb_remove_paninfo(&g_base_vtable, FB_NO_OVERLAY);
+ }
+
+ union fb_paninfo_u info;
Review Comment:
need move to the begin of function/block
##########
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##########
@@ -244,6 +258,11 @@ static int esp32s3_lcd_base_updatearea(struct fb_vtable_s
*vtable,
const struct fb_area_s *area);
#endif
+#ifdef CONFIG_ESP32S3_LCD_DOUBLE_BUFFERED
+static int esp32s3_lcd_base_pandisplay(FAR struct fb_vtable_s *vtable,
Review Comment:
remove all FAR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
